fixed
8 comments:
If we know it's supposed to be 0x00, why not check it?
Done
Patch Set #1, Line 14114: .feature_bits = FEATURE_WRSR_WREN,
FEATURE_NO_ERASE and FEATURE_ERASED_ZERO?
Done
Patch Set #1, Line 14121: .eraseblocks = { { 256 * 1024, 1 } },
what do you mean by declaring { 256, 1 } ? I tried it and it tries to erase only first 256 bytes, al […]
Done
(spi)25 != 95, please don't hesitate to start a new file. Or maybe […]
Done
Patch Set #1, Line 269: /* ST_M95_RDID_OUTSIZE depends on size of the flash and
Please start multi-line comments with /* on a separate line. However this […]
Done
Patch Set #1, Line 272: static const unsigned char cmd[ST_M95_RDID_OUTSIZE] = {ST_M95_RDID};
spaces around ST_M95_RDID, please
Done
Patch Set #1, Line 282: "L 0x%02x, M 0x%02x, H 0x%02x]\n",
Please align output with the existing probing functions. […]
Done
Alternatively, allocate `blocklen` bytes and let spi_write_chunked() take […]
Done
To view, visit change 34496. To unsubscribe, or for help writing mail filters, visit settings.