Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61275 )
Change subject: hwaccess_x86_io.c: refactor rget_io_perms() ......................................................................
Patch Set 4: Code-Review+2
(5 comments)
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61275/comment/41bd4ffa_fb8c82bf PS3, Line 92: return iopl(3);
*BSD and Darwin use other includes. […]
Ack
https://review.coreboot.org/c/flashrom/+/61275/comment/e4488cdf_f205a07e PS3, Line 115: NULL
This can be done in a following ccommit.
Ack
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61275/comment/16d943f6_122c74eb PS4, Line 124: msg_perr("Make sure you are root.\n"); If we change this already... There were some reports lately that the message is not helpful on locked-down Linux. How about adding something that there may be more to it, e.g.
Make sure you are root. If you are root, your kernel may still prevent access based on security policies.
https://review.coreboot.org/c/flashrom/+/61275/comment/cdef32d1_91e4a6f0 PS4, Line 126: "reboot, or reboot into single user mode.\n"); would be nice to keep the alignment, i.e. indent with another space
https://review.coreboot.org/c/flashrom/+/61275/comment/dc858681_c466f3e3 PS4, Line 128: "that your kernel configuration has the option INSECURE enabled.\n"); would be nice to keep the alignment, i.e. indent with another space