Attention is currently required from: Thomas Heijligen, Angel Pons.
Patch set 4:Code-Review +2
5 comments:
File hwaccess_x86_io.c:
Patch Set #3, Line 92: return iopl(3);
*BSD and Darwin use other includes. […]
Ack
This can be done in a following ccommit.
Ack
File hwaccess_x86_io.c:
Patch Set #4, Line 124: msg_perr("Make sure you are root.\n");
If we change this already... There were some reports lately that the message
is not helpful on locked-down Linux. How about adding something that there may
be more to it, e.g.
Make sure you are root. If you are root, your kernel may still prevent access based on security policies.
Patch Set #4, Line 126: "reboot, or reboot into single user mode.\n");
would be nice to keep the alignment, i.e. indent with another space
Patch Set #4, Line 128: "that your kernel configuration has the option INSECURE enabled.\n");
would be nice to keep the alignment, i.e. indent with another space
To view, visit change 61275. To unsubscribe, or for help writing mail filters, visit settings.