Attention is currently required from: Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160 )
Change subject: ni845x_spi: refactor singleton states into reentrant pattern ......................................................................
Patch Set 3:
(6 comments)
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/72160/comment/43659971_c889841e PS2, Line 228: uInt32 device_handle
I thought the purpose of the first patch in the chain CB:72154 is to do this type of work: adding ar […]
You're absolutely right, thanks! Moved it to CB:72154
https://review.coreboot.org/c/flashrom/+/72160/comment/b84ab0c1_9b0c820c PS2, Line 395: data
These are actually arguments, not global data
Done
https://review.coreboot.org/c/flashrom/+/72160/comment/2124bbc2_2edcd648 PS2, Line 575: uInt32 device_handle
`device_handle` declared as `Int32` in the `ni845x_spi_data` struct
It's the typo. I redeclared `device_handle` as `uInt32` in the struct.
https://review.coreboot.org/c/flashrom/+/72160/comment/0accd34f_383409c4 PS2, Line 640:
You won't need previous patch CB:72159 if you do: […]
Good catch! Done
https://review.coreboot.org/c/flashrom/+/72160/comment/c08a74ff_30dc0397 PS2, Line 661: ;
drop extra semicolon
Done
https://review.coreboot.org/c/flashrom/+/72160/comment/240ac2dc_a868ea82 PS2, Line 663: NULL
and now you need to pass `data` here, now you have data!
Done