Attention is currently required from: Anastasia Klimchuk.

View Change

6 comments:

• File ni845x_spi.c:

  • Patch Set #2, Line 228: uInt32 device_handle

    I thought the purpose of the first patch in the chain CB:72154 is to do this type of work: adding ar […]

    You're absolutely right, thanks! Moved it to CB:72154

  • Patch Set #2, Line 395: data

    These are actually arguments, not global data

    Done

  • Patch Set #2, Line 575: uInt32 device_handle

    `device_handle` declared as `Int32` in the `ni845x_spi_data` struct

    It's the typo. I redeclared `device_handle` as `uInt32` in the struct.

  • Patch Set #2, Line 640:

    You won't need previous patch CB:72159 if you do: […]

    Good catch! Done

  • Patch Set #2, Line 661: ;

    drop extra semicolon

    Done

  • Patch Set #2, Line 663: NULL

    and now you need to pass `data` here, now you have data!

    Done

To view, visit change 72160. To unsubscribe, or for help writing mail filters, visit settings.