HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39973 )
Change subject: libflashrom.c: Use correct type for sizeof ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/39973/3/libflashrom.c File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/39973/3/libflashrom.c@191 PS3, Line 191: [Not linked to current change]
gcc-10 fails to compile here :
=1' -D'HAVE_UTSNAME=1' -D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="v1.2-34-g021d179"' -o libflashrom.o -c libflashrom.c libflashrom.c: In function 'flashrom_supported_boards': libflashrom.c:191:32: error: implicit conversion from 'const enum test_state' to 'enum flashrom_test_state' [-Werror=enum-conversion] 191 | supported_boards[i].working = binfo[i].working; | ^ libflashrom.c: In function 'flashrom_supported_chipsets': libflashrom.c:229:33: error: implicit conversion from 'const enum test_state' to 'enum flashrom_test_state' [-Werror=enum-conversion] 229 | supported_chipsets[i].status = chipset[i].status; | ^ cc1: all warnings being treated as errors make: *** [Makefile:1194: libflashrom.o] Error 1