Patch set 3:Code-Review +1

View Change

1 comment:

• File libflashrom.c:

  • Patch Set #3, Line 191:

    [Not linked to current change]

    gcc-10 fails to compile here :

    =1' -D'HAVE_UTSNAME=1' -D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="v1.2-34-g021d179"' -o libflashrom.o -c libflashrom.c
    libflashrom.c: In function 'flashrom_supported_boards':
    libflashrom.c:191:32: error: implicit conversion from 'const enum test_state' to 'enum flashrom_test_state' [-Werror=enum-conversion]
      191 |    supported_boards[i].working = binfo[i].working;
          |                                ^
    libflashrom.c: In function 'flashrom_supported_chipsets':
    libflashrom.c:229:33: error: implicit conversion from 'const enum test_state' to 'enum flashrom_test_state' [-Werror=enum-conversion]
      229 |    supported_chipsets[i].status = chipset[i].status;
          |                                 ^
    cc1: all warnings being treated as errors
    make: *** [Makefile:1194: libflashrom.o] Error 1

To view, visit change 39973. To unsubscribe, or for help writing mail filters, visit settings.