Attention is currently required from: Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c ......................................................................
Patch Set 13:
(2 comments)
File tests/io_mock.h:
https://review.coreboot.org/c/flashrom/+/51487/comment/02bb9f7c_8a1c3db6 PS13, Line 37: unsigned char I took these types from a Linux manual page, is there something wrong with them? I think we should stay as close as possible to real implementations.
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/e4831c0c_fff9d64a PS13, Line 26: static struct io_mock *current_io = NULL; This could just be `const`, I guess, as there is no intention to change the struct contents? and also to fix the warning.