Attention is currently required from: Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• File tests/io_mock.h:

  • Patch Set #13, Line 37: unsigned char

    I took these types from a Linux manual page, is there something
    wrong with them? I think we should stay as close as possible to
    real implementations.

• File tests/tests.c:

  • Patch Set #13, Line 26: static struct io_mock *current_io = NULL;

    This could just be `const`, I guess, as there is no intention
    to change the struct contents? and also to fix the warning.

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.