Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Nikolai Artemiev, Thomas Heijligen.
Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77999?usp=email )
Change subject: raiden: Support target index with generic REQ_ENABLE ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/77999/comment/1536cdca_86be7fba : PS2, Line 42: target=1
Since these are new values for `target` param, please document it on the manpage, here: […]
Done
https://review.coreboot.org/c/flashrom/+/77999/comment/1cc81745_67b2379c : PS2, Line 45: CL
Just noticed: you need to say "this patch" […]
Done
https://review.coreboot.org/c/flashrom/+/77999/comment/97759e44_e57e1e0d : PS2, Line 45: archieves
achieves (typo)
Done
https://review.coreboot.org/c/flashrom/+/77999/comment/dca9dc69_122661b9 : PS2, Line 48: run flashrom with HyperDebug
Could you please list the exact commands that you ran? […]
Done
Patchset:
PS2:
Also, maybe you can add a test for target=1 and 2? […]
I do not see any mention of existing values `target=AP` or `target=EC` in `raiden_debug_spi.c`, I think I will need more help on how to create a test for this.
How do I even run the existing test of the Raiden SPI protocol?
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/77999/comment/ff2cc291_f4cdb339 : PS2, Line 1596: request_enable & 0xFF
If this is a no-op, and given your idea to change the signature of `get_target` , maybe this is not […]
Acknowledged
https://review.coreboot.org/c/flashrom/+/77999/comment/58b39cce_12478b9d : PS2, Line 1596: request_enable & 0xFF, : (request_enable >> 8) & 0xFF,
Jes, thank you for detailed explanation, I understand much better now! […]
The documentation at the start of the file actually mentions only the bulk data on the USB endpoint, not the initial control transfer extended by this patchset. So all if it still applies.