Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Nikolai Artemiev, Thomas Heijligen.

7 comments:

Commit Message:
- Patch Set #2, Line 42: target=1
  Since these are new values for `target` param, please document it on the manpage, here: […]
  Done
- Patch Set #2, Line 45: CL
  Just noticed: you need to say "this patch" […]
  Done
- Patch Set #2, Line 45: archieves
  achieves (typo)
  Done
- Patch Set #2, Line 48: run flashrom with HyperDebug
  Could you please list the exact commands that you ran? […]
  Done
Patchset:
- Patch Set #2:
  Also, maybe you can add a test for target=1 and 2? […]
  I do not see any mention of existing values `target=AP` or `target=EC` in `raiden_debug_spi.c`, I think I will need more help on how to create a test for this.
  How do I even run the existing test of the Raiden SPI protocol?
File raiden_debug_spi.c:
- Patch Set #2, Line 1596: request_enable & 0xFF
  If this is a no-op, and given your idea to change the signature of `get_target` , maybe this is not […]
  Acknowledged
- Patch Set #2, Line 1596:
```
request_enable & 0xFF,
				(request_enable >> 8) & 0xFF,
```
  Jes, thank you for detailed explanation, I understand much better now! […]
  The documentation at the start of the file actually mentions only the bulk data on the USB endpoint, not the initial control transfer extended by this patchset. So all if it still applies.

To view, visit change 77999. To unsubscribe, or for help writing mail filters, visit settings.