Attention is currently required from: Martin Roth, Paul Menzel, Angel Pons, Anastasia Klimchuk. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 )
Change subject: pony_spi.c: Fix memory leak in function pony_init_spi ......................................................................
Patch Set 6:
(8 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62724/comment/6504a275_85809e3e PS1, Line 7: Fixed
Imperative mood: Fix
Done
https://review.coreboot.org/c/flashrom/+/62724/comment/f927cd1e_6a48bd61 PS1, Line 9: Memory leaked was caused as data variable wasn't deallocated in some error cases where : the function returned without deallocatiing it.
Please wrap commit message lines at 72 characters, c.f. https://flashrom. […]
Done
https://review.coreboot.org/c/flashrom/+/62724/comment/58f18aec_1e0f7288 PS1, Line 11:
You can add information on how you tested this patch. […]
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/62724/comment/848c65d1_0684d05f PS3, Line 11: ii
nit: just one `i`
Done
File pony_spi.c:
https://review.coreboot.org/c/flashrom/+/62724/comment/16fc36ea_e5e1e26d PS1, Line 164: free(data);
We use tabs for indentation, and a tab is 8 characters wide. Please refer to https://flashrom. […]
Done
https://review.coreboot.org/c/flashrom/+/62724/comment/e63a67d6_9e1799e4 PS1, Line 182: free(data);
This isn't needed because the shutdown function has been registered, which will run `free(data)` alr […]
Done
https://review.coreboot.org/c/flashrom/+/62724/comment/176a6f26_043eec0b PS1, Line 248: free(data);
This isn't needed either, see my comment on line 182.
Done
https://review.coreboot.org/c/flashrom/+/62724/comment/65a2ac51_409a9c1b PS1, Line 255: free(data);
This won't work. […]
Done