Attention is currently required from: Martin Roth, Paul Menzel, Angel Pons, Anastasia Klimchuk.
8 comments:
Commit Message:
Patch Set #1, Line 7: Fixed
Imperative mood: Fix
Done
Memory leaked was caused as data variable wasn't deallocated in some error cases where
the function returned without deallocatiing it.
Please wrap commit message lines at 72 characters, c.f. https://flashrom. […]
Done
You can add information on how you tested this patch. […]
Done
Commit Message:
nit: just one `i`
Done
File pony_spi.c:
Patch Set #1, Line 164: free(data);
We use tabs for indentation, and a tab is 8 characters wide. Please refer to https://flashrom. […]
Done
Patch Set #1, Line 182: free(data);
This isn't needed because the shutdown function has been registered, which will run `free(data)` alr […]
Done
Patch Set #1, Line 248: free(data);
This isn't needed either, see my comment on line 182.
Done
Patch Set #1, Line 255: free(data);
This won't work. […]
Done
To view, visit change 62724. To unsubscribe, or for help writing mail filters, visit settings.