Jonathan Liu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35808 )
Change subject: Fix compilation if CONFIG_INTERNAL=no ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/flashrom/+/35808/1/libflashrom.c File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/35808/1/libflashrom.c@171 PS1, Line 171: struct flashrom_board_info *flashrom_supported_boards(void)
I think this function as a whole is specific to the internal programmer
Ack
https://review.coreboot.org/c/flashrom/+/35808/1/libflashrom.c@199 PS1, Line 199:
Looks like the memory behind `supported_boards` is left uninitialized on […]
Ack
https://review.coreboot.org/c/flashrom/+/35808/1/libflashrom.c@207 PS1, Line 207: struct flashrom_chipset_info *flashrom_supported_chipsets(void)
Same for this one
Ack
https://review.coreboot.org/c/flashrom/+/35808/1/physmap.c File physmap.c:
https://review.coreboot.org/c/flashrom/+/35808/1/physmap.c@366 PS1, Line 366: /* MSR abstraction implementations for Linux, OpenBSD, FreeBSD/Dragonfly, OSX, libpayload : * and a non-working default implementation on the bottom. See also hwaccess.h for some (re)declarations. */
I doubt that anything from here onwards is needed for anything but the internal programmer.
Ack
https://review.coreboot.org/c/flashrom/+/35808/1/physmap.c@433 PS1, Line 433: #if CONFIG_INTERNAL == 1
Why does it need a guard? I don't see anything non-standard
The prototype for setup_cpu_msr and cleanup_cpu_msr in programmer.h is conditional on CONFIG_INTERNAL == 1