View Change

5 comments:

• File libflashrom.c:

  • Patch Set #1, Line 171: struct flashrom_board_info *flashrom_supported_boards(void)

    I think this function as a whole is specific to the internal programmer

    Ack

  • Patch Set #1, Line 199:

    Looks like the memory behind `supported_boards` is left uninitialized on […]

    Ack

  • Patch Set #1, Line 207: struct flashrom_chipset_info *flashrom_supported_chipsets(void)

    Same for this one

    Ack

• File physmap.c:

  • Patch Set #1, Line 366:

    /* MSR abstraction implementations for Linux, OpenBSD, FreeBSD/Dragonfly, OSX, libpayload
     * and a non-working default implementation on the bottom. See also hwaccess.h for some (re)declarations. */
    

    I doubt that anything from here onwards is needed for anything but the internal programmer.

    Ack

  • Patch Set #1, Line 433: #if CONFIG_INTERNAL == 1

    Why does it need a guard? I don't see anything non-standard

    The prototype for setup_cpu_msr and cleanup_cpu_msr in programmer.h is conditional on CONFIG_INTERNAL == 1

To view, visit change 35808. To unsubscribe, or for help writing mail filters, visit settings.