Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37240 )
Change subject: cbtable.c: don't assume high addresses can fully map 1 MiB ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/flashrom/+/37240/1/cbtable.c File cbtable.c:
https://review.coreboot.org/c/flashrom/+/37240/1/cbtable.c@231 PS1, Line 231: addr
Can't we just use `offset`? It seems to be the better name. I was confused […]
Done; This was just taken verbatim from the original patch. Thanks for the suggestions!
https://review.coreboot.org/c/flashrom/+/37240/1/cbtable.c@255 PS1, Line 255: return NULL;
Why not continue with the original base? […]
I was not sure of an adequate test to check that is ok or the best way to structure things to fallback without too much change. So I just left it as is atm.
https://review.coreboot.org/c/flashrom/+/37240/1/cbtable.c@259 PS1, Line 259: head = (struct lb_header *)(((char *)base) + addr);
Move this inside the `if` so it becomes clear that it's for the […]
Done
https://review.coreboot.org/c/flashrom/+/37240/1/cbtable.c@260 PS1, Line 260: recs =
This line break looks really odd.
Done