4 comments:

File cbtable.c:
- Patch Set #1, Line 231: addr
  Can't we just use `offset`? It seems to be the better name. I was confused […]
  Done; This was just taken verbatim from the original patch. Thanks for the suggestions!
- Patch Set #1, Line 255: return NULL;
  Why not continue with the original base? […]
  I was not sure of an adequate test to check that is ok or the best way to structure things to fallback without too much change. So I just left it as is atm.
- Patch Set #1, Line 259: head = (struct lb_header *)(((char *)base) + addr);
  Move this inside the `if` so it becomes clear that it's for the […]
  Done
- Patch Set #1, Line 260: recs =
  This line break looks really odd.
  Done

To view, visit change 37240. To unsubscribe, or for help writing mail filters, visit settings.