Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41608 )
Change subject: raiden_debug_spi.c: Adds context states and helper functions ......................................................................
Patch Set 13:
(5 comments)
Uh, this is quite large to review in one go. Could you please split this into steps?
The commit message has two rather long paragraphs. I'd put them (and the corresponding changes) in separate commits
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG@7 PS13, Line 7: Adds Add
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG@9 PS13, Line 9: Adds Add
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG@14 PS13, Line 14: Adds Add
https://review.coreboot.org/c/flashrom/+/41608/13/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41608/13/raiden_debug_spi.c@149 PS13, Line 149: using tabs here instead of spaces would make it easier to keep the alignment. it's hard to spot a single-space difference unless the lines are consecutive
https://review.coreboot.org/c/flashrom/+/41608/13/raiden_debug_spi.c@158 PS13, Line 158: We too much data. Missing a verb?