Uh, this is quite large to review in one go. Could you please split this into steps?
The commit message has two rather long paragraphs. I'd put them (and the corresponding changes) in separate commits
5 comments:
Add
Add
Add
using tabs here instead of spaces would make it easier to keep the alignment. it's hard to spot a single-space difference unless the lines are consecutive
Patch Set #13, Line 158: We too much data.
Missing a verb?
To view, visit change 41608. To unsubscribe, or for help writing mail filters, visit settings.