Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66343 )
Change subject: cli_classic: refactor arguments parsing into separate func ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66343/comment/7d0da03a_beacc1a3 PS7, Line 21: TEST=builds I would be good to test the patch. Dummyflasher is perfectly fine for the purpose. But unit tests are all running libflashrom, so this layer of cli code is actually not run by tests. Not necessarily all the paths (and you can't do all the paths with dummyflasher anyway), but even some of the paths, the basic ones would be really good!
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/66343/comment/b2310053_af211dc9 PS7, Line 51: unsigned int wp_start, wp_len; I think, grouping by purpose would be better than grouping by data type. For example, wp has a bunch of options, they would be good to keep together (with new line before and after group). Another group can be about operations that flashrom performs (options between read_it and show_progress). Then maybe layout group. Stuff that does not belong anywhere can be at the end in "everything else" group.
My main intention is to make it easier to find the option in the long list.