Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov.

Patch set 7:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #7, Line 21: TEST=builds

    I would be good to test the patch. Dummyflasher is perfectly fine for the purpose. But unit tests are all running libflashrom, so this layer of cli code is actually not run by tests.
    Not necessarily all the paths (and you can't do all the paths with dummyflasher anyway), but even some of the paths, the basic ones would be really good!

• File cli_classic.c:

  • Patch Set #7, Line 51: unsigned int wp_start, wp_len;

    I think, grouping by purpose would be better than grouping by data type.
    For example, wp has a bunch of options, they would be good to keep together (with new line before and after group).
    Another group can be about operations that flashrom performs (options between read_it and show_progress).
    Then maybe layout group.
    Stuff that does not belong anywhere can be at the end in "everything else" group.

    My main intention is to make it easier to find the option in the long list.

To view, visit change 66343. To unsubscribe, or for help writing mail filters, visit settings.