Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47090 )
Change subject: chipset_enable.c: Add Intel pch6 did=0x1e4{1,2,3} support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/47090/2/chipset_enable.c File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/47090/2/chipset_enable.c@1841 PS2, Line 1841: enable_flash_pch6 enable_flash_pch7
https://review.coreboot.org/c/flashrom/+/47090/2/chipset_enable.c@1841 PS2, Line 1841: Desktop Full It would be nice to use "Desktop Sample", "Mobile Sample" and "SFF Sample" to match coreboot: https://github.com/coreboot/coreboot/blob/master/src/southbridge/intel/bd82x...