Attention is currently required from: Edward O'Callaghan.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69047 )
Change subject: chipdrivers: Rename s/erase_sector_stm50/stm50_sector_erase ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/69047/comment/da9b7312_3978fb7b PS3, Line 377: STM50_SECTOR_ERASE I am wondering if we should go the other way, renaming this to ERASE_SECTOR_STM50, since this would align with the other names above.
Same for the follow-up patches, e.g. erase_opaque. Related function names start with the operation type as prefix, as for example write_opaque or read_opaque.