Attention is currently required from: Edward O'Callaghan.

Patch set 3:Code-Review +1

View Change

1 comment:

• File flashrom.c:

  • Patch Set #3, Line 377: STM50_SECTOR_ERASE

    I am wondering if we should go the other way, renaming this to ERASE_SECTOR_STM50, since this would align with the other names above.

    Same for the follow-up patches, e.g. erase_opaque. Related function names start with the operation type as prefix, as for example write_opaque or read_opaque.

To view, visit change 69047. To unsubscribe, or for help writing mail filters, visit settings.