- flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU128D
by Anastasia Klimchuk (Code Review) 11 Jul '24

11 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83239?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU128D ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/UUDQ… I am leaving the comment unresolved, so that not to accidentally submit before the tag. -- To view, visit https://review.coreboot.org/c/flashrom/+/83239?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If5fe2b3c1973599aecb80adcb5f0fe2dec0da0e5 Gerrit-Change-Number: 83239 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 11 Jul 2024 07:35:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH128D
by Anastasia Klimchuk (Code Review) 11 Jul '24

11 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83238?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH128D ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/UUDQ… I am leaving the comment unresolved, so that not to accidentally submit before the tag. -- To view, visit https://review.coreboot.org/c/flashrom/+/83238?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia4577fba545f9f8eea15eef7060bd5955a8457ca Gerrit-Change-Number: 83238 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 11 Jul 2024 07:35:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: ch347_spi: Add spi clock frequency selection
by Nicholas Chin (Code Review) 11 Jul '24

11 Jul '24

Attention is currently required from: Anastasia Klimchuk, ZhiYuanNJ. Nicholas Chin has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email ) Change subject: ch347_spi: Add spi clock frequency selection ...................................................................... Patch Set 10: (1 comment) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82776/comment/b6b6f8f8_292315d3?us… : PS7, Line 365: 30MHz > If it is a Windows system, you can read it through the hardware ID of the device manager hardware de […] Thanks. The region of mine is 1.40. I did some experimentation and found that if I set the SPI mode to 3 (polarity=1 and phase=1) in `ch347_spi_config()` I could get that Winbond chip working at 30 MHz and even 60 MHz. However, the Eon chip refused to work in anything but mode 0, and not at 30 MHz. -- To view, visit https://review.coreboot.org/c/flashrom/+/82776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If2be48929db540a6598ac0b60b37e64597156db7 Gerrit-Change-Number: 82776 Gerrit-PatchSet: 10 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: ZhiYuanNJ Gerrit-Comment-Date: Thu, 11 Jul 2024 03:13:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: ZhiYuanNJ Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in flashrom[main]: VERSION: Update version to 1.4.0-rc2
by Anastasia Klimchuk (Code Review) 11 Jul '24

11 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83418?usp=email ) Change subject: VERSION: Update version to 1.4.0-rc2 ...................................................................... VERSION: Update version to 1.4.0-rc2 Change-Id: I725dbbbd43b3b51a5034f5a940ab7a72530bac80 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83418 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M VERSION 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/VERSION b/VERSION index 3280933..ce59f0b 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.4.0-rc1 +1.4.0-rc2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83418?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I725dbbbd43b3b51a5034f5a940ab7a72530bac80 Gerrit-Change-Number: 83418 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: VERSION: Update version to 1.4.0-rc2
by Peter Marheine (Code Review) 11 Jul '24

11 Jul '24

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83418?usp=email ) Change subject: VERSION: Update version to 1.4.0-rc2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83418?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I725dbbbd43b3b51a5034f5a940ab7a72530bac80 Gerrit-Change-Number: 83418 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 11 Jul 2024 01:38:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: VERSION: Update version to 1.4.0-rc2
by Anastasia Klimchuk (Code Review) 11 Jul '24

11 Jul '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83418?usp=email ) Change subject: VERSION: Update version to 1.4.0-rc2 ...................................................................... VERSION: Update version to 1.4.0-rc2 Change-Id: I725dbbbd43b3b51a5034f5a940ab7a72530bac80 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M VERSION 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/83418/1 diff --git a/VERSION b/VERSION index 3280933..ce59f0b 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.4.0-rc1 +1.4.0-rc2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83418?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I725dbbbd43b3b51a5034f5a940ab7a72530bac80 Gerrit-Change-Number: 83418 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: how_to_add_new_chip: Add a section for feature bits and WRSR handling
by Anastasia Klimchuk (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change by Hsuan-ting Chen. ( https://review.coreboot.org/c/flashrom/+/82908?usp=email ) Change subject: how_to_add_new_chip: Add a section for feature bits and WRSR handling ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/UUDQ… I am leaving the comment unresolved, so that not to accidentally submit before the tag. -- To view, visit https://review.coreboot.org/c/flashrom/+/82908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I34c20933a375380c8702f79ac637595cd3466000 Gerrit-Change-Number: 82908 Gerrit-PatchSet: 3 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 10 Jul 2024 06:27:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in flashrom[main]: doc: Release notes for version 1.4.0
by Anastasia Klimchuk (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Alexander Goncharov, Nikolai Artemiev, Peter Marheine, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83359?usp=email ) Change subject: doc: Release notes for version 1.4.0 ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > It might be better to submit this before tagging, so checking out the tagged revision will include t […] This makes sense, I agree. Also chances are that someone who checks out repo by release tag, doesn't need the tarball. -- To view, visit https://review.coreboot.org/c/flashrom/+/83359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Gerrit-Change-Number: 83359 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 10 Jul 2024 06:25:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: ch347_spi: Add spi clock frequency selection
by ZhiYuanNJ (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Anastasia Klimchuk, Nicholas Chin. ZhiYuanNJ has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email ) Change subject: ch347_spi: Add spi clock frequency selection ...................................................................... Patch Set 10: (1 comment) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82776/comment/1031cf2a_2b91c089?us… : PS7, Line 365: 30MHz > I'd have to do a bit of digging as I don't know of a quick way to find this. […] If it is a Windows system, you can read it through the hardware ID of the device manager hardware details, for example: "USB\VID_1A86&PID_55DE&REV_0101&MI_04 ", then the hardware version is v1.1. If it is Linux, you may need to write a small program to get bcdUSB. like: ```c #include <stdio.h> #include <stdlib.h> #include <usb.h> int main() { struct usb_bus *bus; struct usb_device *dev; usb_init(); usb_find_busses(); usb_find_devices(); for(bus = usb_get_busses(); bus; bus = bus->next) { for(dev = bus->devices; dev; dev = dev->next) { printf("Device: %04x:%04x, bcdUSB: %04x\n", dev->descriptor.idVendor, dev->descriptor.idProduct, dev->descriptor.bcdUSB); } } return 0; } ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/82776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If2be48929db540a6598ac0b60b37e64597156db7 Gerrit-Change-Number: 82776 Gerrit-PatchSet: 10 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 10 Jul 2024 03:27:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Comment-In-Reply-To: ZhiYuanNJ

1 0

[L] Change in flashrom[main]: doc: Release notes for version 1.4.0
by Peter Marheine (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83359?usp=email ) Change subject: doc: Release notes for version 1.4.0 ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > Submit after tag v1.4. […] It might be better to submit this before tagging, so checking out the tagged revision will include the release notes? The download link and fingerprint would need to be filled in later, but I think that's okay. -- To view, visit https://review.coreboot.org/c/flashrom/+/83359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Gerrit-Change-Number: 83359 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 10 Jul 2024 01:34:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit