- flashrom-gerrit - mail.coreboot.org

[L] Change in flashrom[main]: doc: Release notes for version 1.4.0
by Peter Marheine (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83359?usp=email ) Change subject: doc: Release notes for version 1.4.0 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Gerrit-Change-Number: 83359 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 10 Jul 2024 01:32:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in flashrom[main]: doc: Release notes for version 1.4.0
by Anastasia Klimchuk (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Alexander Goncharov, Nikolai Artemiev, Peter Marheine, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83359?usp=email ) Change subject: doc: Release notes for version 1.4.0 ...................................................................... Patch Set 4: (1 comment) File doc/release_notes/v_1_4.rst: https://review.coreboot.org/c/flashrom/+/83359/comment/b566e359_ec2c5803?us… : PS3, Line 55: used > Typo (my fault?): use […] Thanks, done! I also added one more line in the last section, misc. Somehow I missed it earlier: renaming branch from master to main. Not a user-facing feature, but for developers this has information. Especially if someone happens to not updated the repository from a year ago. -- To view, visit https://review.coreboot.org/c/flashrom/+/83359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Gerrit-Change-Number: 83359 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 09 Jul 2024 09:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: doc: Release notes for version 1.4.0
by Anastasia Klimchuk (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Nikolai Artemiev, Peter Marheine, Stefan Reinauer. Hello Alexander Goncharov, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83359?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by Peter Marheine, Verified+1 by build bot (Jenkins) Change subject: doc: Release notes for version 1.4.0 ...................................................................... doc: Release notes for version 1.4.0 Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/release_notes/index.rst A doc/release_notes/v_1_4.rst 2 files changed, 329 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/83359/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/83359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Gerrit-Change-Number: 83359 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>

1 0

[XS] Change in flashrom[main]: tests/selfcheck.c: Include the missing header lifecycle.h
by Hsuan-ting Chen (Code Review) 09 Jul '24

09 Jul '24

Hsuan-ting Chen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/83219?usp=email ) Change subject: tests/selfcheck.c: Include the missing header lifecycle.h ...................................................................... Abandoned Wrong fix. The correct fix is to cherry-pick cCB:69621 to CHROMIUM -- To view, visit https://review.coreboot.org/c/flashrom/+/83219?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ifc07ac66320712fdbf31504b9a980354c1883f40 Gerrit-Change-Number: 83219 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: tests/selfcheck.c: Include the missing header lifecycle.h
by Hsuan-ting Chen (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Hsuan Ting Chen. Hsuan-ting Chen has posted comments on this change by Hsuan-ting Chen. ( https://review.coreboot.org/c/flashrom/+/83219?usp=email ) Change subject: tests/selfcheck.c: Include the missing header lifecycle.h ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks for the hinting! Looks like that the root cause is CHROMIUM missed https://review.coreboot.org/c/flashrom/+/69621 I've prepared https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/… Hence I'll abandon this. -- To view, visit https://review.coreboot.org/c/flashrom/+/83219?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ifc07ac66320712fdbf31504b9a980354c1883f40 Gerrit-Change-Number: 83219 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Jul 2024 07:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: how_to_add_new_chip: Add a section for feature bits and WRSR handling
by Hsuan-ting Chen (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Thomas Heijligen. Hsuan-ting Chen has posted comments on this change by Hsuan-ting Chen. ( https://review.coreboot.org/c/flashrom/+/82908?usp=email ) Change subject: how_to_add_new_chip: Add a section for feature bits and WRSR handling ...................................................................... Patch Set 3: (1 comment) File doc/contrib_howtos/how_to_add_new_chip.rst: https://review.coreboot.org/c/flashrom/+/82908/comment/f3b76683_a1c7612b?us… : PS2, Line 108: Some of the feature bits have more detailed docs, see below. > Add new line (empty line) before #108 Done -- To view, visit https://review.coreboot.org/c/flashrom/+/82908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I34c20933a375380c8702f79ac637595cd3466000 Gerrit-Change-Number: 82908 Gerrit-PatchSet: 3 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Jul 2024 03:02:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: how_to_add_new_chip: Add a section for feature bits and WRSR handling
by Hsuan-ting Chen (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Thomas Heijligen. Hello Anastasia Klimchuk, Hsuan Ting Chen, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/82908?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: how_to_add_new_chip: Add a section for feature bits and WRSR handling ...................................................................... how_to_add_new_chip: Add a section for feature bits and WRSR handling Feature bits are too complicated to understand if we only read the codes/datasheets. Add a new section in how_to_add_new_chip to add more details about each feature bits. Add the detailed explanation for WRSR handling first. If this new section looks good, I'll try to add some more sections in further commits. BUG=b:345154585 TEST=meson compile -C builddir and view the doc. Change-Id: I34c20933a375380c8702f79ac637595cd3466000 Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M doc/contrib_howtos/how_to_add_new_chip.rst 1 file changed, 26 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/82908/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/82908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I34c20933a375380c8702f79ac637595cd3466000 Gerrit-Change-Number: 82908 Gerrit-PatchSet: 3 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>

1 0

[L] Change in flashrom[main]: doc: Release notes for version 1.4.0
by Peter Marheine (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83359?usp=email ) Change subject: doc: Release notes for version 1.4.0 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File doc/release_notes/v_1_4.rst: https://review.coreboot.org/c/flashrom/+/83359/comment/3f392de9_10b54d8e?us… : PS3, Line 55: used Typo (my fault?): use ```suggestion parallel flashes (where it remains in use). ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/83359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Gerrit-Change-Number: 83359 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 09 Jul 2024 01:07:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in flashrom[main]: doc: Release notes for version 1.4.0
by Anastasia Klimchuk (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Alexander Goncharov, Nikolai Artemiev, Peter Marheine, Stefan Reinauer. Hello Alexander Goncharov, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83359?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: Release notes for version 1.4.0 ...................................................................... doc: Release notes for version 1.4.0 Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/release_notes/index.rst A doc/release_notes/v_1_4.rst 2 files changed, 328 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/83359/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/83359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Gerrit-Change-Number: 83359 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>

1 0

[L] Change in flashrom[main]: doc: Release notes for version 1.4.0
by Anastasia Klimchuk (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Alexander Goncharov, Nikolai Artemiev, Peter Marheine, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83359?usp=email ) Change subject: doc: Release notes for version 1.4.0 ...................................................................... Patch Set 2: (7 comments) Patchset: PS2: Peter thank you so much, your suggestions made this doc so much better! File doc/release_notes/v_1_4.rst: https://review.coreboot.org/c/flashrom/+/83359/comment/5e00a6fc_fc30bc69?us… : PS1, Line 5: Release notes for flashrom version 1.4.0. > It seems nice to include a little intro paragraph here, acknowledging contributors and providing a l […] This is a great idea! How could I forgot :( I added a paragraph, with few changes: 400+ and 70+ instead of exact numbers, to count all possible fixed in rc. Also I am not entirely sure how to count months: 1.3 got out in Feb 2023, but it was made based on a branch which diverged in early Nov 2022. And during those 3.5 months active development continued, but except of few small fixed, not included in 1.3. There is no easy way to say this in short, so I settled on "in the 18 months since version 1.3.0 was branched" which seems close enough to reality. We won't have this problem again :) https://review.coreboot.org/c/flashrom/+/83359/comment/99353e55_8aad7e3a?us… : PS1, Line 10: Fix AMD programmer (sb600spi.c) for Promontory and chips >16MB size > I see this is the title of the issue, but starting a known issue with "Fix" seems confusing. […] This is great summary! https://review.coreboot.org/c/flashrom/+/83359/comment/faa02cde_16857b71?us… : PS1, Line 29: : * Calibration loop is not used anymore, except for DOS : * Removed unconditional 1 second delay for SPI chips : * Lower the sleep vs delay threshold to 0.1 seconds : * Tree-wide refactorings around programmer_delay and internal_delay > This is technically all true, but I think it should be rearranged to highlight the parts that users […] Done https://review.coreboot.org/c/flashrom/+/83359/comment/338bfa18_ff346891?us… : PS1, Line 38: Note: the migration process is half way. > Should this mention that the wiki is deprecated and will go away eventually, but information from th […] Yes good idea I added this info. https://review.coreboot.org/c/flashrom/+/83359/comment/e3fa4d80_6eab39ce?us… : PS1, Line 46: Our current two build systems, meson and make, are on par : --------------------------------------------------------- : : Both build systems support the same platforms and both are documented (however, unit tests only supported with meson). : : **This is the last release with two build systems. With the next release, make and Makefile will no longer be supported, and we will have one build system: meson.** > As with the delay section, I think this should highlight things that might affect users (or in this […] Done https://review.coreboot.org/c/flashrom/+/83359/comment/fd834aee_88534a40?us… : PS1, Line 292: Download > I think this should be at the top, right after the intro paragraph. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie5597f1c3ae9289e424f54c2d313fef8efbdf1a0 Gerrit-Change-Number: 83359 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 08 Jul 2024 11:03:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit