- flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH256D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83240?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH256D ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83240?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I77481e63eb98ed12935288dc0d6286cb1baf8edb Gerrit-Change-Number: 83240 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:23:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU128D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83239?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU128D ...................................................................... flashchips: Add Support for XMC XM25QU128D Add initial support for the SPI flash chip XM25QU128D (same as XM25QU128C) Datasheet link: https://www.xmcwh.com/uploads/227/XM25QU128C_Ver2.1.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: If5fe2b3c1973599aecb80adcb5f0fe2dec0da0e5 Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83239 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 66a2e00..eaeb390 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22374,7 +22374,7 @@ { .vendor = "XMC", - .name = "XM25QU128C", + .name = "XM25QU128C/XM25QU128D", .bustype = BUS_SPI, .manufacture_id = ST_ID, .model_id = XMC_XM25QU128C, @@ -22383,7 +22383,7 @@ /* supports SFDP */ /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = diff --git a/include/flashchips.h b/include/flashchips.h index c738ce9..cc338c4 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -854,7 +854,7 @@ #define XMC_XM25QU32C 0x5016 #define XMC_XM25QH128A 0x7018 #define XMC_XM25QH128C 0x4018 /* Same as XM25QH128D */ -#define XMC_XM25QU128C 0x4118 +#define XMC_XM25QU128C 0x4118 /* Same as XM25QU128D */ #define XMC_XM25QH256C 0x4019 #define XMC_XM25QU256C 0x4119 #define XMC_XM25RU256C 0x4419 -- To view, visit https://review.coreboot.org/c/flashrom/+/83239?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If5fe2b3c1973599aecb80adcb5f0fe2dec0da0e5 Gerrit-Change-Number: 83239 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU128D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83239?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU128D ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83239?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If5fe2b3c1973599aecb80adcb5f0fe2dec0da0e5 Gerrit-Change-Number: 83239 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:20:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH128D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83238?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH128D ...................................................................... flashchips: Add Support for XMC XM25QH128D Add initial support for the SPI flash chip XM25QH128D (same as XM25QH128C) Datasheet link: https://www.xmcwh.com/uploads/801/XM25QH128C_Ver2.1.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: Ia4577fba545f9f8eea15eef7060bd5955a8457ca Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83238 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index bf74313..66a2e00 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22326,14 +22326,14 @@ { .vendor = "XMC", - .name = "XM25QH128C", + .name = "XM25QH128C/XM25QH128D", .bustype = BUS_SPI, .manufacture_id = ST_ID, .model_id = XMC_XM25QH128C, .total_size = 16384, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | FEATURE_WRSR2, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = diff --git a/include/flashchips.h b/include/flashchips.h index 5040c65..c738ce9 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -853,7 +853,7 @@ #define XMC_XM25QH32C 0x4016 /* Same as XM25QH32D */ #define XMC_XM25QU32C 0x5016 #define XMC_XM25QH128A 0x7018 -#define XMC_XM25QH128C 0x4018 +#define XMC_XM25QH128C 0x4018 /* Same as XM25QH128D */ #define XMC_XM25QU128C 0x4118 #define XMC_XM25QH256C 0x4019 #define XMC_XM25QU256C 0x4119 -- To view, visit https://review.coreboot.org/c/flashrom/+/83238?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia4577fba545f9f8eea15eef7060bd5955a8457ca Gerrit-Change-Number: 83238 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH128D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83238?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH128D ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83238?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia4577fba545f9f8eea15eef7060bd5955a8457ca Gerrit-Change-Number: 83238 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:19:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH64D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83237?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH64D ...................................................................... flashchips: Add Support for XMC XM25QH64D Add initial support for the SPI flash chip XM25QH64D (same as XM25QH64C) Datasheet link: https://www.xmcwh.com/uploads/800/XM25QH64C_Ver1.8.pdf Change-Id: Ia3357cb2c30cbe34dcf0e06fd037064304b4c0c4 Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83237 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index 94886d7..bf74313 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22202,7 +22202,7 @@ { .vendor = "XMC", - .name = "XM25QH64C", + .name = "XM25QH64C/XM25QH64D", .bustype = BUS_SPI, .manufacture_id = ST_ID, .model_id = XMC_XM25QH64C, diff --git a/include/flashchips.h b/include/flashchips.h index 7db60a2..5040c65 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -845,7 +845,7 @@ #define ST_M45PE40 0x4013 #define ST_M45PE80 0x4014 /* Same as XM25QH80B */ #define ST_M45PE16 0x4015 -#define XMC_XM25QH64C 0x4017 +#define XMC_XM25QH64C 0x4017 /* Same as XM25QH64D */ #define XMC_XM25QU64C 0x4117 #define XMC_XM25QU80B 0x5014 #define XMC_XM25QH16C 0x4015 /* Same as XM25QH16D */ -- To view, visit https://review.coreboot.org/c/flashrom/+/83237?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia3357cb2c30cbe34dcf0e06fd037064304b4c0c4 Gerrit-Change-Number: 83237 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH64D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83237?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH64D ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83237?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia3357cb2c30cbe34dcf0e06fd037064304b4c0c4 Gerrit-Change-Number: 83237 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:17:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU32C
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83236?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU32C ...................................................................... flashchips: Add Support for XMC XM25QU32C Add initial support for the SPI flash chip XM25QU32C Datasheet link: https://www.xmcwh.com/uploads/233/XM25QU32C_Ver2.1.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83236 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index b7d378f..94886d7 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22164,6 +22164,44 @@ { .vendor = "XMC", + .name = "XM25QU32C", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QU32C, + .total_size = 4096, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 128} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1650, 1950}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 0f96d6a..7db60a2 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -851,6 +851,7 @@ #define XMC_XM25QH16C 0x4015 /* Same as XM25QH16D */ #define XMC_XM25QU16C 0x5015 #define XMC_XM25QH32C 0x4016 /* Same as XM25QH32D */ +#define XMC_XM25QU32C 0x5016 #define XMC_XM25QH128A 0x7018 #define XMC_XM25QH128C 0x4018 #define XMC_XM25QU128C 0x4118 -- To view, visit https://review.coreboot.org/c/flashrom/+/83236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a Gerrit-Change-Number: 83236 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU32C
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83236?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU32C ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a Gerrit-Change-Number: 83236 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:12:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH32C/XM25QH32D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83235?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH32C/XM25QH32D ...................................................................... flashchips: Add Support for XMC XM25QH32C/XM25QH32D Add initial support for the SPI flash chip XM25QH32C/XM25QH32D Datasheet link: https://www.xmcwh.com/uploads/799/XM25QH32C_Ver2.1.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: Ib201ac28384b8db6539e2a82e6f90462d1393208 Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83235 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index 84a3b5e..b7d378f 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22126,6 +22126,44 @@ { .vendor = "XMC", + .name = "XM25QH32C/XM25QH32D", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QH32C, + .total_size = 4096, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 128} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/include/flashchips.h b/include/flashchips.h index c670e3f..0f96d6a 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -850,6 +850,7 @@ #define XMC_XM25QU80B 0x5014 #define XMC_XM25QH16C 0x4015 /* Same as XM25QH16D */ #define XMC_XM25QU16C 0x5015 +#define XMC_XM25QH32C 0x4016 /* Same as XM25QH32D */ #define XMC_XM25QH128A 0x7018 #define XMC_XM25QH128C 0x4018 #define XMC_XM25QU128C 0x4118 -- To view, visit https://review.coreboot.org/c/flashrom/+/83235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib201ac28384b8db6539e2a82e6f90462d1393208 Gerrit-Change-Number: 83235 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit