Attention is currently required from: Anastasia Klimchuk.
Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84455?usp=email )
Change subject: tests: Add header stdlib.h to allow scan-build to do analysis
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/84455/comment/c585874d_3de6a7e9?us… :
PS1, Line 9: I
i
--
To view, visit https://review.coreboot.org/c/flashrom/+/84455?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I4b79c5f86c074c456533296c309293e4064abe3f
Gerrit-Change-Number: 84455
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sat, 21 Sep 2024 20:11:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Balázs Vinarz has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/23053?usp=email )
Change subject: Fwd: Software info for Willem/EZOflash
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I've started to work on the rebase, most of the not exact code related stuff is done, I'll need to fix the compiler error's now which are mostly changed function names.
--
To view, visit https://review.coreboot.org/c/flashrom/+/23053?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Idc4d98593076c80fd1d6ac4596940d1d7977343c
Gerrit-Change-Number: 23053
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 21 Sep 2024 19:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/flashrom/+/63416?usp=email )
Change subject: [WIP] add me_unlock_tool
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Sergii, do you still have an interest in this patch? (I am looking through old hanging patches). […]
It was declared as abandoned 2 years ago internally, so abandoned this one and CB:56023 can be abandoned too.
--
To view, visit https://review.coreboot.org/c/flashrom/+/63416?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ie8d66f1ee449ce8f2cbdc8c744e9b70428de533d
Gerrit-Change-Number: 63416
Gerrit-PatchSet: 3
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 21 Sep 2024 16:43:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/63416?usp=email )
Change subject: [WIP] add me_unlock_tool
......................................................................
Abandoned
Fn+M combination during power on unlocks ME as well, also this didn't power on the laptop automatically
--
To view, visit https://review.coreboot.org/c/flashrom/+/63416?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ie8d66f1ee449ce8f2cbdc8c744e9b70428de533d
Gerrit-Change-Number: 63416
Gerrit-PatchSet: 3
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Attention is currently required from: Anastasia Klimchuk.
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/flashrom/+/69399?usp=email )
Change subject: spi25_statusreg: make "configuration registers" an alias to SRs
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Sergii, do you still have an interest in this patch? I don't think it has ever been reviewed, but ma […]
The change was requested during review of CB:66211. I don't see much need for it, so if don't find it useful either, this can be abandoned.
--
To view, visit https://review.coreboot.org/c/flashrom/+/69399?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I27e89626037dcb0ed078029efe1e919b1f3e88fe
Gerrit-Change-Number: 69399
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sat, 21 Sep 2024 16:32:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/66718?usp=email )
Change subject: TEST_ERASE_ALGO: A list of test cases (patch not to be merged)
......................................................................
Abandoned
The project done :)
--
To view, visit https://review.coreboot.org/c/flashrom/+/66718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I5e961752b9d24d28fdd3487a1a121391f149928b
Gerrit-Change-Number: 66718
Gerrit-PatchSet: 83
Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Attention is currently required from: Edward O'Callaghan, Hsuan-ting Chen, Sam McNally.
Anastasia Klimchuk has posted comments on this change by Edward O'Callaghan. ( https://review.coreboot.org/c/flashrom/+/49916?usp=email )
Change subject: CHROMIUM: flashrom_tester: Drop nix dependency
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Hsuan-Ting, I came along this old patch, do you have any interest in it? If you are not interested, we can mark it abandoned.
Abandoned is not deleted, and can be restored later at any time.
--
To view, visit https://review.coreboot.org/c/flashrom/+/49916?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: If7d1c7c7b5663a32c0a338866f7f7f9bee604cc0
Gerrit-Change-Number: 49916
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Sat, 21 Sep 2024 13:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No