- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: VERSION: Change name pattern to match tag name from now on
by Anastasia Klimchuk (Code Review) 20 Oct '24

20 Oct '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/84811?usp=email ) Change subject: VERSION: Change name pattern to match tag name from now on ...................................................................... VERSION: Change name pattern to match tag name from now on This patch updated the VERSION file itself, and the document on release process. Change-Id: I2bd2e57e42c29ea5a9d8bc334b86c6fa5c4b46a4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M VERSION M doc/dev_guide/release_process.rst 2 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/84811/1 diff --git a/VERSION b/VERSION index 4a06232..bd033f4 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.5.0-devel +v1.5.0-devel diff --git a/doc/dev_guide/release_process.rst b/doc/dev_guide/release_process.rst index 749779e..2392491 100644 --- a/doc/dev_guide/release_process.rst +++ b/doc/dev_guide/release_process.rst @@ -24,14 +24,13 @@ * Double-check and merge all the patches that are fully ready (see also :ref:`merge-checklist`) -* Update VERSION file to first release candidate. Check the git history of VERSION file for a version name pattern. +* Update VERSION file to first release candidate. The name pattern is: ``v{version_number}-rc{rc_number}``. - * As an example at the time of writing, the version name of the first release candidate was ``1.4.0-rc1``. + * As an example, the version name of the first release candidate can be ``v1.4.0-rc1``. * To update the VERSION file, push a patch to Gerrit, and another maintainer should review and approve. -* After submitting the change to the VERSION file, tag this commit. - You can check `flashrom tags in Gerrit <https://review.coreboot.org/admin/repos/flashrom,tags,25>`_ - for tag name pattern. As an example at the time of writing, the tag name was ``v1.4.0-rc1``. +* After submitting the change to the VERSION file, tag this commit. Tag name should be the same as + version name, for example above ``v1.4.0-rc1``. * Write an announcement on the mailing list. Be very clear about: @@ -74,11 +73,11 @@ * Submit the release notes, and in the same patch restart :doc:`/release_notes/devel` document. This way everyone who is syncing the repository by the release tag will have release notes in the tree. -* Update VERSION file to release version (for example, at the time of writing ``1.4.0``), and submit this +* Update VERSION file to release version, name pattern is: ``v{version_name}`` + (for example, it can be ``v1.4.0``), and submit this. -* Tag the commit which updates the VERSION file. You can check - `flashrom tags in Gerrit <https://review.coreboot.org/admin/repos/flashrom,tags,25>`_ for tag name pattern. - As an example at the time of writing, the tag name was ``v1.4.0``. +* Tag the commit which updates the VERSION file. Tag name should be the same as version name, + for example above ``v1.4.0``. * Create the tarball, sign it, and upload to the server together with the signature. @@ -93,7 +92,8 @@ Start the next cycle of development =================================== -* Update the VERSION file to the development version. For example, at the time of writing ``1.5.0-devel``, and submit this. +* Update the VERSION file to the development version. For example, the name pattern is: ``v{version_name}-devel``, + for example ``v1.5.0-devel``, and submit this. * Submit all the patches that have been ready and waiting. -- To view, visit https://review.coreboot.org/c/flashrom/+/84811?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2bd2e57e42c29ea5a9d8bc334b86c6fa5c4b46a4 Gerrit-Change-Number: 84811 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25LU64C
by Anastasia Klimchuk (Code Review) 20 Oct '24

20 Oct '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/84775?usp=email ) Change subject: flashchips: Add Support for XMC XM25LU64C ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/84775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8d1af7fbfb4c45db09ed5ac82c683d273c8151c7 Gerrit-Change-Number: 84775 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sun, 20 Oct 2024 06:48:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25LU64C
by Ssunk (Code Review) 20 Oct '24

20 Oct '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/84775?usp=email ) Change subject: flashchips: Add Support for XMC XM25LU64C ...................................................................... Patch Set 3: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/84775/comment/6312fd78_d094182d?us… : PS2, Line 22689: XM25LU64 > Sorry I have only noticed just now: the name is missing "C" at the end (it's XM25LU64C). […] Thank you for reviewing it so carefully!I modified it. -- To view, visit https://review.coreboot.org/c/flashrom/+/84775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8d1af7fbfb4c45db09ed5ac82c683d273c8151c7 Gerrit-Change-Number: 84775 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sun, 20 Oct 2024 01:35:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25LU64C
by Ssunk (Code Review) 20 Oct '24

20 Oct '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/84775?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add Support for XMC XM25LU64C ...................................................................... flashchips: Add Support for XMC XM25LU64C Add initial support for the SPI flash chip XM25LU64C Datasheet link: https://www.xmcwh.com/uploads/954/XM25LU64C%20_%20Ver1.4.pdf XM25QU64C/XM25LU64C Tested with ch341a programmer: probe, read, write, erase Change-Id: I8d1af7fbfb4c45db09ed5ac82c683d273c8151c7 Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/84775/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/84775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8d1af7fbfb4c45db09ed5ac82c683d273c8151c7 Gerrit-Change-Number: 84775 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[M] Change in flashrom[main]: Display progress for what is actually erased/written
by Sergii Dmytruk (Code Review) 19 Oct '24

19 Oct '24

Attention is currently required from: Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84439?usp=email ) Change subject: Display progress for what is actually erased/written ...................................................................... Patch Set 13: (2 comments) File flashrom.c: https://review.coreboot.org/c/flashrom/+/84439/comment/e78fc27d_c57d566f?us… : PS13, Line 1270: // FIXME: round up to granularity? > It is a bit odd that `get_next_write` returns len, but `need_erase` returns 0 or 1, it would be cool […] I think `get_next_write` limits length to not try to suggest writing more data then there is. There is no such data for erasing. I think it can be deal with when cases of incorrect progress reporting surface. I'm not even sure that looping over pages here was the right choice. https://review.coreboot.org/c/flashrom/+/84439/comment/14199e27_2e4d1b07?us… : PS13, Line 1281: // FIXME: should be rounded up to page size? > It seems to me, this level of details is what `get_next_write` should be taking care of. […] It does take granularity into account so maybe it's fine as is, assuming that regions never cross boundary specified by chip granularity. -- To view, visit https://review.coreboot.org/c/flashrom/+/84439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I88ac4d40f1b6ccc1636b1efb690d8d68bdebec08 Gerrit-Change-Number: 84439 Gerrit-PatchSet: 13 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 19 Oct 2024 16:17:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[L] Change in flashrom[main]: Complete and fix progress feature implementation for all operations
by Sergii Dmytruk (Code Review) 19 Oct '24

19 Oct '24

Attention is currently required from: Aarya, Anastasia Klimchuk, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/flashrom/+/84102?usp=email ) Change subject: Complete and fix progress feature implementation for all operations ...................................................................... Patch Set 11: (1 comment) File cli_output.c: https://review.coreboot.org/c/flashrom/+/84102/comment/fcb62a6e_f9160390?us… : PS9, Line 164: progress_separator = (fmt[strlen(fmt) - 1] == '\n' ? NEWLINE : MIDLINE); > Oh yes, I haven't thought about it! There are probably many ways to fix that, I picked one way, let […] I don't think it's worth calling `strlen()` twice like that in case of lots of logging lines. Also if the format is empty, the state shouldn't change at all. Maybe make a function like this to also reduce duplication: ```c static void update_line_state(const char *fmt) { size_t len = strlen(fmt); if (len != 0) line_state = (fmt[len - 1] == '\n' ? NEWLINE : MIDLINE); } ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/84102?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If1e40fc97f443c4f0c0501cef11cff1f3f84c051 Gerrit-Change-Number: 84102 Gerrit-PatchSet: 11 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 19 Oct 2024 16:03:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[M] Change in flashrom[main]: Display progress for what is actually erased/written
by Anastasia Klimchuk (Code Review) 19 Oct '24

19 Oct '24

Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84439?usp=email ) Change subject: Display progress for what is actually erased/written ...................................................................... Patch Set 13: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/84439/comment/9fbf7745_9345869c?us… : PS13, Line 1463: // TODO: use erase_layout? I want to try to do this, leaving this as comment -- To view, visit https://review.coreboot.org/c/flashrom/+/84439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I88ac4d40f1b6ccc1636b1efb690d8d68bdebec08 Gerrit-Change-Number: 84439 Gerrit-PatchSet: 13 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 19 Oct 2024 12:50:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: Display progress for what is actually erased/written
by Anastasia Klimchuk (Code Review) 19 Oct '24

19 Oct '24

Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84439?usp=email ) Change subject: Display progress for what is actually erased/written ...................................................................... Patch Set 13: (2 comments) File flashrom.c: https://review.coreboot.org/c/flashrom/+/84439/comment/9bb9bb2e_8efa0d07?us… : PS13, Line 1270: // FIXME: round up to granularity? It is a bit odd that `get_next_write` returns len, but `need_erase` returns 0 or 1, it would be cool for it to return length as well. Similar to my other comment, I think that rounding up to granularity is the level of details which should be inside `need_erase`. However, what to do now. The granularity is default in all of the flashchips (except of just 3), and default is 256 bytes. The smallest eraseblock is 4K nowadays, which is way larger than 256 bytes. Maybe we can just leave it ? and move the fixme comment into need_erase? https://review.coreboot.org/c/flashrom/+/84439/comment/78f61d63_e0a4f19b?us… : PS13, Line 1281: // FIXME: should be rounded up to page size? It seems to me, this level of details is what `get_next_write` should be taking care of. And here, we should just take the len that get_next_write returns. However currently `get_next_write` ignores the page size, not sure if it's on purpose or todo left. I would leave the code here as is, and maybe move the fixme comment into get_next_write. What do you think about it? -- To view, visit https://review.coreboot.org/c/flashrom/+/84439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I88ac4d40f1b6ccc1636b1efb690d8d68bdebec08 Gerrit-Change-Number: 84439 Gerrit-PatchSet: 13 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 19 Oct 2024 12:47:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: Display progress for what is actually erased/written
by Anastasia Klimchuk (Code Review) 19 Oct '24

19 Oct '24

Hello Sergii Dmytruk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/84439?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Display progress for what is actually erased/written ...................................................................... Display progress for what is actually erased/written Change-Id: I88ac4d40f1b6ccc1636b1efb690d8d68bdebec08 Co-developed-by: Anastasia Klimchuk <aklm(a)flashrom.org> Co-developed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/classic_cli_manpage.rst M flashrom.c M tests/chip.c M tests/tests.c M tests/tests.h 5 files changed, 109 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/84439/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/84439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I88ac4d40f1b6ccc1636b1efb690d8d68bdebec08 Gerrit-Change-Number: 84439 Gerrit-PatchSet: 13 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: Display progress for what is actually erased/written
by Anastasia Klimchuk (Code Review) 19 Oct '24

19 Oct '24

Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84439?usp=email ) Change subject: Display progress for what is actually erased/written ...................................................................... Patch Set 12: (1 comment) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/84439/comment/627ebcfb_c5a5cf20?us… : PS12, Line 51: size_t last_seen[FLASHROM_PROGRESS_NR]; I added this while fixing the tests for feature_no_erase, but I think it is useful regardless. It only makes sense to compare "last_seen" with current for the same operation. -- To view, visit https://review.coreboot.org/c/flashrom/+/84439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I88ac4d40f1b6ccc1636b1efb690d8d68bdebec08 Gerrit-Change-Number: 84439 Gerrit-PatchSet: 12 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 19 Oct 2024 10:12:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit