Attention is currently required from: ChrisEric1 CECL, Nicholas Chin.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72057
to look at the new patch set (#9).
Change subject: Add support for VIA VL805 USB 3 XHCI flashing
......................................................................
Add support for VIA VL805 USB 3 XHCI flashing
It works fine for me on my Raspberry Pi 4 Model B. Was able …
[View More]read read,
erase, write, verify. Only thing is the WP with the W25X10 gives a
untested warning. And I changed W25X10 to RDID4 since it wouldn't work
otherwise.
Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com>
---
M Makefile
M flashrom.8.tmpl
M include/programmer.h
M meson.build
M meson_options.txt
M programmer_table.c
A vl805.c
7 files changed, 216 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/9
--
To view, visit https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 9
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: ChrisEric1 CECL, Nicholas Chin.
Hello build bot (Jenkins), Paul Menzel, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72056
to look at the new patch set (#5).
Change subject: Add missing Intel B460 flash chip id
......................................................................
Add missing Intel B460 flash chip id
Note that while I can read the chip, on my Lenovo Legion T5 28IMB05,…
[View More]
cannot write to the flash chip with any tools except upgrading with
vendor tool, no downgrades are allowed, due to the fact of SMM, even if
I did manage to flash the BIOS chip somehow, would still face bootguard
since this machine has bootguard. But if I read the chip, and verify my
read bin file, it works fine, until changing the SMBIOS, which is in
the vendor BIOS update package.
Change-Id: Id8fcb59d5dbafea3e79c4e3ad75484bbd163feca
Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com>
---
M chipset_enable.c
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/72056/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/72056
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id8fcb59d5dbafea3e79c4e3ad75484bbd163feca
Gerrit-Change-Number: 72056
Gerrit-PatchSet: 5
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: ChrisEric1 CECL, Nicholas Chin.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB 3 XHCI flashing
......................................................................
Patch Set 8:
(6 comments)
Patchset:
PS3:
> Hello! […]
1. Ok,
2. Yes, thats fine. But I missed one thing. Can you add `vl805` also to `meson_options.txt` under `option('programmer', .…
[View More]..`
3. I'll also have a closer look for the RDID4. This has something to do with how many ID bytes were queried IIRC.
I've found also an VL805 PCI card in my pile of stuff and will give your patch a try tomorrow.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/224f6d01_f91557c9
PS8, Line 19126: .probe = PROBE_SPI_RDID4,
This should also be an other commit. Can be before this or after.
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/72057/comment/aa48f95d_248c16bd
PS8, Line 1706: and raw memory access
pci configutation space is enough.
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/472a7fc5_bb509e79
PS3, Line 38: static struct pci_dev *dev = NULL;
> Cannot do that, this part is outside of the global which needs it: […]
This was referred to `static struct pci_dev *dev = NULL`, not `dev_entries`.
The plan is to have the `pci_dev` handle in a data struct, allocated by `vl805_init()` and passed on via the `flashxtx *ctx->mst->spi.data`.
So
```
void vl805_setregval(int reg, uint32_t val)
```
becomes
```
void vl805_setregval(struct pci_dev *dev, int reg, uint32_t val)
```
And `vl805_spi_send_command` gets the pci_dev* like in `pickit2_spi.c:402`
https://review.coreboot.org/c/flashrom/+/72057/comment/384dc12a_9d074372
PS3, Line 72: uint32_t indata = 0;
: unsigned int curwritecnt = 0;
: unsigned int curreadcnt = 0;
> I don't understand what you are trying to say, if you remove the highlighted part, it fails to build […]
The ` = 0` is not needed for each of them. A declaration of those variables is sufficient. They don't need to be initialized.
https://review.coreboot.org/c/flashrom/+/72057/comment/125a2ad4_739206f3
PS3, Line 107: static const struct spi_master spi_master_vl805 = {
> I have no clue right now, but I added it in to see if it works later.
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 8
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 13 Feb 2023 16:18:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Arthur Heymans, Nicholas Chin.
Hello build bot (Jenkins), Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72058
to look at the new patch set (#4).
Change subject: Add support for AMD Ryzen flashing
......................................................................
Add support for AMD Ryzen flashing
Tested AMD Ryzen Support on HP Pavilion 590-p0077c, I am able to flash
using F.15 or …
[View More]older, but I can downgrade if a newer Firmware is
installed using afuwinx64 which is a vendor tool This is due to
flashrom SPI lockdown on newer firmwares by HP. It seems HP UEFI Diags
uses AFU Flash embedded in. It also comes with a AMD Ryzen 3 2200G with
16MB, so it may not work with chips more that 16MB, it is currently
untested by me, since this is the only AMD PC I own.
Change-Id: Ife51f7dec31b51a7416e417112b0eedb21fae6a0
Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com>
---
M chipset_enable.c
M include/flashchips.h
M include/programmer.h
M sb600spi.c
M spi25.c
5 files changed, 41 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/72058/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/72058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ife51f7dec31b51a7416e417112b0eedb21fae6a0
Gerrit-Change-Number: 72058
Gerrit-PatchSet: 4
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: Thomas Heijligen, Nicholas Chin.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72057
to look at the new patch set (#7).
Change subject: Add support for VIA VL805 USB 3 XHCI flashing
......................................................................
Add support for VIA VL805 USB 3 XHCI flashing
It works fine for me on my Raspberry Pi 4 Model B. Was able …
[View More]read read,
erase, write, verify. Only thing is the WP with the W25X10 gives a
untested warning. And I changed W25X10 to RDID4 since it wouldn't work
otherwise.
Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com>
---
M Makefile
M flashchips.c
M flashrom.8.tmpl
M include/programmer.h
M meson.build
M programmer_table.c
A vl805.c
7 files changed, 216 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/7
--
To view, visit https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 7
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: Thomas Heijligen, Nicholas Chin.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72057
to look at the new patch set (#6).
Change subject: Add support for VIA VL805 USB 3 XHCI flashing
......................................................................
Add support for VIA VL805 USB 3 XHCI flashing
It works fine for me on my Raspberry Pi 4 Model B. Was able …
[View More]read read,
erase, write, verify. Only thing is the WP with the W25X10 gives a
untested warning. And I changed W25X10 to RDID4 since it wouldn't work
otherwise.
Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com>
---
M Makefile
M flashrom.8.tmpl
M include/programmer.h
M meson.build
M programmer_table.c
A vl805.c
6 files changed, 215 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/6
--
To view, visit https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 6
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: Thomas Heijligen, Nicholas Chin.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72057
to look at the new patch set (#5).
Change subject: Add support for VIA VL805 USB 3 XHCI flashing
......................................................................
Add support for VIA VL805 USB 3 XHCI flashing
It works fine for me on my Raspberry Pi 4 Model B. Was able …
[View More]read read,
erase, write, verify. Only thing is the WP with the W25X10 gives a
untested warning. And I changed W25X10 to RDID4 since it wouldn't work
otherwise.
Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com>
---
M Makefile
M flashchips.c
M flashrom.8.tmpl
M include/programmer.h
M meson.build
M programmer_table.c
A vl805.c
7 files changed, 20,929 insertions(+), 20,714 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 5
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: Thomas Heijligen, Nicholas Chin.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72057
to look at the new patch set (#4).
Change subject: Add support for VIA VL805 USB 3 XHCI flashing
......................................................................
Add support for VIA VL805 USB 3 XHCI flashing
It works fine for me on my Raspberry Pi 4 Model B. Was able …
[View More]read read,
erase, write, verify. Only thing is the WP with the W25X10 gives a
untested warning. And I changed W25X10 to RDID4 since it wouldn't work
otherwise.
Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com>
---
M Makefile
M flashchips.c
M flashrom.8.tmpl
M include/programmer.h
M meson.build
M programmer_table.c
A vl805.c
7 files changed, 20,929 insertions(+), 20,714 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 4
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
[View Less]