- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: Add support for VIA VL805 USB controller flashing
by Thomas Heijligen (Code Review) 15 Mar '23

15 Mar '23

Attention is currently required from: Christopher Lentocha. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB controller flashing ...................................................................... Patch Set 25: (1 comment) Patchset: PS23: > https://github. […] Thanks a lot! The logs are exactly what I need. But I'll need some time to come back to this. -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 25 Gerrit-Owner: Christopher Lentocha <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Christopher Lentocha <christopherericlentocha(a)gmail.com> Gerrit-Comment-Date: Wed, 15 Mar 2023 20:02:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christopher Lentocha <christopherericlentocha(a)gmail.com> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Fix RPi4 VL805 USB controller flashing for W25X10 chips to RDID4
by Thomas Heijligen (Code Review) 15 Mar '23

15 Mar '23

Attention is currently required from: Christopher Lentocha. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73059 ) Change subject: Fix RPi4 VL805 USB controller flashing for W25X10 chips to RDID4 ...................................................................... Patch Set 4: Code-Review-2 (1 comment) Patchset: PS1: > Do you still need the dump? Its in my logs here: https://github.com/CE1CECL/72057/raw/main/READ. […] Thanks. -- To view, visit https://review.coreboot.org/c/flashrom/+/73059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I346a8292eb345fcdbadcf0e09729a55f411c83e3 Gerrit-Change-Number: 73059 Gerrit-PatchSet: 4 Gerrit-Owner: Christopher Lentocha <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christopher Lentocha <christopherericlentocha(a)gmail.com> Gerrit-Comment-Date: Wed, 15 Mar 2023 19:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Christopher Lentocha <christopherericlentocha(a)gmail.com> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Fix RPi4 VL805 USB controller flashing for W25X10 chips to RDID4
by ChrisEric1 CECL (Code Review) 15 Mar '23

15 Mar '23

Attention is currently required from: Thomas Heijligen. ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73059 ) Change subject: Fix RPi4 VL805 USB controller flashing for W25X10 chips to RDID4 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Hi, While experimenting around I've lost my firmware, can you give me a dump of yours, thanks. […] Do you still need the dump? Its in my logs here: https://github.com/CE1CECL/72057/raw/main/READ.bin -- To view, visit https://review.coreboot.org/c/flashrom/+/73059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I346a8292eb345fcdbadcf0e09729a55f411c83e3 Gerrit-Change-Number: 73059 Gerrit-PatchSet: 1 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 15 Mar 2023 18:53:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB controller flashing
by ChrisEric1 CECL (Code Review) 15 Mar '23

15 Mar '23

Attention is currently required from: Thomas Heijligen. ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB controller flashing ...................................................................... Patch Set 23: (1 comment) Patchset: PS23: > I've dug much deeper into this programmer and here is an update: […] https://github.com/CE1CECL/72057/commit/082be14dbbc80ff7734b1fd6a7e8b88ac8d… -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 23 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 15 Mar 2023 18:45:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: cli_classic: refactor arguments parsing into separate func
by Anastasia Klimchuk (Code Review) 15 Mar '23

15 Mar '23

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66343 ) Change subject: cli_classic: refactor arguments parsing into separate func ...................................................................... Patch Set 8: Code-Review+2 (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/66343/comment/600f32cb_8e067f95 PS7, Line 51: unsigned int wp_start, wp_len; > I see your point. Current patch stores them in the next layout: […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/66343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id573bc74e3bb46b7dc42f1452fff6394d4f091bc Gerrit-Change-Number: 66343 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 15 Mar 2023 10:32:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Peter Marheine (Code Review) 15 Mar '23

15 Mar '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 ) Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/73513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 6 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 23:47:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tests: Add wrap for __fstat50 to fix tests for NetBSD
by Peter Marheine (Code Review) 15 Mar '23

15 Mar '23

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73649 ) Change subject: tests: Add wrap for __fstat50 to fix tests for NetBSD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/73649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icb8e453328cb40ab9d628f01ecdc3886a233dad5 Gerrit-Change-Number: 73649 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 14 Mar 2023 23:45:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Revert "pcidev: remove pcidev_getdevfn() function"
by Edward O'Callaghan (Code Review) 14 Mar '23

14 Mar '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73730 ) Change subject: Revert "pcidev: remove pcidev_getdevfn() function" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cd2f54cb6a6e35dc353476e0f5e502cbbd06cba Gerrit-Change-Number: 73730 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:47:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: cli_classic: refactor arguments parsing into separate func
by Alexander Goncharov (Code Review) 14 Mar '23

14 Mar '23

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66343 ) Change subject: cli_classic: refactor arguments parsing into separate func ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/66343/comment/5ac0df55_582bf3eb PS7, Line 21: TEST=builds > I would be good to test the patch. Dummyflasher is perfectly fine for the purpose. […] Done File cli_classic.c: https://review.coreboot.org/c/flashrom/+/66343/comment/6b308a35_e86afa63 PS7, Line 51: unsigned int wp_start, wp_len; > I think, grouping by purpose would be better than grouping by data type. […] I see your point. Current patch stores them in the next layout: ``` operations -- programmer + param -- layout -- wp -- others ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/66343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id573bc74e3bb46b7dc42f1452fff6394d4f091bc Gerrit-Change-Number: 66343 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:51:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: cli_classic: refactor arguments parsing into separate func
by Alexander Goncharov (Code Review) 14 Mar '23

14 Mar '23

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov. Hello build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66343 to look at the new patch set (#8). Change subject: cli_classic: refactor arguments parsing into separate func ...................................................................... cli_classic: refactor arguments parsing into separate func Move variables that represent parsed options to `cli_options` structure. This patchset also introduces the following functions: - parse_options() which parses command line arguments and fills the structure. - free_options() that releases an allocated data from the structure. This is one of the steps on the way to simplify the main function by using helper functions with descriptive names. TOPIC=split_main_func TEST=the following scenarious run successfully ./flashrom -p dummy:emulate=S25FL128L -V ./flashrom -p dummy:size=8388608,emulate=VARIABLE_SIZE \ -r /tmp/dump.rom ./flashrom -p dummy:emulate=W25Q128FV -l /tmp/rom.layout \ -i boot -w /tmp/rom.tr.img ./flashrom -p dummy:emulate=W25Q128FV --wp-list ./flashrom -p dummy:emulate=W25Q128FV,hwwp=yes \ --wp-enable \ --wp-range=0x00c00000,0x00400000 \ --wp-status $ head -c 16MiB </dev/urandom >/tmp/image.rom ./flashrom -p dummy:image=/tmp/image.rom,emulate=S25FL128L \ -c S25FL128L -E -V Change-Id: Id573bc74e3bb46b7dc42f1452fff6394d4f091bc Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M cli_classic.c 1 file changed, 406 insertions(+), 343 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/66343/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/66343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id573bc74e3bb46b7dc42f1452fff6394d4f091bc Gerrit-Change-Number: 66343 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit