- flashrom-gerrit - mail.coreboot.org

[XL] Change in flashrom[master]: Add support for VIA VL805 USB 3 XHCI flashing
by ChrisEric1 CECL (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: Thomas Heijligen, Nicholas Chin. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72057 to look at the new patch set (#5). Change subject: Add support for VIA VL805 USB 3 XHCI flashing ...................................................................... Add support for VIA VL805 USB 3 XHCI flashing It works fine for me on my Raspberry Pi 4 Model B. Was able read read, erase, write, verify. Only thing is the WP with the W25X10 gives a untested warning. And I changed W25X10 to RDID4 since it wouldn't work otherwise. Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- M Makefile M flashchips.c M flashrom.8.tmpl M include/programmer.h M meson.build M programmer_table.c A vl805.c 7 files changed, 20,929 insertions(+), 20,714 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 5 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[master]: Add support for VIA VL805 USB 3 XHCI flashing
by ChrisEric1 CECL (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: Thomas Heijligen, Nicholas Chin. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72057 to look at the new patch set (#4). Change subject: Add support for VIA VL805 USB 3 XHCI flashing ...................................................................... Add support for VIA VL805 USB 3 XHCI flashing It works fine for me on my Raspberry Pi 4 Model B. Was able read read, erase, write, verify. Only thing is the WP with the W25X10 gives a untested warning. And I changed W25X10 to RDID4 since it wouldn't work otherwise. Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- M Makefile M flashchips.c M flashrom.8.tmpl M include/programmer.h M meson.build M programmer_table.c A vl805.c 7 files changed, 20,929 insertions(+), 20,714 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 4 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: Add support for VIA VL805 USB 3 XHCI flashing
by ChrisEric1 CECL (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: Thomas Heijligen, Nicholas Chin. ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB 3 XHCI flashing ...................................................................... Patch Set 3: (15 comments) Patchset: PS3: > Hi Cristopher, […] Hello! 1. I can move the IS25LP080D part that was added in another commit, but since I don't actually have the chip, I cannot test it anyways, so I am just going to remove it, unless someone reports that its needed for another machine. 2. Would something like this work? ... 'srcs' : files('usbblaster_spi.c'), 'flags' : [ '-DCONFIG_USBBLASTER_SPI=1' ], }, 'vl805' : { 'systems' : systems_hwaccess, 'deps' : [ libpci ], 'groups' : [ group_pci, group_internal ], 'srcs' : files('vl805.c', 'pcidev.c'), 'flags' : [ '-DCONFIG_VL805=1' ], }, } active_programmer_count = 0 foreach p_name, p_data : programmer ... 3. This driver is based off of the work from https://github.com/CE1CECL/flashrom-vl805/commit/1448afa15f9a8dddb3e539349e… for flashrom v1.1, which has since been ported to mainline by me. However, the patch set that you found earlier didn't actually work for me on my Raspberry Pi 4 Model B, pretty sure it was just missing the RDID4 thing. What even is RDID4 for anyways? Does SPI_MASTER_4BA solve it? (I'm not home at the moment, will need to test later today). I did actually not keep my logs for my errors but IIRC it said something like it found an unknown chip and it was in unknown state? Either way, the RDID4 fixed it for me at least. I will mark the comments I was able to solve as resolved though since I'm not some, I am only compiling it, making sure it builds. PS3: > Original patch CB:50264 This is the non-working patch I mentioned earlier. File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/72057/comment/83326430_52c97c3f PS3, Line 1371: VL806 > Is there a different between VL805 and VL806? This is the only mention of the second chip According to https://www.via-labs.com/product_show.php?id=48 they are the same, but I don't have a vl806, only a vl805, so I removed the vl806 mention in the next patch. File vl805.c: https://review.coreboot.org/c/flashrom/+/72057/comment/21384537_19d4d7e5 PS3, Line 4: * Copyright (C) 2019, 2020 Carl-Daniel Hailfinger > This is your copyright Fixed in next patch. https://review.coreboot.org/c/flashrom/+/72057/comment/96c14bff_0643c450 PS3, Line 27: //#include "hwaccess.h" > Please remove this comment. I wasn't sure what it was for so I commented it out, next patch will remove it. https://review.coreboot.org/c/flashrom/+/72057/comment/3849653b_f6c9019c PS3, Line 28: #include "hwaccess_x86_io.h" > This header is not needed, because the programmer doesn't do anything with I/O ports. […] Fixed in next patch, although it does say the vl805 FW version, it might be part of SPI. https://review.coreboot.org/c/flashrom/+/72057/comment/7531093b_a1821826 PS3, Line 31: extern const struct dev_entry devs_vl805[]; > This is not needed. Fixed in next patch. https://review.coreboot.org/c/flashrom/+/72057/comment/023fa7cf_f7c6f764 PS3, Line 33: const struct dev_entry devs_vl805[] = { > Make this `static`. It is only used in this file. Fixed in next patch, which is coming later sometime today. https://review.coreboot.org/c/flashrom/+/72057/comment/559ce626_75b7849c PS3, Line 38: static struct pci_dev *dev = NULL; > Can you please move this global into a programmer data struct, like it is done on e.g. the it8212. […] Cannot do that, this part is outside of the global which needs it: Sorry, had a hard time formatting, so it will look weird in gerrit. static struct dev_entry devs_vl805[] = { {0x1106, 0x3483, OK, "VIA", "VL805"}, {0}, }; https://review.coreboot.org/c/flashrom/+/72057/comment/59a9cca0_978f7121 PS3, Line 53: /* Some of the registers have unknown purpose and are just used inside the init sequence replay. */ > Can you put these defines below the includes, ontop of all functions? Done, will be in next patch. https://review.coreboot.org/c/flashrom/+/72057/comment/cfd98314_2dda6ba3 PS3, Line 72: uint32_t indata = 0; : unsigned int curwritecnt = 0; : unsigned int curreadcnt = 0; > These variables don't need to be initialized. I don't understand what you are trying to say, if you remove the highlighted part, it fails to build, unless you mean to rework it? https://review.coreboot.org/c/flashrom/+/72057/comment/77242e19_7fd4cf05 PS3, Line 107: static const struct spi_master spi_master_vl805 = { > Can this controller handle SPI flashes with 4-byte addresses? Then you should add `. […] I have no clue right now, but I added it in to see if it works later. https://review.coreboot.org/c/flashrom/+/72057/comment/aa723886_7d0d2e84 PS3, Line 131: int vl805_init(const struct programmer_cfg *cfg); > This prototype is not needed if the function is static. Removed in next patch. https://review.coreboot.org/c/flashrom/+/72057/comment/db7629bf_2c0785cf PS3, Line 133: int vl805_init(const struct programmer_cfg *cfg) > this should be `static` `static int vl805_init(const struct programmer_cfg *cfg)` in next patch https://review.coreboot.org/c/flashrom/+/72057/comment/44753936_ec44152a PS3, Line 137: #if defined(__i386__) || defined(__x86_64__) : if (rget_io_perms()) : return 1; : #endif > This can be removed since the programmer doesn't deal with I/O ports Fixed in next patch -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 3 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 13 Feb 2023 14:56:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: Add support for VIA VL805 USB 3 XHCI flashing
by Thomas Heijligen (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: ChrisEric1 CECL, Nicholas Chin. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB 3 XHCI flashing ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Original patch CB:50264 -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 3 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 13 Feb 2023 11:14:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: serial: Add Darwin/macOS support for custom and >230400 baudrates
by Thomas Heijligen (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: Peter Stuge, Name of user not set #1004601. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70571 ) Change subject: serial: Add Darwin/macOS support for custom and >230400 baudrates ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Patchset: PS7: > Thanks, glad to drop the change in between! […] This may be resolved during the cherry-picking. -- To view, visit https://review.coreboot.org/c/flashrom/+/70571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3e6b88d2b4c2a130b16456752681fd9f807bf6f0 Gerrit-Change-Number: 70571 Gerrit-PatchSet: 7 Gerrit-Owner: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: Name of user not set #1004601 Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Stuge <peter(a)stuge.se> Gerrit-Attention: Name of user not set #1004601 Gerrit-Comment-Date: Mon, 13 Feb 2023 10:56:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Peter Stuge <peter(a)stuge.se> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: serial: Call set_custom_baudrate() thrice
by Thomas Heijligen (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: Peter Stuge. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70569 ) Change subject: serial: Call set_custom_baudrate() thrice ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/70569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I40cc443cfb7bf6b212b31826d437b898cc13c427 Gerrit-Change-Number: 70569 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Name of user not set #1004601 Gerrit-Attention: Peter Stuge <peter(a)stuge.se> Gerrit-Comment-Date: Mon, 13 Feb 2023 10:55:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: Determine custom_baud source file only once
by Thomas Heijligen (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: Peter Stuge. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70568 ) Change subject: meson: Determine custom_baud source file only once ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/70568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13221bdca7d14a483f416e81e3830a495659a85e Gerrit-Change-Number: 70568 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Stuge <peter(a)stuge.se> Gerrit-Comment-Date: Mon, 13 Feb 2023 10:54:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: internal: Move parallel logic into internal_par implementation
by Thomas Heijligen (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71834 ) Change subject: internal: Move parallel logic into internal_par implementation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/71834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idabeceb59a36680f5fbb45d3ee4bd5dbf837373b Gerrit-Change-Number: 71834 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 13 Feb 2023 10:47:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: jedec.c: Move printlock stuff into printlock.c
by Thomas Heijligen (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: Stefan Reinauer, Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72607 ) Change subject: jedec.c: Move printlock stuff into printlock.c ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/72607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iacaa16c81e141aac30feb6871700c4fdc9eec8e9 Gerrit-Change-Number: 72607 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 13 Feb 2023 10:39:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: internal.c: Factor out laptop alerts into helper func
by Thomas Heijligen (Code Review) 13 Feb '23

13 Feb '23

Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71578 ) Change subject: internal.c: Factor out laptop alerts into helper func ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/71578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8eea91012e6539b4fdf5d49a75a9cb48bb8a57ca Gerrit-Change-Number: 71578 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 13 Feb 2023 10:35:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit