- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: spi: Make default cmd helpers static internal
by Thomas Heijligen (Code Review) 04 Mar '23

04 Mar '23

Thomas Heijligen has submitted this change. ( https://review.coreboot.org/c/flashrom/+/73337 ) Change subject: spi: Make default cmd helpers static internal ...................................................................... spi: Make default cmd helpers static internal Avoid these leaking into driver implementations as a NULL field now implies their implementation. This removes one source of a driver bug where both `mst->command` AND `mst->multicommand` are set to default implementations which is actually a cyclical control flow condition. The driver however must still have either `mst->command` OR `mst->multicommand` defined and so both cannot be NULL. This simplifies the code and driver development. Change-Id: I4ef95846c2f005cf4aa727f31548c6877d2d4801 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/73337 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M include/programmer.h M spi.c 2 files changed, 44 insertions(+), 23 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/include/programmer.h b/include/programmer.h index f72f1d7..f6bc8ce 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -318,9 +318,6 @@ void *data; }; -int default_spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, - const unsigned char *writearr, unsigned char *readarr); -int default_spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds); int default_spi_read(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); int default_spi_write_256(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int default_spi_write_aai(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); diff --git a/spi.c b/spi.c index 4fe0fa5..3b3f622 100644 --- a/spi.c +++ b/spi.c @@ -26,23 +26,7 @@ #include "programmer.h" #include "spi.h" -int spi_send_command(const struct flashctx *flash, unsigned int writecnt, - unsigned int readcnt, const unsigned char *writearr, - unsigned char *readarr) -{ - if (flash->mst->spi.command) - return flash->mst->spi.command(flash, writecnt, readcnt, writearr, readarr); - return default_spi_send_command(flash, writecnt, readcnt, writearr, readarr); -} - -int spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds) -{ - if (flash->mst->spi.multicommand) - return flash->mst->spi.multicommand(flash, cmds); - return default_spi_send_multicommand(flash, cmds); -} - -int default_spi_send_command(const struct flashctx *flash, unsigned int writecnt, +static int default_spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr) @@ -63,7 +47,7 @@ return spi_send_multicommand(flash, cmd); } -int default_spi_send_multicommand(const struct flashctx *flash, +static int default_spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds) { int result = 0; @@ -74,6 +58,22 @@ return result; } +int spi_send_command(const struct flashctx *flash, unsigned int writecnt, + unsigned int readcnt, const unsigned char *writearr, + unsigned char *readarr) +{ + if (flash->mst->spi.command) + return flash->mst->spi.command(flash, writecnt, readcnt, writearr, readarr); + return default_spi_send_command(flash, writecnt, readcnt, writearr, readarr); +} + +int spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds) +{ + if (flash->mst->spi.multicommand) + return flash->mst->spi.multicommand(flash, cmds); + return default_spi_send_multicommand(flash, cmds); +} + int default_spi_read(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len) { @@ -156,8 +156,7 @@ } if (!mst->write_256 || !mst->read || !mst->probe_opcode || - ((mst->command == default_spi_send_command || !mst->command) && - (mst->multicommand == default_spi_send_multicommand || !mst->multicommand))) { + (!mst->command && !mst->multicommand)) { msg_perr("%s called with incomplete master definition. " "Please report a bug at flashrom(a)flashrom.org\n", __func__); -- To view, visit https://review.coreboot.org/c/flashrom/+/73337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ef95846c2f005cf4aa727f31548c6877d2d4801 Gerrit-Change-Number: 73337 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB controller flashing
by Thomas Heijligen (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: ChrisEric1 CECL. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB controller flashing ...................................................................... Patch Set 23: (1 comment) Patchset: PS23: > I found the problem with your chip. The code fails when readcnt != 4 […] I've dug much deeper into this programmer and here is an update: A lot of the names are misleading. * Only `0x43`, `0x50`, `0x78` and `0x7c` are real PCI registers. * All `VL805_REG_*` defines are commands send via the `0x78` register. * The values for the command are passed via the `0x7c` register. The values calculated and written as SPI_TRANSACTION value are for the most cases not correct. Only with 4 bytes in and out it is successful. That's the reason why it works with a `RDID4` patched W25x10 flash and SFDP compatible chips. Random findings: * The CMD_SPI_CS=0 mussed be send after CMD_SPI_TRANSACTION ``` REG_MCU 0x43 - Reserved register REG_FWV 0x50 - Firmware Version (This is the only documented one) REG_CMD 0x78 - XHCI Optional Bits Configuration Address (19:0) REG_DAT 0x7c - XHCI Optional Bits Configuration Data (31:0) CMD_MAGIC_30004 0x00030004 - 0x200, unknown magic value CMD_SPOP_POLLING 0x0004000c - (1|0), currently not sure what's for CMD_PCI_WB_EN 0x00040020 - 0xffffff01 - not a clue what this is exactly for CMD_SPI_OUTDATA 0x000400d0 - <spi commands> + <content> CMD_SPI_INDATA 0x000400e0 - <content> CMD_SPI_TRANSACTION 0x000400f0 - 0x5__ Here lies the problem! CMD_CLK_DIVIDER 0x000400f8 - Default can be used, need external measurement CMD_SPI_CS 0x000400fc - (1|0) voltage on SPI CS Pin, needs confirmation ``` So for now the right values for `CMD_SPI_TRANSACTION` is the missing mystery that needs to be solved. HELP NEEDED: If someone has a Raspberry Pi 4, I'm very interested on a strace of their vl805, closed source, update tool https://github.com/raspberrypi/rpi-eeprom It would be really helpful to get a `strace -x vl805 -d` log of an read, write and verify operation. -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 23 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Mar 2023 14:41:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: [WIP] doc: Add build instructions
by Anastasia Klimchuk (Code Review) 03 Mar '23

03 Mar '23

Attention is currently required from: Thomas Heijligen, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 ) Change subject: [WIP] doc: Add build instructions ...................................................................... Patch Set 1: (5 comments) File doc/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/73359/comment/e51260ef_adf4cc06 PS1, Line 32: build If this is a builddir (I think it is), then let's name it builddir. The reason is that `build` looks like a command, can be confusing. I would prefer the name which indicates a directory. And I just discovered, it is called builddir below! :) https://review.coreboot.org/c/flashrom/+/73359/comment/5413952f_c8b2355a PS1, Line 174: ross ross -> cross (typo) https://review.coreboot.org/c/flashrom/+/73359/comment/9bee4446_2cd5bdca PS1, Line 192: If you are not happy with the initial configuration, e.g. a programmer is missing, : or you want to review it If you want to change your initial configuration for some reason (for example you discovered that a programmer is missing), run:: (In your initial text, I am not sure what did you mean by "you want to review it"? the command changes the config, not just prints it?) https://review.coreboot.org/c/flashrom/+/73359/comment/cd39e1dd_42a25cc3 PS1, Line 206: To get a code coverage report For coverage report: let's keep the existing instructions, please! They more detailed, written recently so they are up-to-date. I don't want to lose that piece of wisdom. File doc/conf.py: https://review.coreboot.org/c/flashrom/+/73359/comment/9d543edc_6b58441a PS1, Line 22: 'sphinx.ext.todo' This is a cool feature! :) -- To view, visit https://review.coreboot.org/c/flashrom/+/73359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324 Gerrit-Change-Number: 73359 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 03 Mar 2023 09:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: cli_classic: refactor arguments parsing into separate func
by Anastasia Klimchuk (Code Review) 03 Mar '23

03 Mar '23

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66343 ) Change subject: cli_classic: refactor arguments parsing into separate func ...................................................................... Patch Set 7: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/66343/comment/7d0da03a_beacc1a3 PS7, Line 21: TEST=builds I would be good to test the patch. Dummyflasher is perfectly fine for the purpose. But unit tests are all running libflashrom, so this layer of cli code is actually not run by tests. Not necessarily all the paths (and you can't do all the paths with dummyflasher anyway), but even some of the paths, the basic ones would be really good! File cli_classic.c: https://review.coreboot.org/c/flashrom/+/66343/comment/b2310053_af211dc9 PS7, Line 51: unsigned int wp_start, wp_len; I think, grouping by purpose would be better than grouping by data type. For example, wp has a bunch of options, they would be good to keep together (with new line before and after group). Another group can be about operations that flashrom performs (options between read_it and show_progress). Then maybe layout group. Stuff that does not belong anywhere can be at the end in "everything else" group. My main intention is to make it easier to find the option in the long list. -- To view, visit https://review.coreboot.org/c/flashrom/+/66343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id573bc74e3bb46b7dc42f1452fff6394d4f091bc Gerrit-Change-Number: 66343 Gerrit-PatchSet: 7 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 03 Mar 2023 08:20:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: writeprotect: Add function to get register values and WP bit masks
by Edward O'Callaghan (Code Review) 03 Mar '23

03 Mar '23

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/69847 ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: writeprotect: Add function to get register values and WP bit masks ...................................................................... writeprotect: Add function to get register values and WP bit masks Add a new wp_cfg_to_reg_values() function that takes a generic wp_cfg instance and returns the chip-specific values that need to be written to the chip's registers to enable the specified protection range/mode. The function returns three values for each chip register: - reg_values[reg] - Value writeprotect will write to reg - bit_masks[reg] - Bit mask for WP-related bits in reg - write_masks[reg] - Bit mask for writable WP-related bits in reg (i.e. the ones writeprotect will try to write) BUG=b:260019525,b:259013033,260020006 BRANCH=none TEST=ninja test Change-Id: Ib2a47153b230c9f82bb4eca357c335f2abbacc20 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/69847 Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M include/writeprotect.h M tests/chip_wp.c M tests/tests.c M tests/tests.h M writeprotect.c 5 files changed, 129 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Sergii Dmytruk: Looks good to me, but someone else must approve diff --git a/include/writeprotect.h b/include/writeprotect.h index 12926c4..7ceed07 100644 --- a/include/writeprotect.h +++ b/include/writeprotect.h @@ -89,4 +89,10 @@ /* Checks if writeprotect functions can be used with the current flash/programmer */ bool wp_operations_available(struct flashrom_flashctx *); +/* + * Converts a writeprotect config to register values and masks that indicate which register bits affect WP state. + * reg_values, bit_masks, and write_masks must all have length of at least MAX_REGISTERS. + */ +enum flashrom_wp_result wp_cfg_to_reg_values(uint8_t *reg_values, uint8_t *bit_masks, uint8_t *write_masks, struct flashrom_flashctx *, const struct flashrom_wp_cfg *); + #endif /* !__WRITEPROTECT_H__ */ diff --git a/tests/chip_wp.c b/tests/chip_wp.c index cb9b3ab..9607a96 100644 --- a/tests/chip_wp.c +++ b/tests/chip_wp.c @@ -327,3 +327,68 @@ flashrom_wp_cfg_release(wp_cfg); } + +/* Chip register values & masks are calculated correctly by WP */ +void wp_get_register_values_and_masks(void **state) +{ + (void) state; /* unused */ + + /* + * Test with range: start = 0x004000, lengh = 0xffc000 + * + * WP should use these bit values: + * WPS (S17) = 0 (write protect scheme) + * CMP (S14) = 1 (range complement) + * SRP1 (S8) = 0 + * SRP0 (S7) = 1 (`SRP1 == 1 && SRP0 == 1` is permanent mode) + * SEC (S6) = 1 (base unit is a 4 KiB sector) + * TB (S5) = 1 (bottom up range) + * BP2 (S4) = 0 + * BP1 (S3) = 1 + * BP0 (S2) = 1 (bp: BP2-0 == 0b011 == 3) + * + * Register values: + * SR1 = 0b11101100 = 0xec + * SR2 = 0b01000000 = 0x40 + * SR3 = 0b00000000 = 0x00 + * + * Masks for WP bits in registers: + * SR1: 0b11111100 = 0xfc + * SR2: 0b01000000 = 0x41 + * SR3: 0b00000100 = 0x04 + * + * All WP bits are RW so write masks should be the same as the bit masks. + * + */ + struct flashrom_flashctx flash = { 0 }; + struct flashchip mock_chip = chip_W25Q128_V; + struct flashrom_wp_cfg *wp_cfg; + + uint8_t reg_values[MAX_REGISTERS]; + uint8_t bit_masks[MAX_REGISTERS]; + uint8_t write_masks[MAX_REGISTERS]; + + setup_chip(&flash, NULL, &mock_chip, "bus=spi,emulate=W25Q128FV"); + + assert_int_equal(0, flashrom_wp_cfg_new(&wp_cfg)); + flashrom_wp_set_mode(wp_cfg, FLASHROM_WP_MODE_HARDWARE); + flashrom_wp_set_range(wp_cfg, 0x004000, 0xffc000); + + assert_int_equal(0, wp_cfg_to_reg_values(reg_values, bit_masks, write_masks, &flash, wp_cfg)); + + assert_int_equal(0xec, reg_values[STATUS1]); + assert_int_equal(0x40, reg_values[STATUS2]); + assert_int_equal(0x00, reg_values[STATUS3]); + + assert_int_equal(0xfc, bit_masks[STATUS1]); + assert_int_equal(0x41, bit_masks[STATUS2]); + assert_int_equal(0x04, bit_masks[STATUS3]); + + assert_int_equal(0xfc, write_masks[STATUS1]); + assert_int_equal(0x41, write_masks[STATUS2]); + assert_int_equal(0x04, write_masks[STATUS3]); + + teardown(NULL); + + flashrom_wp_cfg_release(wp_cfg); +} diff --git a/tests/tests.c b/tests/tests.c index 0de0168..911cf47 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -494,6 +494,7 @@ cmocka_unit_test(wp_init_from_status_dummyflasher_test_success), cmocka_unit_test(full_chip_erase_with_wp_dummyflasher_test_success), cmocka_unit_test(partial_chip_erase_with_wp_dummyflasher_test_success), + cmocka_unit_test(wp_get_register_values_and_masks), }; ret |= cmocka_run_group_tests_name("chip_wp.c tests", chip_wp_tests, NULL, NULL); diff --git a/tests/tests.h b/tests/tests.h index 8f63f91..e273e1d 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -92,6 +92,7 @@ void wp_init_from_status_dummyflasher_test_success(void **state); void full_chip_erase_with_wp_dummyflasher_test_success(void **state); void partial_chip_erase_with_wp_dummyflasher_test_success(void **state); +void wp_get_register_values_and_masks(void **state); /* selfcheck.c */ void selfcheck_programmer_table(void **state); diff --git a/writeprotect.c b/writeprotect.c index d8ffa68..411089d 100644 --- a/writeprotect.c +++ b/writeprotect.c @@ -597,3 +597,31 @@ free(range_pairs); return ret; } + +enum flashrom_wp_result wp_cfg_to_reg_values( + uint8_t *reg_values, uint8_t *bit_masks, uint8_t *write_masks, + struct flashctx *flash, const struct flashrom_wp_cfg *cfg) +{ + struct wp_bits bits; + + if (!chip_supported(flash)) + return FLASHROM_WP_ERR_CHIP_UNSUPPORTED; + + enum flashrom_wp_result ret = read_wp_bits(&bits, flash); + if (ret != FLASHROM_WP_OK) + return ret; + + /* Set protection range */ + ret = set_wp_range(&bits, flash, cfg->range); + if (ret != FLASHROM_WP_OK) + return ret; + + /* Set protection mode */ + ret = set_wp_mode(&bits, cfg->mode); + if (ret != FLASHROM_WP_OK) + return ret; + + get_wp_bits_reg_values(reg_values, bit_masks, write_masks, &flash->chip->reg_bits, bits); + + return FLASHROM_WP_OK; +} -- To view, visit https://review.coreboot.org/c/flashrom/+/69847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a47153b230c9f82bb4eca357c335f2abbacc20 Gerrit-Change-Number: 69847 Gerrit-PatchSet: 10 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: meson: fix typo "documtation" -> "documentation"
by Elyes Haouas (Code Review) 03 Mar '23

03 Mar '23

Attention is currently required from: Thomas Heijligen, Alexander Goncharov. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73394 ) Change subject: meson: fix typo "documtation" -> "documentation" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73394 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia4205b89fd0d7e77ecbcd29392187d8911dd1049 Gerrit-Change-Number: 73394 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 03 Mar 2023 05:11:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: revert to meson version 0.53.0
by Anastasia Klimchuk (Code Review) 03 Mar '23

03 Mar '23

Attention is currently required from: Thomas Heijligen, Paul Menzel, Edward O'Callaghan, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73361 ) Change subject: meson: revert to meson version 0.53.0 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/73361/comment/338698f2_2a9ef97d PS1, Line 10: Pass arguments to `sphinx-doc` via `'-Dkey=value` > Is the new message better? yes! -- To view, visit https://review.coreboot.org/c/flashrom/+/73361 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iff9b8307c741a247a652cf666935c9485fa493fa Gerrit-Change-Number: 73361 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 03 Mar 2023 02:36:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: fix typo "documtation" -> "documentation"
by Anastasia Klimchuk (Code Review) 03 Mar '23

03 Mar '23

Attention is currently required from: Thomas Heijligen, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73394 ) Change subject: meson: fix typo "documtation" -> "documentation" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73394 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia4205b89fd0d7e77ecbcd29392187d8911dd1049 Gerrit-Change-Number: 73394 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 03 Mar 2023 01:21:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: revert to meson version 0.53.0
by Thomas Heijligen (Code Review) 03 Mar '23

03 Mar '23

Attention is currently required from: Paul Menzel, Edward O'Callaghan, Anastasia Klimchuk, Alexander Goncharov. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73361 ) Change subject: meson: revert to meson version 0.53.0 ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/73361/comment/44d0dc91_a0c8a512 PS1, Line 10: Pass arguments to `sphinx-doc` via `'-Dkey=value` > Yes, I understand it better now, thanks for the explanation! I think it would be very good to add th […] Is the new message better? -- To view, visit https://review.coreboot.org/c/flashrom/+/73361 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iff9b8307c741a247a652cf666935c9485fa493fa Gerrit-Change-Number: 73361 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 02 Mar 2023 20:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: fix typo "documtation" -> "documentation"
by Thomas Heijligen (Code Review) 03 Mar '23

03 Mar '23

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/73394 ) Change subject: meson: fix typo "documtation" -> "documentation" ...................................................................... meson: fix typo "documtation" -> "documentation" When building with -Ddocumentation=enabled/disabled this typo terminates meson because meson can't find the misspellt option. Change-Id: Ia4205b89fd0d7e77ecbcd29392187d8911dd1049 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M doc/meson.build 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/73394/1 diff --git a/doc/meson.build b/doc/meson.build index 8826e33..70c3280 100644 --- a/doc/meson.build +++ b/doc/meson.build @@ -22,7 +22,7 @@ ) endif - if get_option('documentation').auto() or get_option('documtation').enabled() + if get_option('documentation').auto() or get_option('documentation').enabled() custom_target( 'documentation', command : [sphinx, '-b', 'html', '-q', '-d', '@PRIVATE_DIR@', '-Drelease=' + meson.project_version(),'@CURRENT_SOURCE_DIR@', '@OUTDIR@/html'], -- To view, visit https://review.coreboot.org/c/flashrom/+/73394 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia4205b89fd0d7e77ecbcd29392187d8911dd1049 Gerrit-Change-Number: 73394 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit