Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons.
Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/73293
to look at the new patch set (#3).
Change subject: libpci: drop support for pciutils < 2.2.0
......................................................................
libpci: drop support for pciutils < 2.2.0
This version was released in september 2005 and had a breaking api
change. Drop it so that we don't need to maintain the old codepath any
longer. Beside that, we have already a second codepath which is using
the new `pci_get_dev` variant exclusively.
Change-Id: If943db350b561a005d8292a53d9255223db3d571
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com>
---
M Makefile
D Makefile.d/pci_old_get_dev_test.c
M include/platform/pci.h
M meson.build
M pcidev.c
5 files changed, 31 insertions(+), 40 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/73293/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/73293
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If943db350b561a005d8292a53d9255223db3d571
Gerrit-Change-Number: 73293
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73293 )
Change subject: libpci: drop support for pciutils < 2.2.0
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/73293/comment/95025f0e_d43ef69b
PS2, Line 9: releasd
releasd -> released (typo)
https://review.coreboot.org/c/flashrom/+/73293/comment/9b86e5f3_0305efa1
PS2, Line 9: an
a
https://review.coreboot.org/c/flashrom/+/73293/comment/2a32e331_77fdf21a
PS2, Line 10: With dropping it
Drop it so that we don't need...
File pcidev.c:
https://review.coreboot.org/c/flashrom/+/73293/comment/d8ff4de4_65613679
PS2, Line 196: new
> This is called once in board_enable.c. Maybe we collapse this completely.
Good idea (both of them) but I think for a separate patch?
--
To view, visit https://review.coreboot.org/c/flashrom/+/73293
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If943db350b561a005d8292a53d9255223db3d571
Gerrit-Change-Number: 73293
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 10:18:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73292 )
Change subject: include/pci.h: Use __has_include() macro to test pci.h path
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/73292
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib20de6bffede910b89937f554b4d56f4799f0762
Gerrit-Change-Number: 73292
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 10:07:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: doc: Add build instructions
......................................................................
Patch Set 3:
(1 comment)
File doc/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/084a0d73_88a30cf4
PS1, Line 206: To get a code coverage report
> Ack
Maybe it's just me, but original instructions feel easier to understand and follow. Maybe keep them as is ? (I am specifically talking about coverage section).
Also llvm section is now missing, it seems.
I would just copy the instructions...
--
To view, visit https://review.coreboot.org/c/flashrom/+/73359
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324
Gerrit-Change-Number: 73359
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Tue, 07 Mar 2023 06:24:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Piotr Halama has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 )
Change subject: flashchips: Add support for Boya BY25D80A
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Patch Set 2:
>
> Hi Piotr, thanks for contributing.
> Can you give us a link to the datasheet for the chip you are adding?
I was using https://datasheet.lcsc.com/lcsc/1912111437_BOYAMICRO-BY25D80ASTIG-R_C383790… as a reference
--
To view, visit https://review.coreboot.org/c/flashrom/+/73513
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7
Gerrit-Change-Number: 73513
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 06 Mar 2023 23:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Piotr Halama.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 )
Change subject: flashchips: Add support for Boya BY25D80A
......................................................................
Patch Set 2:
Hi Piotr, thanks for contributing.
Can you give us a link to the datasheet for the chip you are adding?
--
To view, visit https://review.coreboot.org/c/flashrom/+/73513
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7
Gerrit-Change-Number: 73513
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Piotr Halama <skrzynka(a)halamix2.pl>
Gerrit-Comment-Date: Mon, 06 Mar 2023 22:05:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer, Anastasia Klimchuk, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: doc: Add build instructions
......................................................................
Patch Set 3:
(4 comments)
File doc/developers_doc/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/421502b0_20305b6c
PS3, Line 105: py-
This is py39-sphinx
https://review.coreboot.org/c/flashrom/+/73359/comment/dda257ab_52ac5d2f
PS3, Line 113: install
just `pkg_add`, no `install` needed
https://review.coreboot.org/c/flashrom/+/73359/comment/0d4c81fe_b19d8f7f
PS3, Line 114: py-sphinx
py3-sphinx
https://review.coreboot.org/c/flashrom/+/73359/comment/9dea45ef_c7f09493
PS3, Line 175: .. todo:: Write a sphinx extension to render ``meson_options.txt`` here
> `meson configure` will print out all options including project-specific ones, and the inline documen […]
IIRC `meson configure` will only work when you already have a builddir configured.
I'll document the options manually.
--
To view, visit https://review.coreboot.org/c/flashrom/+/73359
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324
Gerrit-Change-Number: 73359
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Mon, 06 Mar 2023 14:58:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment