- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: dmi.c: Pass is_laptop by ref into dmi
by Edward O'Callaghan (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71622 ) Change subject: dmi.c: Pass is_laptop by ref into dmi ...................................................................... Patch Set 4: (1 comment) File internal.c: https://review.coreboot.org/c/flashrom/+/71622/comment/f9e8c81a_5df15687 PS4, Line 31: laptop_ok > Can we start this chain by moving this to `g_laptop_ok`. […] I am not sure I follow, this commit was to make dmi functional and rename the residual remaining, hard to remove, global's with a `g_` prefix to avoid symbol shadowing. I think you maybe reading the intent in reverse and are asking to first rename all occurrences to `g_` and rebase this on top? But that would just make this patch largely a revert of that. -- To view, visit https://review.coreboot.org/c/flashrom/+/71622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d5ad6c0623269492d775a99a947fd6fe26c5f91 Gerrit-Change-Number: 71622 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 09 Mar 2023 11:03:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: pcidev: remove pcidev_getdevfn() function
by Anastasia Klimchuk (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73570 ) Change subject: pcidev: remove pcidev_getdevfn() function ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73570 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2983420080f75ae6992edfb032bf5c83b29c803 Gerrit-Change-Number: 73570 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:26:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Jean THOMAS for DirtyJTAG
by Anastasia Klimchuk (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Felix Singer, Jean THOMAS. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73552 ) Change subject: MAINTAINERS: Add Jean THOMAS for DirtyJTAG ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS1: > Yes, it seems like I messed up ^^ This time it is (really) fixed! Welcome to flashrom community! -- To view, visit https://review.coreboot.org/c/flashrom/+/73552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0d45b9c634dd6f7509e366723e7fe727f0d087cd Gerrit-Change-Number: 73552 Gerrit-PatchSet: 3 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:23:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: pcidev: remove pcidev_getdevfn() function
by Thomas Heijligen (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73570 ) Change subject: pcidev: remove pcidev_getdevfn() function ...................................................................... Patch Set 2: (1 comment) File board_enable.c: https://review.coreboot.org/c/flashrom/+/73570/comment/c238cd2e_a2ab1241 PS1, Line 1098: dev > Can `pci_get_dev` return null? previous version was checking for null. I've moved the `pci_fill_info()` under the `if(!dev)` block. This has now the same effect to `pci_fill_info()` as in the code before. -- To view, visit https://review.coreboot.org/c/flashrom/+/73570 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2983420080f75ae6992edfb032bf5c83b29c803 Gerrit-Change-Number: 73570 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 08 Mar 2023 23:15:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: pcidev: remove pcidev_getdevfn() function
by Thomas Heijligen (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73570 to look at the new patch set (#2). Change subject: pcidev: remove pcidev_getdevfn() function ...................................................................... pcidev: remove pcidev_getdevfn() function This function is only called once. Move the content of the function into the caller. Change-Id: Id2983420080f75ae6992edfb032bf5c83b29c803 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M board_enable.c M include/programmer.h M pcidev.c 3 files changed, 15 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/73570/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73570 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2983420080f75ae6992edfb032bf5c83b29c803 Gerrit-Change-Number: 73570 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Thomas Heijligen (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Edward O'Callaghan, Piotr Halama, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 ) Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... Patch Set 2: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/73513/comment/77b20026_ee962d55 PS2, Line 3533: . > It seems like the same chip is sold with multiple names, since page 13 of [BH25D80](https://datashee […] Ack, thanks for catching. Can you rename the `.model_id` to `BOYA_BOHONG_B__25D80A`. This is done at multiple locations is flashchips.h -- To view, visit https://review.coreboot.org/c/flashrom/+/73513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 2 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 08 Mar 2023 23:06:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: linux_mtd.c: Factor out detection phases from setup func
by Thomas Heijligen (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73495 ) Change subject: linux_mtd.c: Factor out detection phases from setup func ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can you split this chain in independent ones? It is quite hard to keep track of every change in it. -- To view, visit https://review.coreboot.org/c/flashrom/+/73495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I15915b71e1a030548c5f082cde78c42ece28bb37 Gerrit-Change-Number: 73495 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 08 Mar 2023 22:57:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: board_enable.c: Drop Intel D201GLY entry for wbsio_spi drv
by Thomas Heijligen (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72863 ) Change subject: board_enable.c: Drop Intel D201GLY entry for wbsio_spi drv ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I keep this open until the follow up are fixed. -- To view, visit https://review.coreboot.org/c/flashrom/+/72863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iab1e28c61ecb5a03c68cb935191ed494edf9bb28 Gerrit-Change-Number: 72863 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 08 Mar 2023 22:41:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: board_enable.c: Consistent board_flash_enable() nullarity checks
by Thomas Heijligen (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73454 ) Change subject: board_enable.c: Consistent board_flash_enable() nullarity checks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id28b8b70d9ecc9f69a1b61684500d9c6023ca045 Gerrit-Change-Number: 73454 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 08 Mar 2023 22:40:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Peter Marheine (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Piotr Halama. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 ) Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... Patch Set 2: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/73513/comment/a2dfc4f0_bc3308a9 PS2, Line 3533: . > Why the dot? […] It seems like the same chip is sold with multiple names, since page 13 of [BH25D80](https://datasheet.lcsc.com/lcsc/2007011107_HUAHONG-BH25D80ASOIG_C6… lists the same IDs as page 12 of [BY25D80](https://datasheet.lcsc.com/lcsc/1912111437_BOYAMICRO-BY25D80ASTIG-…. -- To view, visit https://review.coreboot.org/c/flashrom/+/73513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 2 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Comment-Date: Wed, 08 Mar 2023 22:38:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit