- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: layout.c: Mitigate untrusted FMAP's within fw images address root
by Nico Huber (Code Review) 15 May '23

15 May '23

Attention is currently required from: Stefan Reinauer, Edward O'Callaghan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75194 ) Change subject: layout.c: Mitigate untrusted FMAP's within fw images address root ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75194/comment/84873ffd_a98aebd3 PS1, Line 14: parsing untrusted data with a privilaged process But what is considered privileged? For a regular user running flashrom, relative paths can already do a lot of damage. https://review.coreboot.org/c/flashrom/+/75194/comment/3064add2_f8aa47cc PS1, Line 15: unless you require : the internal programmer in which case the internal image is : implicitly trusted. Unless you have something like vboot (or similar) which treats A/B partitions as untrusted. https://review.coreboot.org/c/flashrom/+/75194/comment/9a474bf2_2edae7cc PS1, Line 21: Feel free to add a Found-by: line. File layout.c: https://review.coreboot.org/c/flashrom/+/75194/comment/0bdbcf66_447b2a8a PS1, Line 199: filename[0] == '\\' If this is meant to secure DOS/Windows paths, you'd also have to check for "[a-zA-Z]:", I suppose. -- To view, visit https://review.coreboot.org/c/flashrom/+/75194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I820ea2dfc25925895b9fb7926d2a337e4f0e3fd2 Gerrit-Change-Number: 75194 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 15 May 2023 11:34:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: cli_classic: wrap options validation in function
by Anastasia Klimchuk (Code Review) 15 May '23

15 May '23

Attention is currently required from: Edward O'Callaghan, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66531 ) Change subject: cli_classic: wrap options validation in function ...................................................................... Patch Set 6: (2 comments) Patchset: PS5: > I've provided a list of commands that I used to test this patch. […] Looks great, thank you so much! File cli_classic.c: https://review.coreboot.org/c/flashrom/+/66531/comment/3abe74eb_4fe0e4c3 PS6, Line 827: if (options->logfile[0] == '\0') { : cli_classic_abort_usage("No log filename specified.\n"); Please tell me what I am missing: where is this check now? I don't see it in `validate_options` ? -- To view, visit https://review.coreboot.org/c/flashrom/+/66531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib5685eb5ee3810ef2efd40a3901340e2ceb229ff Gerrit-Change-Number: 66531 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 15 May 2023 11:07:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: doc: Add info about Discord channel
by Anastasia Klimchuk (Code Review) 15 May '23

15 May '23

Attention is currently required from: Thomas Heijligen, Angel Pons, Nicholas Chin. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75192 ) Change subject: doc: Add info about Discord channel ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > +1 Thomas, but makefile was also there forever :P This case is even simpler because I am obviously not deleting anything. From my observations, it is pretty hard to get people to hang out in irc continuously, and mostly because it is not easy to use as a tool. Discord is much easier to use (by modern standards). And I think especially our developers community is losing quite a lot because of that, we can benefit a lot from having a real-time channel which gathers active developers. And where is easy to leave, re-join, and read the history of what happened without you. We don't have a large dev community, but maybe 10-20 active or a little active people - and most of them are not on IRC. For the users perspective, I think it's a good feature if you can join "users & troubleshooting" channel and search the history, because maybe your question was asked before. Discord allows creating sub-channels, if needed (there is one #flashrom currently, but more can be created if needed). Returning back to comparison with makefile and meson, it is a good comparison because it shows that the right tool is not necessarily the one which was there forever. I think real time chat room is equally important for dev community. And as I said, I am not deleting anything. Thank you for reading my message, as you see I have an opinion about this subject! Please tell me what you think. -- To view, visit https://review.coreboot.org/c/flashrom/+/75192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide57b8d04bd805cf42e402a79653e0b051a477da Gerrit-Change-Number: 75192 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 15 May 2023 10:30:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: Set minimum required version for libjaylink
by Angel Pons (Code Review) 15 May '23

15 May '23

Attention is currently required from: Thomas Heijligen, Chen, Anastasia Klimchuk, Alexander Goncharov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75193 ) Change subject: meson: Set minimum required version for libjaylink ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I31b37256fc2c3c12b43eeda60e6cb2718f1fef02 Gerrit-Change-Number: 75193 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 15 May 2023 09:45:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: Set minimum required version for libjaylink
by Anastasia Klimchuk (Code Review) 15 May '23

15 May '23

Attention is currently required from: Thomas Heijligen, Chen, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75193 ) Change subject: meson: Set minimum required version for libjaylink ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75193/comment/d3e21148_7be8ca6f PS2, Line 9: This is needed after > Commit <> requires `jaylink_jtag_set_tms()`. This function is introduces at libjaylink version 0.3. […] Done File meson.build: https://review.coreboot.org/c/flashrom/+/75193/comment/31a1a4e6_6c389c0c PS2, Line 150: >=0.3 > >=0.3. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I31b37256fc2c3c12b43eeda60e6cb2718f1fef02 Gerrit-Change-Number: 75193 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 15 May 2023 09:41:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: Set minimum required version for libjaylink
by Anastasia Klimchuk (Code Review) 15 May '23

15 May '23

Attention is currently required from: Chen, Anastasia Klimchuk, Alexander Goncharov. Hello build bot (Jenkins), Thomas Heijligen, Chen, Angel Pons, Alexander Goncharov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75193 to look at the new patch set (#3). Change subject: meson: Set minimum required version for libjaylink ...................................................................... meson: Set minimum required version for libjaylink commit 592c1c3e5fd9ae42a261966c82ddd83f777ce2b6 requires `jaylink_jtag_set_tms()`. This function has been introduced at libjaylink version 0.3.0. Check the version before compiling. Change-Id: I31b37256fc2c3c12b43eeda60e6cb2718f1fef02 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M meson.build 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/75193/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/75193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I31b37256fc2c3c12b43eeda60e6cb2718f1fef02 Gerrit-Change-Number: 75193 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: layout.c: Mitigate untrusted FMAP's within fw images address root
by Angel Pons (Code Review) 15 May '23

15 May '23

Attention is currently required from: Stefan Reinauer, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75194 ) Change subject: layout.c: Mitigate untrusted FMAP's within fw images address root ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75194/comment/0d5e8184_5dd9f2b3 PS1, Line 9: elivated elevated https://review.coreboot.org/c/flashrom/+/75194/comment/4c77d48b_f90f7d4e PS1, Line 9: privilaged privileged https://review.coreboot.org/c/flashrom/+/75194/comment/194c39eb_9df7383f PS1, Line 13: relative paths however this Add some punctuation: > relative paths. However, this https://review.coreboot.org/c/flashrom/+/75194/comment/64454b60_6b22d57b PS1, Line 14: privilaged privileged -- To view, visit https://review.coreboot.org/c/flashrom/+/75194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I820ea2dfc25925895b9fb7926d2a337e4f0e3fd2 Gerrit-Change-Number: 75194 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 15 May 2023 09:30:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add Windows MSYS2 build instructions
by Angel Pons (Code Review) 15 May '23

15 May '23

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75189 ) Change subject: doc: Add Windows MSYS2 build instructions ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/75189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I847428535547242ff32af92c4fe8477241826814 Gerrit-Change-Number: 75189 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 15 May 2023 09:26:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson.build: enable serial programmer on Windows
by Angel Pons (Code Review) 15 May '23

15 May '23

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75170 ) Change subject: meson.build: enable serial programmer on Windows ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie60a25a9305374f9ed84a38f2650d517ec094387 Gerrit-Change-Number: 75170 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 15 May 2023 09:26:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: doc: Add info about Discord channel
by Angel Pons (Code Review) 15 May '23

15 May '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Nicholas Chin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75192 ) Change subject: doc: Add info about Discord channel ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I would prefer to switch the order of Discord and IRC, since Discord is the new one and IRC was ther […] +1 -- To view, visit https://review.coreboot.org/c/flashrom/+/75192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide57b8d04bd805cf42e402a79653e0b051a477da Gerrit-Change-Number: 75192 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 15 May 2023 09:25:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit