- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: tree/: Convert unlock func ptr into enumerate values
by Anastasia Klimchuk (Code Review) 18 Mar '23

18 Mar '23

Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69933 ) Change subject: tree/: Convert unlock func ptr into enumerate values ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie5c5db1b09d07e1a549990d6f5a622fae4c83233 Gerrit-Change-Number: 69933 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 18 Mar 2023 09:03:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Convert build documentation to sphinx
by Alexander Goncharov (Code Review) 18 Mar '23

18 Mar '23

Attention is currently required from: Thomas Heijligen, Stefan Reinauer. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 ) Change subject: doc: Convert build documentation to sphinx ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/73359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324 Gerrit-Change-Number: 73359 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Mar 2023 15:39:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ch341a_spi: Refactor singleton states into reentrant pattern
by Alexander Goncharov (Code Review) 18 Mar '23

18 Mar '23

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72807 ) Change subject: ch341a_spi: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 6: (18 comments) Patchset: PS5: > I added many cleanups you can do as a follow up patch to make type usage consistent, const correct a […] Thank you! I've marked them as resolved, because they are not the part of this patch. File ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/72807/comment/a6b5aaf3_5d5b2b72 PS3, Line 80: struct libusb_transfer *transfer_out; : struct libusb_transfer *transfer_ins[USB_IN_TRANSFERS]; : : /* Accumulate delays to be plucked between CS deassertion and CS assertions. */ : unsigned int stored_delay_us; : : struct libusb_device_handle *handle; > I recommend putting the handle at the start of the struct so that overflows in the above transfer bu […] Done https://review.coreboot.org/c/flashrom/+/72807/comment/07b8e673_ff953ee0 PS3, Line 100: i = 0 > `size_t i = 0;` Ack https://review.coreboot.org/c/flashrom/+/72807/comment/f28af886_3524c81f PS3, Line 234: unsigned int i; > delete Ack https://review.coreboot.org/c/flashrom/+/72807/comment/95d8801e_e2e4370c PS3, Line 235: i > probably should be `size_t i = 0;` Ack https://review.coreboot.org/c/flashrom/+/72807/comment/f012149e_b35157d2 PS3, Line 268: uint8_t > `const`? Ack https://review.coreboot.org/c/flashrom/+/72807/comment/2348ed18_a852ce3a PS3, Line 311: stored_delay_us > `delay_us` Ack https://review.coreboot.org/c/flashrom/+/72807/comment/a8428fe6_ea553959 PS3, Line 315: int > `unsigned int` ? Ack https://review.coreboot.org/c/flashrom/+/72807/comment/214eadc1_8ab5fa95 PS3, Line 323: i = 0 > `unsigned int i = 0;` Ack https://review.coreboot.org/c/flashrom/+/72807/comment/49b9779b_1b4bb053 PS3, Line 365: nsigned int p; > delete Ack https://review.coreboot.org/c/flashrom/+/72807/comment/036b14e2_bd057526 PS3, Line 366: p > actually should be `size_t p = 0;` Ack https://review.coreboot.org/c/flashrom/+/72807/comment/b1ffb19c_81525f9f PS3, Line 387: i > `unsigned int i` Ack https://review.coreboot.org/c/flashrom/+/72807/comment/c40887bd_8d95b5db PS3, Line 419: 4 * 1024 > `4*KiB` in another patch? Ack https://review.coreboot.org/c/flashrom/+/72807/comment/c26c0007_5b7fae82 PS3, Line 460: ret != 0 > `ret`, C will auto-cast to make the predicate boolean. Ack https://review.coreboot.org/c/flashrom/+/72807/comment/5a641500_337db69b PS3, Line 465: (ret != 0) > `(ret)` is canonical. Ack https://review.coreboot.org/c/flashrom/+/72807/comment/112c2e12_ca8c4316 PS3, Line 495: i > `int i` in another patch? Ack https://review.coreboot.org/c/flashrom/+/72807/comment/71ae74ff_96a80eca PS3, Line 504: i = 0 > ditto Ack https://review.coreboot.org/c/flashrom/+/72807/comment/6519b07c_5138c0df PS3, Line 513: i = 0 > ditto Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/72807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fe72bff88b7f8778c1199bdab8ba43bf32e1c8c Gerrit-Change-Number: 72807 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 17 Mar 2023 15:32:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ch341a_spi: Refactor singleton states into reentrant pattern
by Alexander Goncharov (Code Review) 18 Mar '23

18 Mar '23

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72807 to look at the new patch set (#6). Change subject: ch341a_spi: Refactor singleton states into reentrant pattern ...................................................................... ch341a_spi: Refactor singleton states into reentrant pattern Move global singleton states into a struct and store within the spi_master data field for the life-time of the driver. This patchset also includes stdlib.h to be able to work with memory allocation. Pass programmer's data as a parameter to functions that need it. This is one of the steps on the way to move spi_master data memory management behind the initialisation API, for more context see other patches under the same topic specified below. TOPIC=register_master_api TEST=Tested on flash W25Q128JVSQ flashrom -E # Result: success flashrom -v ff.bin # Result: verified flashrom -w firmware.bin # Result: success flashrom -v firmware.bin # Result: verified Change-Id: I9fe72bff88b7f8778c1199bdab8ba43bf32e1c8c Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Ticket: https://ticket.coreboot.org/issues/391 --- M ch341a_spi.c 1 file changed, 113 insertions(+), 78 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/72807/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/72807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fe72bff88b7f8778c1199bdab8ba43bf32e1c8c Gerrit-Change-Number: 72807 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashrom: rewrite flashbuses_to_text()
by Alexander Goncharov (Code Review) 18 Mar '23

18 Mar '23

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73039 ) Change subject: flashrom: rewrite flashbuses_to_text() ...................................................................... Patch Set 5: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/73039/comment/e66d9746_9e9ed568 PS5, Line 948: if (bustype & (1 << i)) > why this condition is needed? This condition checks if a specific bus is enabled (`bustype` is a bit flag variable). Instead of using constants from `enum chipbustype` (because we cannot do it in the loop), use the same bit shifting technique: ``` enum chipbustype { BUS_NONE = 0, BUS_PARALLEL = 1 << 0, BUS_LPC = 1 << 1, BUS_FWH = 1 << 2, BUS_SPI = 1 << 3, BUS_PROG = 1 << 4, BUS_NONSPI = BUS_PARALLEL | BUS_LPC | BUS_FWH, }; ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/73039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I59b9044c99b4ba6c00d8c97f1e91af09d70dce2c Gerrit-Change-Number: 73039 Gerrit-PatchSet: 5 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 17 Mar 2023 15:24:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Revert "pcidev: remove pcidev_getdevfn() function"
by Anastasia Klimchuk (Code Review) 17 Mar '23

17 Mar '23

Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73730 ) Change subject: Revert "pcidev: remove pcidev_getdevfn() function" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cd2f54cb6a6e35dc353476e0f5e502cbbd06cba Gerrit-Change-Number: 73730 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 11:25:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Convert build documentation to sphinx
by Anastasia Klimchuk (Code Review) 17 Mar '23

17 Mar '23

Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 ) Change subject: doc: Convert build documentation to sphinx ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324 Gerrit-Change-Number: 73359 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 17 Mar 2023 11:08:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tests: Add wrap for __fstat50 to fix tests for NetBSD
by Anastasia Klimchuk (Code Review) 17 Mar '23

17 Mar '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/73649 ) Change subject: tests: Add wrap for __fstat50 to fix tests for NetBSD ...................................................................... tests: Add wrap for __fstat50 to fix tests for NetBSD Tested by running unit tests on NetBSD 9.2 Ubuntu 22.04.1 (still pass) Change-Id: Icb8e453328cb40ab9d628f01ecdc3886a233dad5 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/73649 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Tested-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M tests/meson.build M tests/tests.c M tests/wraps.h 3 files changed, 27 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Verified; Looks good to me, approved Peter Marheine: Looks good to me, but someone else must approve diff --git a/tests/meson.build b/tests/meson.build index 2de4ee8..df866d7 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -60,6 +60,7 @@ '-Wl,--wrap=__xstat64', '-Wl,--wrap=fstat', '-Wl,--wrap=fstat64', + '-Wl,--wrap=__fstat50', '-Wl,--wrap=__fxstat', '-Wl,--wrap=__fxstat64', '-Wl,--wrap=fileno', diff --git a/tests/tests.c b/tests/tests.c index 911cf47..d296a98 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -229,6 +229,12 @@ return 0; } +int __wrap___fstat50(int fd, void *buf) +{ + LOG_ME; + return 0; +} + int __wrap___fxstat(int fd, void *buf) { LOG_ME; diff --git a/tests/wraps.h b/tests/wraps.h index 6cc9567..089d992 100644 --- a/tests/wraps.h +++ b/tests/wraps.h @@ -46,6 +46,7 @@ int __wrap___xstat64(const char *path, void *buf); int __wrap_fstat(int fd, void *buf); int __wrap_fstat64(int fd, void *buf); +int __wrap___fstat50(int fd, void *buf); int __wrap___fxstat(int fd, void *buf); int __wrap___fxstat64(int fd, void *buf); char *__wrap_fgets(char *buf, int len, FILE *fp); -- To view, visit https://review.coreboot.org/c/flashrom/+/73649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icb8e453328cb40ab9d628f01ecdc3886a233dad5 Gerrit-Change-Number: 73649 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in flashrom[master]: doc: Convert build documentation to sphinx
by Thomas Heijligen (Code Review) 17 Mar '23

17 Mar '23

Attention is currently required from: Stefan Reinauer, Anastasia Klimchuk, Alexander Goncharov. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 ) Change subject: doc: Convert build documentation to sphinx ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/73359/comment/8d1ed0b6_7ac56386 PS5, Line 7: Add build instructions > Convert build documentation to sphinx Done https://review.coreboot.org/c/flashrom/+/73359/comment/9c76e091_3ae4ec21 PS5, Line 9: Those > These Done https://review.coreboot.org/c/flashrom/+/73359/comment/8c4e7fa3_6d07f301 PS5, Line 11: The `.. todo::` sections are non essential parts that will complete or : improve the documentation. Either the content is not yet there or the : sphinx-plugins to generate or improve them musst be first written. > There are some `.. todo::` sections still present in the documentation. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/73359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324 Gerrit-Change-Number: 73359 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 16 Mar 2023 22:32:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB controller flashing
by Thomas Heijligen (Code Review) 16 Mar '23

16 Mar '23

Attention is currently required from: Christopher Lentocha. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB controller flashing ...................................................................... Patch Set 25: Verified-1 (1 comment) Patchset: PS25: I mark this temporary as verified -1 until the programmer is truly working. -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 25 Gerrit-Owner: Christopher Lentocha <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Christopher Lentocha <christopherericlentocha(a)gmail.com> Gerrit-Comment-Date: Wed, 15 Mar 2023 20:04:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit