- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: programmer: Use correct type for flashbase
by Edward O'Callaghan (Code Review) 22 May '23

22 May '23

Attention is currently required from: Nico Huber, Edward O'Callaghan, Martin Roth. Hello build bot (Jenkins), Martin Roth, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75328 to look at the new patch set (#2). Change subject: programmer: Use correct type for flashbase ...................................................................... programmer: Use correct type for flashbase The flashbase is a machine-sized integer representation of address space and so use the appropriate type that is correctly sized to encode such data. The flashbase is assigned to 'base' in 'map_flash()' and the type correctly changed to uintptr_t in commit 4e32ec19b124a7 therefore makes for a consistent type usage whenever stored. While `sizeof(unsigned long)` and `sizeof(uintptr_t)` are both `8` under most circumstances on a 64bit platform and thus have enough bits to represent all addresses on the platform, the C standard does not guarantee this. Only `uintptr_t` and `void *` has a guaranteed isomorphism as `uintptr_t` is defined by the platforms toolchain support whereas the conversion from `void *` to an integer is implementation defined and that the memory address value may contain additional bits describing the validation data or provenance of the address. Therefore a integer is insufficient to contain all the necessary information for that specific platform so this may not always work out for all platforms and toolchain combinations. Spotted-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Change-Id: Ib9057e438731b9cccde0e24d5c8f758c3af1d47f Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/programmer.h 2 files changed, 34 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/28/75328/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9057e438731b9cccde0e24d5c8f758c3af1d47f Gerrit-Change-Number: 75328 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: erasure_layout: Simplify include paths
by Anastasia Klimchuk (Code Review) 22 May '23

22 May '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75322 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: erasure_layout: Simplify include paths ...................................................................... erasure_layout: Simplify include paths Header files can be found without explicitly specifying include directory on the file path. Change-Id: I6ef34273d088d8fb4559fe3d801d1247ad9b3fa2 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75322 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Aarya <aarya.chaumal(a)gmail.com> --- M erasure_layout.c 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Aarya: Looks good to me, approved diff --git a/erasure_layout.c b/erasure_layout.c index 108fea4..c9ac44b 100644 --- a/erasure_layout.c +++ b/erasure_layout.c @@ -20,9 +20,9 @@ #include <limits.h> #include <string.h> -#include "include/flash.h" -#include "include/layout.h" -#include "include/erasure_layout.h" +#include "flash.h" +#include "layout.h" +#include "erasure_layout.h" static size_t calculate_block_count(const struct flashchip *chip, size_t eraser_idx) { -- To view, visit https://review.coreboot.org/c/flashrom/+/75322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ef34273d088d8fb4559fe3d801d1247ad9b3fa2 Gerrit-Change-Number: 75322 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: erasure_layout: Simplify include paths
by Anastasia Klimchuk (Code Review) 22 May '23

22 May '23

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75322 ) Change subject: erasure_layout: Simplify include paths ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/75322/comment/4994b8f8_924803bc PS1, Line 7: Remove unnecessary includes > This sounds like you're removing lines. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ef34273d088d8fb4559fe3d801d1247ad9b3fa2 Gerrit-Change-Number: 75322 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 22 May 2023 00:46:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: erasure_layout: Simplify include paths
by Anastasia Klimchuk (Code Review) 22 May '23

22 May '23

Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), Angel Pons, Aarya, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75322 to look at the new patch set (#2). Change subject: erasure_layout: Simplify include paths ...................................................................... erasure_layout: Simplify include paths Header files can be found without explicitly specifying include directory on the file path. Change-Id: I6ef34273d088d8fb4559fe3d801d1247ad9b3fa2 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M erasure_layout.c 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/75322/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ef34273d088d8fb4559fe3d801d1247ad9b3fa2 Gerrit-Change-Number: 75322 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: chipset_enable.c: Drop `_LARGEFILE64_SOURCE`
by Anastasia Klimchuk (Code Review) 22 May '23

22 May '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75271 ) Change subject: chipset_enable.c: Drop `_LARGEFILE64_SOURCE` ...................................................................... chipset_enable.c: Drop `_LARGEFILE64_SOURCE` This file does not access any large files, so there's no need to define this feature test macro. Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75271 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Alexander Goncharov <chat(a)joursoir.net> --- M chipset_enable.c 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved Alexander Goncharov: Looks good to me, approved diff --git a/chipset_enable.c b/chipset_enable.c index 9d3df5f..3846ecf 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -24,8 +24,6 @@ * Contains the chipset specific flash enables. */ -#define _LARGEFILE64_SOURCE - #include <stdbool.h> #include <stdlib.h> #include <string.h> -- To view, visit https://review.coreboot.org/c/flashrom/+/75271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4 Gerrit-Change-Number: 75271 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in flashrom[master]: README: Extract instructions for meson and make into separate docs
by Peter Marheine (Code Review) 22 May '23

22 May '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75125 ) Change subject: README: Extract instructions for meson and make into separate docs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d5900538d54c43efcc8c5b7010df5d867f3b190 Gerrit-Change-Number: 75125 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 22 May 2023 00:38:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add Windows MSYS2 build instructions
by Peter Marheine (Code Review) 22 May '23

22 May '23

Attention is currently required from: Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75189 ) Change subject: doc: Add Windows MSYS2 build instructions ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I847428535547242ff32af92c4fe8477241826814 Gerrit-Change-Number: 75189 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 21 May 2023 23:56:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable.c: Drop `_LARGEFILE64_SOURCE`
by Alexander Goncharov (Code Review) 20 May '23

20 May '23

Attention is currently required from: Thomas Heijligen, Angel Pons. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75271 ) Change subject: chipset_enable.c: Drop `_LARGEFILE64_SOURCE` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4 Gerrit-Change-Number: 75271 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 20 May 2023 16:28:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom: rename sb600spi.c to amd_spi.c
by Anastasia Klimchuk (Code Review) 20 May '23

20 May '23

Attention is currently required from: Nico Huber, Martin L Roth, Thomas Heijligen, Angel Pons, Arthur Heymans, Martin Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74952 ) Change subject: flashrom: rename sb600spi.c to amd_spi.c ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > I wasn't aware of the amd_spi100.c plan when I did this though. […] Martin, I apologise, you can ignore previous comment. See also CB:75328 -- To view, visit https://review.coreboot.org/c/flashrom/+/74952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13859de27e602cc6496684e6cb66b2dc2e21531a Gerrit-Change-Number: 74952 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Sat, 20 May 2023 13:47:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: programmer: Use correct type for flashbase
by Anastasia Klimchuk (Code Review) 20 May '23

20 May '23

Attention is currently required from: Nico Huber, Edward O'Callaghan, Martin Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75328 ) Change subject: programmer: Use correct type for flashbase ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I asked a question, AFAICT. Nico, I just banned you from flashrom Gerrit and the mailing list (or at least I tried, to the best of my knowledge of configs). I will post on flashrom mailing list explaining what I have done and why. Now you can fully focus on your fork (aka flashrom-stable). We had some time when we were working together, and we did a good collaboration. And you helped me in the beginning, I remember that. But observing the events of the previous 3 years, I made the conclusion that you are destructive to the flashrom dev community, and the only way to go is to ban you. Good bye. -- To view, visit https://review.coreboot.org/c/flashrom/+/75328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9057e438731b9cccde0e24d5c8f758c3af1d47f Gerrit-Change-Number: 75328 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Sat, 20 May 2023 13:46:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit