Attention is currently required from: Joseph C. Lehner.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57410?usp=email )
Change subject: flashchips: add Macronix MX25L3255E
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Joseph, if you are reading this, I am so sorry your patch got missed and was waiting for years! Thank you for your contribution!
I updated it to the latest format of flashchip definition, and rebased on the latest head.
--
To view, visit https://review.coreboot.org/c/flashrom/+/57410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9
Gerrit-Change-Number: 57410
Gerrit-PatchSet: 3
Gerrit-Owner: Joseph C. Lehner
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Joseph C. Lehner
Gerrit-Comment-Date: Thu, 17 Aug 2023 12:51:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Joseph C. Lehner.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57410?usp=email )
Change subject: flashchips: add Macronix MX25L3255E
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57410/comment/93a03536_dc3ad7ce :
PS1, Line 7: flashchips: add Macronix MX25L3255E
> How did you test it? Which programmer did you use?
Done
https://review.coreboot.org/c/flashrom/+/57410/comment/51575d6b_5ce81fc2 :
PS1, Line 8:
> Please add a link to the datasheet.
Done
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/57410/comment/85de4bc6_ec3d2707 :
PS1, Line 508: #define MACRONIX_MX25L3255E 0x9e16
> Please put it after MACRONIX_MX25L6495F.
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/57410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9
Gerrit-Change-Number: 57410
Gerrit-PatchSet: 3
Gerrit-Owner: Joseph C. Lehner
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Joseph C. Lehner
Gerrit-Comment-Date: Thu, 17 Aug 2023 12:45:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Joseph C. Lehner.
Anastasia Klimchuk has uploaded a new patch set (#3) to the change originally created by Joseph C. Lehner. ( https://review.coreboot.org/c/flashrom/+/57410?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: flashchips: add Macronix MX25L3255E
......................................................................
flashchips: add Macronix MX25L3255E
Tested using the linux_spi programmer on a Raspberry Pi.
Datasheet:
https://media.digikey.com/pdf/Data%20Sheets/Macronix/MX25L3255E.pdf
Signed-off-by: Joseph C. Lehner <joseph.c.lehner(a)gmail.com>
Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M flashchips.c
M include/flashchips.h
2 files changed, 41 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/57410/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/57410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9
Gerrit-Change-Number: 57410
Gerrit-PatchSet: 3
Gerrit-Owner: Joseph C. Lehner
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Joseph C. Lehner
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Thomas Heijligen.
Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77250?usp=email )
Change subject: doc: Add flashrom logo to index page
......................................................................
doc: Add flashrom logo to index page
Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M doc/index.rst
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/77250/1
diff --git a/doc/index.rst b/doc/index.rst
index cc58183..512f180 100644
--- a/doc/index.rst
+++ b/doc/index.rst
@@ -3,6 +3,9 @@
You can adapt this file completely to your liking, but it should at least
contain the root `toctree` directive.
+.. image:: logo/flashrom_icon_color.svg
+ :alt: flashrom logo
+
.. toctree::
:hidden:
--
To view, visit https://review.coreboot.org/c/flashrom/+/77250?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75
Gerrit-Change-Number: 77250
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newchange
Attention is currently required from: Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77273?usp=email )
Change subject: MAINTAINERS: Add Stefan to flashchips
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/77273/comment/fbe84a51_5a226d74 :
PS1, Line 7: Add Stefan to flashchips
We decided in the very beginning, to also put last name into commit title, so that commit title is fully self-descriptive (easy to read history for the file)
"Add Stefan Reinauer to flashchips"
Patchset:
PS1:
Thank you!
(just commit message comment)
--
To view, visit https://review.coreboot.org/c/flashrom/+/77273?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581
Gerrit-Change-Number: 77273
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Thu, 17 Aug 2023 07:20:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alexander Goncharov, Brian Norris, Edward O'Callaghan.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75991?usp=email )
Change subject: flashrom: only perform WP unlock for write/erase operations
......................................................................
Patch Set 4:
(3 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/75991/comment/906b1c82_b854acfd :
PS3, Line 2056: const bool read_it
> not used, drop it
Done
https://review.coreboot.org/c/flashrom/+/75991/comment/a91dc70f_6baa17b1 :
PS3, Line 2057: const bool verify_it
> not used, drop it
Done
https://review.coreboot.org/c/flashrom/+/75991/comment/b6d2f976_9961555a :
PS3, Line 2060: int ret = 0;
> if ret were initialized as `-1` there would be no need for `ret = -1` in if branches.
Setting the return code in each error branch is more idiomatic for C code IMO.
Ideally each error block would just be `return <error code>;` but since we do a `goto ...` instead, keeping the assignment to ret at least indicates that we want to return a particular value at that point.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75991?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1
Gerrit-Change-Number: 75991
Gerrit-PatchSet: 4
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Attention: Brian Norris <briannorris(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Wed, 16 Aug 2023 10:40:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: comment
Attention is currently required from: Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77205?usp=email )
Change subject: MAINTAINERS: Add Nikolai Artemiev for flashchips
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/77205?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iba4ae742f6500ef26edfc976d842ede656b916d4
Gerrit-Change-Number: 77205
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Tue, 15 Aug 2023 06:31:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment