Attention is currently required from: Bart De Schuymer, Peter Marheine, Thomas Heijligen.
Hello Peter Marheine, Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/77288?usp=email
to look at the new patch set (#2).
Change subject: Makefile: Remove a bashism when searching for sphinx-build
......................................................................
Makefile: Remove a bashism when searching for sphinx-build
e.g. when the shell is dash and sphinx-build is not installed, HAS_SPHINXBUILD would be wrongly set to yes.
Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2
Signed-off-by: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/77288/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2
Gerrit-Change-Number: 77288
Gerrit-PatchSet: 2
Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Anton Samsonov.
Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77043?usp=email )
Change subject: Remove dependency on C23's __has_include()
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> Anton, I understand you made another patch CB:77089 as a replacement. You can abandon this patch.
I guest there must be an option for that, however I do not see such a button — perhaps because I can only login here using a different authentication provider. The best I can do is to delete the files in changeset.
--
To view, visit https://review.coreboot.org/c/flashrom/+/77043?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifaeb46127785af86e69852152783f75d241b1266
Gerrit-Change-Number: 77043
Gerrit-PatchSet: 2
Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com>
Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru>
Gerrit-Comment-Date: Mon, 21 Aug 2023 12:47:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Anton Samsonov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77043?usp=email )
Change subject: Remove dependency on C23's __has_include()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Anton, I understand you made another patch CB:77089 as a replacement. You can abandon this patch.
--
To view, visit https://review.coreboot.org/c/flashrom/+/77043?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifaeb46127785af86e69852152783f75d241b1266
Gerrit-Change-Number: 77043
Gerrit-PatchSet: 1
Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru>
Gerrit-Comment-Date: Mon, 21 Aug 2023 11:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bart De Schuymer, Peter Marheine, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email )
Change subject: Makefile: Remove a bashism when searching for sphinx-build
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/77288/comment/425a37ca_e51d5401 :
PS1, Line 9: wongly
wrongly (typo)
--
To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2
Gerrit-Change-Number: 77288
Gerrit-PatchSet: 1
Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Comment-Date: Mon, 21 Aug 2023 11:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77273?usp=email )
Change subject: MAINTAINERS: Add Stefan Reinauer to flashchips
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/77273?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581
Gerrit-Change-Number: 77273
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Mon, 21 Aug 2023 02:11:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer.
Hello Anastasia Klimchuk, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/77273?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by Anastasia Klimchuk, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: MAINTAINERS: Add Stefan Reinauer to flashchips
......................................................................
MAINTAINERS: Add Stefan Reinauer to flashchips
Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
M MAINTAINERS
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/77273/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/77273?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581
Gerrit-Change-Number: 77273
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77292?usp=email )
Change subject: doc: Add Emergency help red box to the intro
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/77292?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id7570b7f0773ec0e43662272e642bc807c8210c2
Gerrit-Change-Number: 77292
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Sun, 20 Aug 2023 22:08:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Joseph C. Lehner.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57410?usp=email )
Change subject: flashchips: add Macronix MX25L3255E
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/57410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9
Gerrit-Change-Number: 57410
Gerrit-PatchSet: 3
Gerrit-Owner: Joseph C. Lehner
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Joseph C. Lehner
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sun, 20 Aug 2023 00:29:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77293?usp=email )
Change subject: doc: Fix nesting of About flashrom group of menu items
......................................................................
doc: Fix nesting of About flashrom group of menu items
Adding the title to About flashrom index page allows the engine
to recognise it as a group with a list of menu items inside, which
is as expected.
Without the title on the index page, all menu items inside About
flashrom are inlined into the menu.
Change-Id: I595acc282a536a6d5fa26cf2f8d18dbe549f9716
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M doc/about_flashrom/index.rst
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/77293/1
diff --git a/doc/about_flashrom/index.rst b/doc/about_flashrom/index.rst
index 11d845f..de36fc2 100644
--- a/doc/about_flashrom/index.rst
+++ b/doc/about_flashrom/index.rst
@@ -1,3 +1,6 @@
+About flashrom
+==============
+
.. toctree::
:maxdepth: 1
--
To view, visit https://review.coreboot.org/c/flashrom/+/77293?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I595acc282a536a6d5fa26cf2f8d18dbe549f9716
Gerrit-Change-Number: 77293
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newchange