- flashrom-gerrit - mail.coreboot.org

[XL] Change in flashrom[main]: Abandon Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad
by Angel Pons (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Anton Samsonov, Anton Samsonov, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79156?usp=email ) Change subject: Abandon Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I only see "Edit" button, that's all. Huh, that's weird. Anyway, will abandon this one for you. I replied on CB:79152 on how to get Jenkins to re-run. -- To view, visit https://review.coreboot.org/c/flashrom/+/79156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad Gerrit-Change-Number: 79156 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Comment-Date: Tue, 21 Nov 2023 12:28:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Abandon (Unable to trick Jenkins to re-check after adding Signed-off-...
by Angel Pons (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Anton Samsonov, Anton Samsonov, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email ) Change subject: Abandon (Unable to trick Jenkins to re-check after adding Signed-off-by) Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: To have Jenkins re-check, you can change something in the code. File Makefile: https://review.coreboot.org/c/flashrom/+/79152/comment/f8be7cd3_d39869f5 : PS2, Line 395: ifneq ($(VERSION_GIT),) > > Does this work properly when `VERSION_GIT` is not defined? […] Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/79152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Gerrit-Change-Number: 79152 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Comment-Date: Tue, 21 Nov 2023 12:27:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: Remove dependency on C23 __has_include()
by Anton Samsonov (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen. Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77089?usp=email ) Change subject: Remove dependency on C23 __has_include() ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > add testing info in commit message. Lacking relevant examples in git log, I can only add something like this: Tested with <getopt.h> and <pci/pci.h> using GNU Make 4.1, 4.2.1, 4.4.1 and Meson 0.56.0, 1.2.1 against GCC 13.2.1 and GCC 5.5-, 7.3-compatible (EDG 4.14-, 5.1-based) on openSuSE Tumbleweed and custom LFS distribution. Do you think such information is really worth to be included in the log? -- To view, visit https://review.coreboot.org/c/flashrom/+/77089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6 Gerrit-Change-Number: 77089 Gerrit-PatchSet: 4 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-CC: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Tue, 21 Nov 2023 12:12:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Abandon (Unable to trick Jenkins to re-check after adding Signed-off-...
by Anton Samsonov (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Angel Pons, Anton Samsonov, Thomas Heijligen. Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email ) Change subject: Abandon (Unable to trick Jenkins to re-check after adding Signed-off-by) Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed ...................................................................... Patch Set 3: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/79152/comment/61318b51_81d72eb6 : PS2, Line 395: ifneq ($(VERSION_GIT),) > Does this work properly when `VERSION_GIT` is not defined? The neat part is that `VERSION_GIT` is *always* defined, according to GNU Make syntax: Note that ifdef only tests whether a variable has a value. It does not expand the variable to see if that value is nonempty. Consequently, tests using ifdef return true for all definitions except those like foo =. To test for an empty value, use ifeq ($(foo),). -- To view, visit https://review.coreboot.org/c/flashrom/+/79152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Gerrit-Change-Number: 79152 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Tue, 21 Nov 2023 11:50:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Abandon (Unable to trick Jenkins to re-check after adding Signed-off-...
by Anton Samsonov (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Anton Samsonov, Thomas Heijligen. Anton Samsonov has uploaded a new patch set (#3) to the change originally created by Anton Samsonov. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email ) Change subject: Abandon (Unable to trick Jenkins to re-check after adding Signed-off-by) Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed ...................................................................... Abandon (Unable to trick Jenkins to re-check after adding Signed-off-by) Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed --- M Makefile 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/79152/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/79152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Gerrit-Change-Number: 79152 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[main]: Abandon Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad
by Anton Samsonov (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Angel Pons, Anton Samsonov, Thomas Heijligen. Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79156?usp=email ) Change subject: Abandon Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > You can abandon this change yourself by clicking the "Abandon" button on the top right corner. I only see "Edit" button, that's all. -- To view, visit https://review.coreboot.org/c/flashrom/+/79156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad Gerrit-Change-Number: 79156 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Tue, 21 Nov 2023 11:28:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Makefile: Fix version string for non-Git builds
by Angel Pons (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Anton Samsonov, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email ) Change subject: Makefile: Fix version string for non-Git builds ...................................................................... Patch Set 2: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/79152/comment/d7eed972_8759ba85 : PS2, Line 395: ifneq ($(VERSION_GIT),) Does this work properly when `VERSION_GIT` is not defined? -- To view, visit https://review.coreboot.org/c/flashrom/+/79152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Gerrit-Change-Number: 79152 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Tue, 21 Nov 2023 11:24:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[main]: Abandon Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad
by Angel Pons (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Anton Samsonov, Anton Samsonov, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79156?usp=email ) Change subject: Abandon Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: You can abandon this change yourself by clicking the "Abandon" button on the top right corner. -- To view, visit https://review.coreboot.org/c/flashrom/+/79156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad Gerrit-Change-Number: 79156 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Comment-Date: Tue, 21 Nov 2023 11:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Makefile: Fix version string for non-Git builds
by Anton Samsonov (Code Review) 21 Nov '23

21 Nov '23

Anton Samsonov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/79156?usp=email ) Change subject: Makefile: Fix version string for non-Git builds ...................................................................... Makefile: Fix version string for non-Git builds Dummy change to make Jenkins verify the build again after adding Signed-off-by. Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/79156/1 diff --git a/Makefile b/Makefile index 08ace29..5d2b540 100644 --- a/Makefile +++ b/Makefile @@ -392,6 +392,7 @@ VERSION ?= $(shell cat ./VERSION) VERSION_GIT ?= $(shell git describe 2>/dev/null) +# Dummy change to make Jenkins verify the build again after adding Signed-off-by. ifneq ($(VERSION_GIT),) VERSION := "$(VERSION) (git:$(VERSION_GIT))" else -- To view, visit https://review.coreboot.org/c/flashrom/+/79156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5d4e4f1fe72b22c9f31073b02c9b8f40cf2a45ad Gerrit-Change-Number: 79156 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[main]: Makefile: Fix version string for non-Git builds
by Anton Samsonov (Code Review) 20 Nov '23

20 Nov '23

Attention is currently required from: Anton Samsonov, Thomas Heijligen. Hello Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/79152?usp=email to look at the new patch set (#2). Change subject: Makefile: Fix version string for non-Git builds ...................................................................... Makefile: Fix version string for non-Git builds Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M Makefile 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/79152/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/79152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Gerrit-Change-Number: 79152 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit