- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: layout: Add a function to check if numeric range is included
by build bot (Jenkins) (Code Review) 14 Jul '17

14 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20569 ) Change subject: layout: Add a function to check if numeric range is included ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/470/ : SUCCESS -- To view, visit https://review.coreboot.org/20569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Gerrit-Change-Number: 20569 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 14 Jul 2017 04:31:50 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: layout: Add a function to check if numeric range is included
by David Hendricks (Code Review) 14 Jul '17

14 Jul '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20569 to look at the new patch set (#2). Change subject: layout: Add a function to check if numeric range is included ...................................................................... layout: Add a function to check if numeric range is included This adds a helper function to iterate thru ranges to check if a specified numeric range is marked as included in the layout. If no include -i arguments were used to specify included regions, then any range will return true. Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M layout.c M layout.h 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/20569/2 -- To view, visit https://review.coreboot.org/20569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Gerrit-Change-Number: 20569 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: ichspi: Check if region is included before disabling writes
by David Hendricks (Code Review) 14 Jul '17

14 Jul '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/20570 ) Change subject: ichspi: Check if region is included before disabling writes ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Uploaded for convenience for now, needs a bit more work. https://review.coreboot.org/#/c/20570/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/20570/1//COMMIT_MSG@9 PS1, Line 9: which are not restricted Verification needs to be taken into account: - If any region is read-locked, then --noverify-all must be used. (There was brief discussion of enabling --noverify-all by default for the ME region case, since that's a given). - The region specified must not be read locked if --noverify-all is used, since "write-only" is a valid permission. -- To view, visit https://review.coreboot.org/20570 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I8d5156954b88dbb3058194ab3f351aaf88ea6d8f Gerrit-Change-Number: 20570 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 14 Jul 2017 04:31:09 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: layout: Add a function to check if numeric range is included
by build bot (Jenkins) (Code Review) 14 Jul '17

14 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20569 ) Change subject: layout: Add a function to check if numeric range is included ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/439/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/468/ : SUCCESS -- To view, visit https://review.coreboot.org/20569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Gerrit-Change-Number: 20569 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 14 Jul 2017 04:26:56 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ichspi: Check if region is included before disabling writes
by build bot (Jenkins) (Code Review) 14 Jul '17

14 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20570 ) Change subject: ichspi: Check if region is included before disabling writes ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/440/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/469/ : SUCCESS -- To view, visit https://review.coreboot.org/20570 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I8d5156954b88dbb3058194ab3f351aaf88ea6d8f Gerrit-Change-Number: 20570 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 14 Jul 2017 04:26:55 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ichspi: Check if region is included before disabling writes
by David Hendricks (Code Review) 14 Jul '17

14 Jul '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/20570 Change subject: ichspi: Check if region is included before disabling writes ...................................................................... ichspi: Check if region is included before disabling writes If the user only includes regions to write which are not restricted, then they should not need to specify ich_spi_force=yes. Change-Id: I8d5156954b88dbb3058194ab3f351aaf88ea6d8f Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M ichspi.c 1 file changed, 25 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/20570/1 diff --git a/ichspi.c b/ichspi.c index f26a7c0..6f1faae 100644 --- a/ichspi.c +++ b/ichspi.c @@ -32,6 +32,7 @@ #include "hwaccess.h" #include "spi.h" #include "ich_descriptors.h" +#include "layout.h" /* Sunrise Point */ @@ -1817,8 +1818,30 @@ msg_pdbg("BRRA 0x%02x\n", ICH_BRRA(tmp)); /* Handle FREGx and FRAP registers */ - for (i = 0; i < num_freg; i++) - ich_spi_rw_restricted |= ich9_handle_frap(tmp, i); + for (i = 0; i < num_freg; i++) { + int offset; + uint32_t freg, base, limit; + + offset = ICH9_REG_FREG0 + i * 4; + freg = mmio_readl(ich_spibar + offset); + base = ICH_FREG_BASE(freg); + limit = ICH_FREG_LIMIT(freg); + + if (range_is_included(base, limit)) { + int is_locked = ich9_handle_frap(tmp, i); + + msg_pspew("Region %07x:%07x is included and ", base, limit); + if (is_locked) { + msg_pspew("locked.\n"); + ich_spi_rw_restricted = 1; + } else { + msg_pspew("not locked.\n"); + } + } else { + msg_pspew("Region %07x:%07x is not included, ignoring " + "access permission.\n", base, limit); + } + } if (ich_spi_rw_restricted) msg_pwarn("Not all flash regions are freely accessible by flashrom. This is " "most likely\ndue to an active ME. Please see " -- To view, visit https://review.coreboot.org/20570 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I8d5156954b88dbb3058194ab3f351aaf88ea6d8f Gerrit-Change-Number: 20570 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: layout: Add a function to check if numeric range is included
by David Hendricks (Code Review) 14 Jul '17

14 Jul '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/20569 Change subject: layout: Add a function to check if numeric range is included ...................................................................... layout: Add a function to check if numeric range is included This adds a helper function to iterate thru ranges to check if a specified numeric range is marked as included in the layout. If no include -i arguments were used to specify included regions, then all any range will return true. Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M layout.c M layout.h 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/20569/1 diff --git a/layout.c b/layout.c index 9bf0b03..a35a72c 100644 --- a/layout.c +++ b/layout.c @@ -225,3 +225,27 @@ return ret; } + +/* returns 1 if any offset within [base, base+len) is included in layout */ +int range_is_included(chipoff_t start, chipoff_t end) +{ + int i; + + if (num_include_args == 0) + return 1; + + for (i = 0; i < layout.num_entries; i++) { + struct romentry entry = layout.entries[i]; + + if (!entry.included) + continue; + if (end < entry.start) + continue; + if (start > entry.end) + continue; + + return 1; + } + + return 0; +} diff --git a/layout.h b/layout.h index c93d754..6fc4e2e 100644 --- a/layout.h +++ b/layout.h @@ -66,4 +66,6 @@ int process_include_args(struct flashrom_layout *); +int range_is_included(chipoff_t start, chipoff_t end); + #endif /* !__LAYOUT_H__ */ -- To view, visit https://review.coreboot.org/20569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Gerrit-Change-Number: 20569 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: ichspi: Add support for Intel Skylake
by David Hendricks (Code Review) 14 Jul '17

14 Jul '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/18962 ) Change subject: ichspi: Add support for Intel Skylake ...................................................................... Patch Set 9: Let's go with a comment, then. `17-16` still isn't obvious since the reader still needs to look at how it's used in the code and find an older datasheet to infer what is happening. As an example: /* HSFC and HSFS 16-bit registers are combined into the 32-bit BIOS_HSFSTS_CTL register in the Sunrise Point datasheet, however we still treat them separately in order to re-use code. */ This also has the advantage of being searchable, in case somebody wants to grep for BIOS_HSFSTS_CTL to see how it's used. -- To view, visit https://review.coreboot.org/18962 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I0f4565a3c39f5fe3aec4fc8863605cebed1ad4ee Gerrit-Change-Number: 18962 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 14 Jul 2017 04:22:11 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ich_descriptors: Pretty print an assumed chipset
by David Hendricks (Code Review) 14 Jul '17

14 Jul '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/20247 ) Change subject: ich_descriptors: Pretty print an assumed chipset ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/20247 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id28cb3abc45c6e7f4c4accfc019579c7448c45d7 Gerrit-Change-Number: 20247 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 14 Jul 2017 00:05:09 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: chipset_enable: Set 100 series chipsets to NT
by David Hendricks (Code Review) 14 Jul '17

14 Jul '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/19047 ) Change subject: chipset_enable: Set 100 series chipsets to NT ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/19047 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I9376a0c180b7e73751fbd3c8c37b693d358cbfb8 Gerrit-Change-Number: 19047 Gerrit-PatchSet: 8 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 14 Jul 2017 00:03:42 +0000 Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit