Change in flashrom[staging]: ichspi: Check if region is included before disabling writes

[David Hendricks (Code Review)]

      David Hendricks has posted comments on this change. ( https://review.coreboot.org/20570 )

Change subject: ichspi: Check if region is included before disabling writes
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Uploaded for convenience for now, needs a bit more work.

https://review.coreboot.org/#/c/20570/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/20570/1//COMMIT_MSG@9
PS1, Line 9: which are not restricted
Verification needs to be taken into account:
- If any region is read-locked, then --noverify-all must be used. (There was brief
discussion of enabling --noverify-all by default for the ME region case, since that's
a given).

- The region specified must not be read locked if --noverify-all is used, since
"write-only" is a valid permission.



-- 
To view, visit https://review.coreboot.org/20570
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d5156954b88dbb3058194ab3f351aaf88ea6d8f
Gerrit-Change-Number: 20570
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com&gt;
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com&gt;
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org&gt;
Gerrit-Comment-Date: Fri, 14 Jul 2017 04:31:09 +0000
Gerrit-HasComments: Yes