- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: linux_spi: Dynamically detect max buffer size
by Anonymous Coward (Code Review) 05 Nov '17

05 Nov '17

david.hendricks(a)gmail.com has posted comments on this change. ( https://review.coreboot.org/22344 ) Change subject: linux_spi: Dynamically detect max buffer size ...................................................................... Patch Set 1: (4 comments) https://review.coreboot.org/#/c/22344/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22344/1//COMMIT_MSG@9 PS1, Line 9: The max buffer size of the linux kernel's SPI device is a compile-time parameter. : Read it on initialization and use it to inform the max transfer size. We allow : up to 5 bytes for the SPI command. On master, SPI commands are always 4 bytes, : but 4ba support will raise that to 5. Choosing 5 makes sure this will keep long lines https://review.coreboot.org/#/c/22344/1//COMMIT_MSG@12 PS1, Line 12: but 4ba support will raise that to 5. Choosing 5 makes sure this will keep : working when 4ba support is merged. 4BA has been merged, so I updated the wording here. https://review.coreboot.org/#/c/22344/1/linux_spi.c File linux_spi.c: https://review.coreboot.org/#/c/22344/1/linux_spi.c@138 PS1, Line 138: atoi(buf); Updated to use strtol() and add some paranoid error checking. https://review.coreboot.org/#/c/22344/1/linux_spi.c@141 PS1, Line 141: if (param_fd != -1) : close(param_fd); May as well put this in the else clause above. -- To view, visit https://review.coreboot.org/22344 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Gerrit-Change-Number: 22344 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: david.hendricks(a)gmail.com Gerrit-Comment-Date: Sun, 05 Nov 2017 04:12:19 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: linux_spi: Dynamically detect max buffer size
by build bot (Jenkins) (Code Review) 05 Nov '17

05 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22344 ) Change subject: linux_spi: Dynamically detect max buffer size ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/826/ : SUCCESS -- To view, visit https://review.coreboot.org/22344 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Gerrit-Change-Number: 22344 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 05 Nov 2017 04:10:12 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: linux_spi: Dynamically detect max buffer size
by Anonymous Coward (Code Review) 05 Nov '17

05 Nov '17

david.hendricks(a)gmail.com has uploaded a new patch set (#3) to the change originally created by David Hendricks. ( https://review.coreboot.org/22344 ) Change subject: linux_spi: Dynamically detect max buffer size ...................................................................... linux_spi: Dynamically detect max buffer size The max buffer size of the linux kernel's SPI device is a compile-time parameter. Read it on initialization and use it to inform the max transfer size. Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Signed-off-by: Keno Fischer <keno(a)juliacomputing.com> Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M linux_spi.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/22344/3 -- To view, visit https://review.coreboot.org/22344 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Gerrit-Change-Number: 22344 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: linux_spi: Dynamically detect max buffer size
by build bot (Jenkins) (Code Review) 05 Nov '17

05 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22344 ) Change subject: linux_spi: Dynamically detect max buffer size ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/825/ : SUCCESS -- To view, visit https://review.coreboot.org/22344 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Gerrit-Change-Number: 22344 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 05 Nov 2017 04:06:56 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: linux_spi: Dynamically detect max buffer size
by David Hendricks (Code Review) 05 Nov '17

05 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22344 to look at the new patch set (#2). Change subject: linux_spi: Dynamically detect max buffer size ...................................................................... linux_spi: Dynamically detect max buffer size The max buffer size of the linux kernel's SPI device is a compile-time parameter. Read it on initialization and use it to inform the max transfer size. We allow up to 5 bytes for the SPI command. SPI commands can be up to 5 bytes when using 4BA. Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Signed-off-by: Keno Fischer <keno(a)juliacomputing.com> --- M linux_spi.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/22344/2 -- To view, visit https://review.coreboot.org/22344 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Gerrit-Change-Number: 22344 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: linux_spi: Dynamically detect max buffer size
by build bot (Jenkins) (Code Review) 05 Nov '17

05 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22344 ) Change subject: linux_spi: Dynamically detect max buffer size ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/723/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/824/ : SUCCESS -- To view, visit https://review.coreboot.org/22344 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Gerrit-Change-Number: 22344 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 05 Nov 2017 03:15:34 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: linux_spi: Dynamically detect max buffer size
by David Hendricks (Code Review) 05 Nov '17

05 Nov '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/22344 Change subject: linux_spi: Dynamically detect max buffer size ...................................................................... linux_spi: Dynamically detect max buffer size The max buffer size of the linux kernel's SPI device is a compile-time parameter. Read it on initialization and use it to inform the max transfer size. We allow up to 5 bytes for the SPI command. On master, SPI commands are always 4 bytes, but 4ba support will raise that to 5. Choosing 5 makes sure this will keep working when 4ba support is merged. Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Signed-off-by: Keno Fischer <keno(a)juliacomputing.com> --- M linux_spi.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/22344/1 diff --git a/linux_spi.c b/linux_spi.c index e51fbc4..f7d9434 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -42,6 +42,7 @@ */ static int fd = -1; +static size_t max_kernel_buf_size = 4096; static int linux_spi_shutdown(void *data); static int linux_spi_send_command(struct flashctx *flash, unsigned int writecnt, @@ -127,6 +128,19 @@ return 1; } + /* Try to read the kernel's max bufsize */ + char buf[10]; + memset(buf, 0, sizeof(buf)); + int param_fd = open("/sys/module/spidev/parameters/bufsiz", O_RDONLY); + if (param_fd == -1 || read(param_fd, &buf, sizeof(buf) - 1) == -1) { + msg_pwarn("%s: failed to retrieve kernel buffer size. Attempting to use default.\n", __func__); + } else { + max_kernel_buf_size = atoi(buf); + } + + if (param_fd != -1) + close(param_fd); + register_spi_master(&spi_master_linux); return 0; @@ -182,14 +196,16 @@ static int linux_spi_read(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len) { + /* The size of the command and the buffer may add up to no more than max_kernel_buf_size. + At the moment the command size is at most 5 bytes, so allow the rest for the buffer. */ return spi_read_chunked(flash, buf, start, len, - (unsigned int)getpagesize()); + max_kernel_buf_size - 5); } static int linux_spi_write_256(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len) { return spi_write_chunked(flash, buf, start, len, - ((unsigned int)getpagesize()) - 4); + max_kernel_buf_size - 5); } #endif // CONFIG_LINUX_SPI == 1 -- To view, visit https://review.coreboot.org/22344 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: Ic541e548ced8488f074d388f1c92174cad123064 Gerrit-Change-Number: 22344 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: ichspi: Disable software sequencing by default for Skylake
by David Hendricks (Code Review) 05 Nov '17

05 Nov '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22274 ) Change subject: ichspi: Disable software sequencing by default for Skylake ...................................................................... Patch Set 1: Code-Review+2 (1 comment) The Lewisburg datasheet seems to indicate that SCGO is RW, and I'm not aware of any C62x variants where that use a different datasheet. So I think we're safe there. However, I haven't tested swseq on Lewisburg since, as you suggested, I don't have one with an unlocked/non-zero opmenu at the moment. Flashrom sees the missing opcodes and falls back to hwseq on my test system. https://review.coreboot.org/#/c/22274/1/ichspi.c File ichspi.c: https://review.coreboot.org/#/c/22274/1/ichspi.c@1957 PS1, Line 1957: } Would it make sense to move this to line 1800, closer to where ich_spi_mode gets set (near the beginning of case CHIPSET_ICH8)? -- To view, visit https://review.coreboot.org/22274 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I8a13fb9c3ca679b3f7d39ad1dc56d5efdc80045b Gerrit-Change-Number: 22274 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 05 Nov 2017 01:51:34 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[refs/meta/config]: Allow only "flashrom developers" to submit (on all branches).
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22338 ) Change subject: Allow only "flashrom developers" to submit (on all branches). ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/flashrom_gerrit/722/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/823/ : SUCCESS -- To view, visit https://review.coreboot.org/22338 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: I8dfc594c60292d03a36854f592c540e052c09c03 Gerrit-Change-Number: 22338 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 16:26:46 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: Allow only "flashrom developers" to submit (on all branches).
by Nico Huber (Code Review) 04 Nov '17

04 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22338 to look at the new patch set (#2). Change subject: Allow only "flashrom developers" to submit (on all branches). ...................................................................... Allow only "flashrom developers" to submit (on all branches). Change-Id: I8dfc594c60292d03a36854f592c540e052c09c03 --- M project.config 1 file changed, 2 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/22338/2 -- To view, visit https://review.coreboot.org/22338 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8dfc594c60292d03a36854f592c540e052c09c03 Gerrit-Change-Number: 22338 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit