- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Convert flashrom to git
by David Hendricks (Code Review) 22 Jun '17

22 Jun '17

Hello Stefan Tauner, david.hendricks(a)gmail.com, Philippe Mathieu-Daudé, Paul Menzel, build bot (Jenkins), Nico Huber, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19206 to look at the new patch set (#8). Change subject: Convert flashrom to git ...................................................................... Convert flashrom to git - Drop support for Subversion in the getrevision script and Makefile. - Add .gitignore and .gitattributes file (the latter to limit exports). - Restore modification dates of the exported files from the SCM. - Stop exporting SCM log dumps to CHANGELOG. This makes no sense. - Do not export the pre-"compiled" manpage. It can be generated like anything else from the code dump when we export the respective variable. The latter is added with this change. - Add some initial client-side git hooks * When committing check for obvious stuff you never want anyway: - white space errors * When pushing to the upstream repository check mandatory rules: - existing signoffs and acks in all new commits - no deletions or creation of branches - do not rewrite history of the precious branches, even if forced NOTE: This patch is adapted from Stefan Tauner's original commit: https://mail.coreboot.org/pipermail/flashrom/2016-November/014877.html There are a few major differences: - This uses coreboot's commit-msg hook which includes support for generating and appending Change-Id. - djgpp-dos target removal is moved to a follow-up patch. - Version string changes are moved to a follow-up patch. Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2 Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- A .gitattributes A .gitignore M Makefile M flashrom.c M util/getrevision.sh A util/git-hooks/applypatch-msg A util/git-hooks/commit-msg A util/git-hooks/install.sh A util/git-hooks/pre-applypatch A util/git-hooks/pre-commit A util/git-hooks/pre-push A util/git-hooks/wrapper.sh 12 files changed, 404 insertions(+), 123 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/19206/8 -- To view, visit https://review.coreboot.org/19206 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2 Gerrit-Change-Number: 19206 Gerrit-PatchSet: 8 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: david.hendricks(a)gmail.com

1 0

Change in flashrom[staging]: Enable writes with active ME
by David Hendricks (Code Review) 22 Jun '17

22 Jun '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/18740 ) Change subject: Enable writes with active ME ...................................................................... Patch Set 15: I agree with the "enable `--noverify-all` automatically and report that" approach. -- To view, visit https://review.coreboot.org/18740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Gerrit-Change-Number: 18740 Gerrit-PatchSet: 15 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Jun 2017 05:22:15 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Remove djgpp-dos target
by Stefan Reinauer (Code Review) 21 Jun '17

21 Jun '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/20293 ) Change subject: Remove djgpp-dos target ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/20293 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ia582b4cf622e670f1af439095ff58d62554232aa Gerrit-Change-Number: 20293 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Jun 2017 18:15:59 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: [NFM] Convert flashrom to git
by Patrick Georgi (Code Review) 21 Jun '17

21 Jun '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/18812 ) Change subject: [NFM] Convert flashrom to git ...................................................................... Patch Set 3: mail test -- To view, visit https://review.coreboot.org/18812 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I49e4cca56938b9f945de2ccd2d0a4ec6acdb0a30 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Jun 2017 15:38:16 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Convert flashrom to git
by Nico Huber (Code Review) 21 Jun '17

21 Jun '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19206 ) Change subject: Convert flashrom to git ...................................................................... Patch Set 7: (3 comments) So close, but the missing `fi`... Also, it looks like your comments about made changes are not in sync with the current patch set (see inline `?`). https://review.coreboot.org/#/c/19206/6//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/19206/6//COMMIT_MSG@15 PS6, Line 15: The latter is added with this change. > Done ? https://review.coreboot.org/#/c/19206/6/util/getrevision.sh File util/getrevision.sh: https://review.coreboot.org/#/c/19206/6/util/getrevision.sh@140 PS6, Line 140: return ${EXIT_FAILURE} : fi : : echo "${r}" : } : : is_t > Done. I also took the liberty of reducing the indent level of this function ? https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push File util/git-hooks/pre-push: https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push@48 PS6, Line 48: commit=$(git rev-list -n 1 --all-match --invert-grep -E \ `fi` lost? -- To view, visit https://review.coreboot.org/19206 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2 Gerrit-Change-Number: 19206 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: david.hendricks(a)gmail.com Gerrit-Comment-Date: Wed, 21 Jun 2017 12:33:38 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Convert flashrom to git
by build bot (Jenkins) (Code Review) 21 Jun '17

21 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19206 ) Change subject: Convert flashrom to git ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/388/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/408/ : SUCCESS -- To view, visit https://review.coreboot.org/19206 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2 Gerrit-Change-Number: 19206 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: david.hendricks(a)gmail.com Gerrit-Comment-Date: Wed, 21 Jun 2017 07:04:58 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Convert flashrom to git
by David Hendricks (Code Review) 21 Jun '17

21 Jun '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/19206 ) Change subject: Convert flashrom to git ...................................................................... Patch Set 6: (9 comments) https://review.coreboot.org/#/c/19206/6//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/19206/6//COMMIT_MSG@13 PS6, Line 13: - Remove djgpp-dos target (it is not different to other x-compilations). > I was just wondering, why I didn't nag earlier, you can keep Moved the change to another patch: https://review.coreboot.org/20293 https://review.coreboot.org/#/c/19206/6//COMMIT_MSG@15 PS6, Line 15: anything else from the code dump when we export the respective variable. > Nit, line is too long. Done https://review.coreboot.org/#/c/19206/6//COMMIT_MSG@26 PS6, Line 26: f5dd7ce1 > This sha will probably get lost. Linking to the mailing list It's actually the hash from the stable branch: https://review.coreboot.org/cgit/flashrom.git/commit/?id=f5dd7ce11b65ffd6ea… I guess the mailing list is the definitive source for this kind of stuff though, so I'll link to https://mail.coreboot.org/pipermail/flashrom/2016-November/014877.html instead. For newer patches we can use flashrom-gerrit (https://mail.coreboot.org/pipermail/flashrom-gerrit/) to cite the source of such patches. https://review.coreboot.org/#/c/19206/6//COMMIT_MSG@28 PS6, Line 28: pushing to the review server. > Maybe also mention, that you split out the complex version Done https://review.coreboot.org/#/c/19206/6/util/getrevision.sh File util/getrevision.sh: https://review.coreboot.org/#/c/19206/6/util/getrevision.sh@1 PS6, Line 1: #!/bin/sh We should probably either make this #!/bin/bash or remove local variables. That would be for another patch, though. https://review.coreboot.org/#/c/19206/6/util/getrevision.sh@59 PS6, Line 59: and git-svn branches/tags removed the bit about git-svn https://review.coreboot.org/#/c/19206/6/util/getrevision.sh@140 PS6, Line 140: local svn_base=$(git log --grep=git-svn-id -1 --format='%h') : if [ "$svn_base" != "" ] ; then : local diff_to_svn=$(git rev-list --count ${svn_base}..${r}) : if [ "$diff_to_svn" -gt 0 ] ; then : r="$r-$diff_to_svn" : fi : fi > Looks like we don't have git-svn-id any more. A simple `git describe Done. I also took the liberty of reducing the indent level of this function by exiting earlier if the file isn't tracked. https://review.coreboot.org/#/c/19206/6/util/getrevision.sh@168 PS6, Line 168: sed 's/.*@/r/;s/[[:blank:]].*//') > Same here, maybe just drop the --upstream command? SGTM. It is a bit of a UI change, but AFAICT --upstream just returns "unknown" now so it's useless and isn't used by anything anyway. https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push File util/git-hooks/pre-push: https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push@46 PS6, Line 46: else : range="$remote_sha..$local_sha" > Nit, actually I don't like the `else` here, it's not directly Yep, good point. Done. -- To view, visit https://review.coreboot.org/19206 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2 Gerrit-Change-Number: 19206 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: david.hendricks(a)gmail.com Gerrit-Comment-Date: Wed, 21 Jun 2017 07:04:03 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Remove djgpp-dos target
by build bot (Jenkins) (Code Review) 21 Jun '17

21 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20293 ) Change subject: Remove djgpp-dos target ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/389/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/409/ : SUCCESS -- To view, visit https://review.coreboot.org/20293 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ia582b4cf622e670f1af439095ff58d62554232aa Gerrit-Change-Number: 20293 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Jun 2017 07:03:41 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Remove djgpp-dos target
by David Hendricks (Code Review) 21 Jun '17

21 Jun '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/20293 Change subject: Remove djgpp-dos target ...................................................................... Remove djgpp-dos target It is not different to other x-compilations. Change-Id: Ia582b4cf622e670f1af439095ff58d62554232aa Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- M Makefile 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/20293/1 diff --git a/Makefile b/Makefile index cf3cfe8..44aa24c 100644 --- a/Makefile +++ b/Makefile @@ -1405,9 +1405,6 @@ @rm -rf "$(EXPORTDIR)/flashrom-$(RELEASENAME)" @echo Created "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.gz" -djgpp-dos: clean - make CC=i586-pc-msdosdjgpp-gcc STRIP=i586-pc-msdosdjgpp-strip - libpayload: clean make CC="CC=i386-elf-gcc lpgcc" AR=i386-elf-ar RANLIB=i386-elf-ranlib -- To view, visit https://review.coreboot.org/20293 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: Ia582b4cf622e670f1af439095ff58d62554232aa Gerrit-Change-Number: 20293 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: Convert flashrom to git
by David Hendricks (Code Review) 21 Jun '17

21 Jun '17

Hello Stefan Tauner, david.hendricks(a)gmail.com, Philippe Mathieu-Daudé, Paul Menzel, build bot (Jenkins), Nico Huber, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19206 to look at the new patch set (#7). Change subject: Convert flashrom to git ...................................................................... Convert flashrom to git - Drop support for Subversion in the getrevision script and Makefile. - Add .gitignore and .gitattributes file (the latter to limit exports). - Restore modification dates of the exported files from the SCM. - Stop exporting SCM log dumps to CHANGELOG. This makes no sense. - Do not export the pre-"compiled" manpage. It can be generated like anything else from the code dump when we export the respective variable. The latter is added with this change. - Add some initial client-side git hooks * When committing check for obvious stuff you never want anyway: - white space errors * When pushing to the upstream repository check mandatory rules: - existing signoffs and acks in all new commits - no deletions or creation of branches - do not rewrite history of the precious branches, even if forced NOTE: This patch is adapted from Stefan Tauner's original commit: https://mail.coreboot.org/pipermail/flashrom/2016-November/014877.html There are a few major differences: - This uses coreboot's commit-msg hook which includes support for generating and appending Change-Id. - djgpp-dos target removal is moved to a follow-up patch. - Version string changes are moved to a follow-up patch. Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2 Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- A .gitattributes A .gitignore M Makefile M flashrom.c M util/getrevision.sh A util/git-hooks/applypatch-msg A util/git-hooks/commit-msg A util/git-hooks/install.sh A util/git-hooks/pre-applypatch A util/git-hooks/pre-commit A util/git-hooks/pre-push A util/git-hooks/wrapper.sh 12 files changed, 403 insertions(+), 123 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/19206/7 -- To view, visit https://review.coreboot.org/19206 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2 Gerrit-Change-Number: 19206 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: david.hendricks(a)gmail.com

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit