Nico Huber has posted comments on this change. ( https://review.coreboot.org/19206 )
Change subject: Convert flashrom to git
......................................................................
Patch Set 8: Code-Review+2
\o/
I'll try to find some time to do some tests on my own. You can hit
the button whenever you like, ofc.
--
To view, visit https://review.coreboot.org/19206
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2
Gerrit-Change-Number: 19206
Gerrit-PatchSet: 8
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: david.hendricks(a)gmail.com
Gerrit-Comment-Date: Thu, 22 Jun 2017 10:22:23 +0000
Gerrit-HasComments: No
David Hendricks has posted comments on this change. ( https://review.coreboot.org/19615 )
Change subject: Add probe_dummy for chips that are not practical to probe
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19615
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I327400e337d6ce600c4f0f165f328715f5b341e2
Gerrit-Change-Number: 19615
Gerrit-PatchSet: 1
Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 22 Jun 2017 06:23:58 +0000
Gerrit-HasComments: No
David Hendricks has posted comments on this change. ( https://review.coreboot.org/19391 )
Change subject: udelay: Use clock_gettime() if available and precise
......................................................................
Patch Set 4: Code-Review+2
Yes, please!
--
To view, visit https://review.coreboot.org/19391
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I85ad359823875237ada9cd027af3017d62e9a235
Gerrit-Change-Number: 19391
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 22 Jun 2017 05:55:02 +0000
Gerrit-HasComments: No
David Hendricks has posted comments on this change. ( https://review.coreboot.org/19206 )
Change subject: Convert flashrom to git
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/19206/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/19206/6//COMMIT_MSG@15
PS6, Line 15: variable.
> ?
Argh... Should be fixed now.
https://review.coreboot.org/#/c/19206/6/util/getrevision.sh
File util/getrevision.sh:
https://review.coreboot.org/#/c/19206/6/util/getrevision.sh@140
PS6, Line 140: return ${EXIT_FAILURE}
: fi
:
: echo "${r}"
: }
:
: is_t
> ?
Nevermind that last part. I had made some other changes while working on this patch but reverted them to avoid unnecessary diffs. I was thinking that the outer if could be inverted to simplify the logic a bit, but this if-else block is now simple enough.
https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push
File util/git-hooks/pre-push:
https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push@48
PS6, Line 48: # Check for Signed-off-by and Acked-by
> `fi` lost?
D'oh! Amazing that it worked at all. Fixed.
--
To view, visit https://review.coreboot.org/19206
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2
Gerrit-Change-Number: 19206
Gerrit-PatchSet: 8
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: david.hendricks(a)gmail.com
Gerrit-Comment-Date: Thu, 22 Jun 2017 05:43:49 +0000
Gerrit-HasComments: Yes