- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: do not stop probing for flashchips after map_flash() failed
by build bot (Jenkins) (Code Review) 04 Dec '17

04 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22685 ) Change subject: do not stop probing for flashchips after map_flash() failed ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/797/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/910/ : SUCCESS -- To view, visit https://review.coreboot.org/22685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaecfb6d30a5152c8c4b5d2804efacac85fc615f9 Gerrit-Change-Number: 22685 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Dec 2017 00:37:01 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: do not stop probing for flashchips after map_flash() failed
by David Hendricks (Code Review) 04 Dec '17

04 Dec '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/22685 Change subject: do not stop probing for flashchips after map_flash() failed ...................................................................... do not stop probing for flashchips after map_flash() failed Instead, continue probing the next chip. This fixes the problem that flashrom aborts probing for flashchips if one big flashchip (e.g. 32M/64M) can't be mapped because of activated CONFIG_STRICT_DEVMEM kernel option. Change-Id: Iaecfb6d30a5152c8c4b5d2804efacac85fc615f9 Signed-off-by: Martin Schiller <ms(a)dev.tdt.de> --- M flashrom.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/22685/1 diff --git a/flashrom.c b/flashrom.c index 4fe1843..12d7390 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1224,7 +1224,7 @@ flash->mst = mst; if (map_flash(flash) != 0) - return -1; + goto notfound; /* We handle a forced match like a real match, we just avoid probing. Note that probe_flash() * is only called with force=1 after normal probing failed. -- To view, visit https://review.coreboot.org/22685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaecfb6d30a5152c8c4b5d2804efacac85fc615f9 Gerrit-Change-Number: 22685 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: internal: Fix warnings about unused constants
by Patrick Rudolph (Code Review) 04 Dec '17

04 Dec '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22669 ) Change subject: internal: Fix warnings about unused constants ...................................................................... Patch Set 1: Code-Review+2 Tested on raspberry pi. It now compiles without error. -- To view, visit https://review.coreboot.org/22669 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b6d7c0c2fadc4faeab971673bfadb1a6d25919 Gerrit-Change-Number: 22669 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Dec 2017 14:35:58 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: internal: Only build on x86 and mipsel
by Patrick Rudolph (Code Review) 04 Dec '17

04 Dec '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22671 ) Change subject: internal: Only build on x86 and mipsel ...................................................................... Patch Set 1: Code-Review+2 Tested on raspberry pi. It now compiles without error. -- To view, visit https://review.coreboot.org/22671 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672ddab0415df3baa49ff39a1c9db1b41d8143a4 Gerrit-Change-Number: 22671 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Dec 2017 14:33:58 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: internal: Only build on x86 and mipsel
by David Hendricks (Code Review) 03 Dec '17

03 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22671 ) Change subject: internal: Only build on x86 and mipsel ...................................................................... Patch Set 1: Code-Review+2 I like the clean-up that this accomplishes, so LGTM. Bikeshed: We may want to revisit the name or meaning of "internal" to not exclude ARM and other architectures. The naming is sort of confusing when considering linux_spi and (soon) linux_mtd which also control an internal programmer interface. -- To view, visit https://review.coreboot.org/22671 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672ddab0415df3baa49ff39a1c9db1b41d8143a4 Gerrit-Change-Number: 22671 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 20:00:42 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: Move endianness definitions and provide it inside Makefile
by David Hendricks (Code Review) 03 Dec '17

03 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22670 ) Change subject: Move endianness definitions and provide it inside Makefile ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22670 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55dcf5a88da48f885cda9ad89ab87395d895a891 Gerrit-Change-Number: 22670 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 19:25:15 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: internal: Fix warnings about unused constants
by David Hendricks (Code Review) 03 Dec '17

03 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22669 ) Change subject: internal: Fix warnings about unused constants ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22669 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b6d7c0c2fadc4faeab971673bfadb1a6d25919 Gerrit-Change-Number: 22669 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 19:19:59 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[1.0.x]: README: Update packaging section for Git repositories
by Nico Huber (Code Review) 02 Dec '17

02 Dec '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22672 ) Change subject: README: Update packaging section for Git repositories ...................................................................... Patch Set 1: Code-Review+2 Already reviewed on master. -- To view, visit https://review.coreboot.org/22672 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: I8d9c56be8c1381b175ce7695c53f31b1767d9d17 Gerrit-Change-Number: 22672 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 19:00:35 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[1.0.x]: README: Update packaging section for Git repositories
by build bot (Jenkins) (Code Review) 02 Dec '17

02 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22672 ) Change subject: README: Update packaging section for Git repositories ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/796/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/909/ : SUCCESS -- To view, visit https://review.coreboot.org/22672 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: I8d9c56be8c1381b175ce7695c53f31b1767d9d17 Gerrit-Change-Number: 22672 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 19:00:26 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[1.0.x]: README: Update packaging section for Git repositories
by Nico Huber (Code Review) 02 Dec '17

02 Dec '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22672 Change subject: README: Update packaging section for Git repositories ...................................................................... README: Update packaging section for Git repositories Change-Id: I8d9c56be8c1381b175ce7695c53f31b1767d9d17 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/22454 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> (cherry picked from commit 6891709a1f04a78bc45ad4174f4416f24169a020) --- M README 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/22672/1 diff --git a/README b/README index ab761f7..449103d 100644 --- a/README +++ b/README @@ -24,20 +24,22 @@ Packaging --------- -To package flashrom and remove dependencies on subversion, either use +To package flashrom and remove dependencies on Git, either use make export or make tarball -make export will export all flashrom files from the subversion repository at -revision BASE into a directory named $EXPORTDIR/flashrom-$VERSION-r$SVNREVISION -and will additionally modify the Makefile in that directory to contain the svn -revision of the exported tree. +'make export' will export all flashrom files from the Git repository at +revision HEAD into a directory named "$EXPORTDIR/flashrom-$RELEASENAME" +and will additionally add a "versioninfo.inc" file in that directory to +contain the Git revision of the exported tree and a date for the manual +page. -make tarball will simply tar up the result of make export and gzip compress it. +'make tarball' will simply tar up the result of make export and compress +it with bzip2. -The snapshot tarballs are the result of make tarball and require no further -processing. +The snapshot tarballs are the result of 'make tarball' and require no +further processing. Build Instructions -- To view, visit https://review.coreboot.org/22672 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: newchange Gerrit-Change-Id: I8d9c56be8c1381b175ce7695c53f31b1767d9d17 Gerrit-Change-Number: 22672 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit