- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: AT25SL128A tested PREW
by build bot (Jenkins) (Code Review) 27 May '18

27 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26582 ) Change subject: flashchips: AT25SL128A tested PREW ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1306/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1083/ : SUCCESS -- To view, visit https://review.coreboot.org/26582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32900f742a3b3fb9951eac052cea7631748635e Gerrit-Change-Number: 26582 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 May 2018 12:50:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: AT25SL128A tested PREW
by Hal Martin (Code Review) 27 May '18

27 May '18

Hal Martin has uploaded this change for review. ( https://review.coreboot.org/26582 Change subject: flashchips: AT25SL128A tested PREW ...................................................................... flashchips: AT25SL128A tested PREW Change-Id: If32900f742a3b3fb9951eac052cea7631748635e Signed-off-by: Hal Martin <hal.martin(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/82/26582/1 diff --git a/flashchips.c b/flashchips.c index 4f2edfa..690a059 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2258,7 +2258,7 @@ /* supports SFDP */ /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/26582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If32900f742a3b3fb9951eac052cea7631748635e Gerrit-Change-Number: 26582 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: AT25SL128A tested
by Hal Martin (Code Review) 27 May '18

27 May '18

Hal Martin has abandoned this change. ( https://review.coreboot.org/26581 ) Change subject: flashchips: AT25SL128A tested ...................................................................... Abandoned Merge with existing change 26576 -- To view, visit https://review.coreboot.org/26581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I566717edca34808e5946d841ebf54b0c841ed49e Gerrit-Change-Number: 26581 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: AT25SL128A tested
by Hal Martin (Code Review) 27 May '18

27 May '18

Hal Martin has uploaded this change for review. ( https://review.coreboot.org/26581 Change subject: flashchips: AT25SL128A tested ...................................................................... flashchips: AT25SL128A tested Change-Id: I566717edca34808e5946d841ebf54b0c841ed49e Signed-off-by: Hal Martin <hal.martin(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/26581/1 diff --git a/flashchips.c b/flashchips.c index 4f2edfa..690a059 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2258,7 +2258,7 @@ /* supports SFDP */ /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/26581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I566717edca34808e5946d841ebf54b0c841ed49e Gerrit-Change-Number: 26581 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Add ATMEL AT25SL128A
by build bot (Jenkins) (Code Review) 27 May '18

27 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26576 ) Change subject: flashchips: Add ATMEL AT25SL128A ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1304/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1081/ : SUCCESS -- To view, visit https://review.coreboot.org/26576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c433ffe9e34663c2cfc608b8b76943cd92a8ba Gerrit-Change-Number: 26576 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 May 2018 12:23:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add ATMEL AT25SL128A
by Hal Martin (Code Review) 27 May '18

27 May '18

Hal Martin has uploaded this change for review. ( https://review.coreboot.org/26576 Change subject: flashchips: Add ATMEL AT25SL128A ...................................................................... flashchips: Add ATMEL AT25SL128A Change-Id: I60c433ffe9e34663c2cfc608b8b76943cd92a8ba Signed-off-by: Hal Martin <hal.martin(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/26576/1 diff --git a/flashchips.c b/flashchips.c index 8eda608..4f2edfa 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2248,6 +2248,46 @@ }, { + .vendor = "ATMEL", + .name = "AT25SL128A", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25SL128A, + .total_size = 16384, + .page_size = 256, + /* supports SFDP */ + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, + }, + + { .vendor = "Atmel", .name = "AT26DF041", .bustype = BUS_SPI, diff --git a/flashchips.h b/flashchips.h index f00be3b..f11b0d3 100644 --- a/flashchips.h +++ b/flashchips.h @@ -147,6 +147,7 @@ #define ATMEL_AT25FS010 0x6601 #define ATMEL_AT25FS040 0x6604 #define ATMEL_AT25SF041 0x8401 +#define ATMEL_AT25SL128A 0x4218 #define ATMEL_AT26DF041 0x4400 #define ATMEL_AT26DF081 0x4500 /* guessed, no datasheet available */ #define ATMEL_AT26DF081A 0x4501 -- To view, visit https://review.coreboot.org/26576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I60c433ffe9e34663c2cfc608b8b76943cd92a8ba Gerrit-Change-Number: 26576 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com>

1 0

Change in flashrom[master]: linux_mtd: Import driver from ChromiumOS
by David Hendricks (Code Review) 23 May '18

23 May '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25706 ) Change subject: linux_mtd: Import driver from ChromiumOS ...................................................................... Patch Set 10: (1 comment) https://review.coreboot.org/#/c/25706/10/linux_mtd.c File linux_mtd.c: https://review.coreboot.org/#/c/25706/10/linux_mtd.c@56 PS10, Line 56: msg_perr("Cannot open %s\n", path); > Hmmp, this is on the default path for `-p internal` now... […] Darn. The easy workaround just buries the issue. I also think we should avoid heuristics in try_mtd() since that part of the code should not assume to know which MTD device to test. I think the best place to check this is in linux_mtd_init(). For now we can do a simple check with the assumption that we should not print errors unless the user intentionally specifies a bad sysfs node. Patch here: https://review.coreboot.org/c/flashrom/+/26500 -- To view, visit https://review.coreboot.org/25706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d6bb282863a5cf69909e28a1fc752b35f1b9599 Gerrit-Change-Number: 25706 Gerrit-PatchSet: 10 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 May 2018 05:00:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: linux_mtd: Bail out early if sysfs node doesn't exist
by build bot (Jenkins) (Code Review) 23 May '18

23 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26500 ) Change subject: linux_mtd: Bail out early if sysfs node doesn't exist ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1303/ : SUCCESS -- To view, visit https://review.coreboot.org/26500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dc965eecc68cd305a989016869c688fe1a3921f Gerrit-Change-Number: 26500 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 May 2018 04:54:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: linux_mtd: Bail out early if sysfs node doesn't exist
by David Hendricks (Code Review) 23 May '18

23 May '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26500 to look at the new patch set (#2). Change subject: linux_mtd: Bail out early if sysfs node doesn't exist ...................................................................... linux_mtd: Bail out early if sysfs node doesn't exist This checks that the MTD sysfs node we will use actually exists prior to calling setup code. Although the setup code will eventually catch such an error, we need to think about the use case before printing a possibly irrelevant/confusing error message to the terminal. This patch makes it so that we only print an error message if the user specifies a non-existent MTD device. Otherwise, the failure is considered benign and we only print a debug message prior to bailing out. Change-Id: I8dc965eecc68cd305a989016869c688fe1a3921f Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M linux_mtd.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/26500/2 -- To view, visit https://review.coreboot.org/26500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8dc965eecc68cd305a989016869c688fe1a3921f Gerrit-Change-Number: 26500 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: linux_mtd: Bail out early if sysfs node doesn't exist
by build bot (Jenkins) (Code Review) 23 May '18

23 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26500 ) Change subject: linux_mtd: Bail out early if sysfs node doesn't exist ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1302/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1080/ : SUCCESS -- To view, visit https://review.coreboot.org/26500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dc965eecc68cd305a989016869c688fe1a3921f Gerrit-Change-Number: 26500 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 May 2018 04:53:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit