- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs
by David Hendricks (Code Review) 28 May '18

28 May '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/26232 ) Change subject: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Looks good, though you may wanna add the Z370 PCI ID while you're at it. https://review.coreboot.org/#/c/26232/1/chipset_enable.c File chipset_enable.c: https://review.coreboot.org/#/c/26232/1/chipset_enable.c@1952 PS1, Line 1952: {0x8086, 0xa2c8, NT, "Intel", "B250", enable_flash_pch100}, Revision 003 of the spec also mentions 0xa2c9 for the Z370. -- To view, visit https://review.coreboot.org/26232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Gerrit-Change-Number: 26232 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 May 2018 23:35:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: AT25SL128A tested PREW
by David Hendricks (Code Review) 28 May '18

28 May '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/26582 ) Change subject: flashchips: AT25SL128A tested PREW ...................................................................... Patch Set 1: Code-Review-1 Please squash this into the previous patch. -- To view, visit https://review.coreboot.org/26582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32900f742a3b3fb9951eac052cea7631748635e Gerrit-Change-Number: 26582 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 May 2018 23:17:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add ATMEL AT25SL128A
by David Hendricks (Code Review) 28 May '18

28 May '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/26576 ) Change subject: flashchips: Add ATMEL AT25SL128A ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/26576/1/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/26576/1/flashchips.c@2261 PS1, Line 2261: TEST_UNTESTED Update this too since you have tested it. -- To view, visit https://review.coreboot.org/26576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c433ffe9e34663c2cfc608b8b76943cd92a8ba Gerrit-Change-Number: 26576 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Mon, 28 May 2018 23:17:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add ATMEL AT25SL128A
by David Hendricks (Code Review) 28 May '18

28 May '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/26576 ) Change subject: flashchips: Add ATMEL AT25SL128A ...................................................................... Patch Set 1: (1 comment) One small nit, otherwise looks good. Thanks! https://review.coreboot.org/#/c/26576/1/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/26576/1/flashchips.c@2287 PS1, Line 2287: 1650, 1950 Voltage tolerance is 1.7-2.0 according to the datasheet, so this should be {1700, 2000}. -- To view, visit https://review.coreboot.org/26576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c433ffe9e34663c2cfc608b8b76943cd92a8ba Gerrit-Change-Number: 26576 Gerrit-PatchSet: 1 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Mon, 28 May 2018 23:16:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Remove white space before tab
by Nico Huber (Code Review) 28 May '18

28 May '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26652 ) Change subject: Remove white space before tab ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/26652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90f171924790ced74a62ca344fee8607607aa480 Gerrit-Change-Number: 26652 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 May 2018 18:37:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Enable writes with active ME
by Arthur Heymans (Code Review) 28 May '18

28 May '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/26261 ) Change subject: Enable writes with active ME ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/26261 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Gerrit-Change-Number: 26261 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 May 2018 17:50:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove white space before tab
by build bot (Jenkins) (Code Review) 28 May '18

28 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26652 ) Change subject: Remove white space before tab ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1308/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1085/ : SUCCESS -- To view, visit https://review.coreboot.org/26652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90f171924790ced74a62ca344fee8607607aa480 Gerrit-Change-Number: 26652 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 May 2018 15:04:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove white space before tab
by Elyes HAOUAS (Code Review) 28 May '18

28 May '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26652 to look at the new patch set (#2). Change subject: Remove white space before tab ...................................................................... Remove white space before tab Change-Id: I90f171924790ced74a62ca344fee8607607aa480 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M board_enable.c M dediprog.c M flashchips.h M it85spi.c M pcidev.c M pickit2_spi.c M print.c 7 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/26652/2 -- To view, visit https://review.coreboot.org/26652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I90f171924790ced74a62ca344fee8607607aa480 Gerrit-Change-Number: 26652 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove white space before tab
by build bot (Jenkins) (Code Review) 28 May '18

28 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26652 ) Change subject: Remove white space before tab ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1307/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1084/ : SUCCESS -- To view, visit https://review.coreboot.org/26652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90f171924790ced74a62ca344fee8607607aa480 Gerrit-Change-Number: 26652 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 May 2018 14:55:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove white space before tab
by Elyes HAOUAS (Code Review) 28 May '18

28 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26652 Change subject: Remove white space before tab ...................................................................... Remove white space before tab Change-Id: I90f171924790ced74a62ca344fee8607607aa480 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M board_enable.c M dediprog.c M flashchips.h M it85spi.c M pcidev.c M pickit2_spi.c M print.c 7 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/26652/1 diff --git a/board_enable.c b/board_enable.c index a09a075..c3494bd 100644 --- a/board_enable.c +++ b/board_enable.c @@ -527,10 +527,10 @@ /* CR24 Bits 7 & 2 must be set to 0 enable the flash ROM */ /* address segments 000E0000h ~ 000FFFFFh on W83697SF/UF/UG */ - /* These bits are reserved on W83697HF/F/HG */ - /* Shouldn't be needed though. */ + /* These bits are reserved on W83697HF/F/HG */ + /* Shouldn't be needed though. */ - /* CR28 Bit3 must be set to 1 to enable flash access to */ + /* CR28 Bit3 must be set to 1 to enable flash access to */ /* FFE80000h ~ FFEFFFFFh on W83697SF/UF/UG. */ /* This bit is reserved on W83697HF/F/HG which default to 0 */ sio_mask(port, 0x28, 0x08, 0x08); diff --git a/dediprog.c b/dediprog.c index ef43e90..7fcadfb 100644 --- a/dediprog.c +++ b/dediprog.c @@ -121,7 +121,7 @@ }; enum dediprog_writemode { - WRITE_MODE_PAGE_PGM = 1, + WRITE_MODE_PAGE_PGM = 1, WRITE_MODE_PAGE_WRITE = 2, WRITE_MODE_1B_AAI = 3, WRITE_MODE_2B_AAI = 4, diff --git a/flashchips.h b/flashchips.h index f00be3b..5c10b4f 100644 --- a/flashchips.h +++ b/flashchips.h @@ -146,7 +146,7 @@ #define ATMEL_AT25F4096 0x64 /* Needs AT25F_RDID */ #define ATMEL_AT25FS010 0x6601 #define ATMEL_AT25FS040 0x6604 -#define ATMEL_AT25SF041 0x8401 +#define ATMEL_AT25SF041 0x8401 #define ATMEL_AT26DF041 0x4400 #define ATMEL_AT26DF081 0x4500 /* guessed, no datasheet available */ #define ATMEL_AT26DF081A 0x4501 diff --git a/it85spi.c b/it85spi.c index f7bc8cb..e47cabb 100644 --- a/it85spi.c +++ b/it85spi.c @@ -53,8 +53,8 @@ * IBF is set to 1 when the host CPU sends a command to the input buffer * of the EC. IBF is cleared to 0 once the command is read by the EC. */ -#define KB_IBF (1 << 1) /* Input Buffer Full */ -#define KB_OBF (1 << 0) /* Output Buffer Full */ +#define KB_IBF (1 << 1) /* Input Buffer Full */ +#define KB_OBF (1 << 0) /* Output Buffer Full */ /* IT8502 supports two access modes: * LPC_MEMORY: through the memory window in 0xFFFFFxxx (follow mode) diff --git a/pcidev.c b/pcidev.c index 3273341..8f9773b 100644 --- a/pcidev.c +++ b/pcidev.c @@ -293,7 +293,7 @@ return 0; } -#define register_undo_pci_write(a, b, c) \ +#define register_undo_pci_write(a, b, c) \ { \ struct undo_pci_write_data *undo_pci_write_data; \ undo_pci_write_data = malloc(sizeof(struct undo_pci_write_data)); \ diff --git a/pickit2_spi.c b/pickit2_spi.c index 037c6dd..a7c90a5 100644 --- a/pickit2_spi.c +++ b/pickit2_spi.c @@ -449,7 +449,7 @@ (void)usb_find_devices(); const uint16_t vid = devs_pickit2_spi[0].vendor_id; const uint16_t pid = devs_pickit2_spi[0].device_id; - struct usb_device *dev = get_device_by_vid_pid(vid, pid, usedevice); + struct usb_device *dev = get_device_by_vid_pid(vid, pid, usedevice); if (dev == NULL) { msg_perr("Could not find a PICkit2 on USB!\n"); return 1; diff --git a/print.c b/print.c index 114181e..30f06c8 100644 --- a/print.c +++ b/print.c @@ -974,7 +974,7 @@ B("MSI", "MS-7312 (K9MM-V)", OK, "http://www.msi.com/product/mb/K9MM-V.html", NULL), B("MSI", "MS-7336", OK, NULL, "Some non-essential DMI data (e.g. serial numbers) is overwritten when using flashrom. This is an OEM board used by HP (e.g. dx2300 Microtower)."), B("MSI", "MS-7345 (P35 Neo2-FIR)", OK, "http://www.msi.com/product/mb/P35-Neo2-FR---FIR.html", NULL), - B("MSI", "MS-7357 (G33M)", OK, "http://www.msi.com/product/mb/G33M.html", NULL), + B("MSI", "MS-7357 (G33M)", OK, "http://www.msi.com/product/mb/G33M.html", NULL), B("MSI", "MS-7368 (K9AG Neo2-Digital)", OK, "http://www.msi.com/product/mb/K9AG-Neo2-Digital.html", NULL), B("MSI", "MS-7369 (K9N Neo V2)", OK, "http://www.msi.com/product/mb/K9N-Neo-V2.html", NULL), B("MSI", "MS-7376 (K9A2 Platinum V1)", OK, "http://www.msi.com/product/mb/K9A2-Platinum.html", NULL), -- To view, visit https://review.coreboot.org/26652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I90f171924790ced74a62ca344fee8607607aa480 Gerrit-Change-Number: 26652 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit