- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23338 ) Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1213/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1012/ : SUCCESS -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 4 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 20:45:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by Lubomir Rintel (Code Review) 15 Mar '18

15 Mar '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23338 to look at the new patch set (#4). Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... digilent_spi: add a driver for the iCEblink40 development board This is driver that supports the Lattice iCE40 evaluation kits. On the board is a SPI flash memory chip labeled ST 25P10VP. Tested to work read/write/erase with "-p digilent_spi -c M25P10" or with a patch that resets the part beforehands (in which case it gets detected as a M25P10-A and is way faster due to paged writes). Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M Makefile A digilent_spi.c M flashrom.8.tmpl M flashrom.c M programmer.h 5 files changed, 465 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/23338/4 -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 4 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by Lubomir Rintel (Code Review) 15 Mar '18

15 Mar '18

Lubomir Rintel has posted comments on this change. ( https://review.coreboot.org/23338 ) Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... Patch Set 3: > Patch Set 2: > > (15 comments) > > Code looks quite nice :) haven't looked at the protocol yet, though. Hi. Thanks for the review & the issues you found. I believe I addressed all of them but the first one (the "or later" clause in the GPL header). I'd indeed prefer the less restrictive use of GPL, however the small part of the driver (the "spispeed" option parsing) was derived from linux_spi.c which seems to be GPLv2 only. Perhaps that needs to be reworked instead anyway -- the hardware seems to accept only these speeds (in Hz): 62500 125000 250000 500000 1000000 2000000 4000000 The protocol allows setting any speed though, falling back to a slower supported frequency. The first one (62500) isn't even currently settable as the "spispeed" takes a kHz value and 62500 is not a multiply of 1000. -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 3 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 20:11:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23338 ) Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1212/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1011/ : SUCCESS -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 3 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 19:48:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by Lubomir Rintel (Code Review) 15 Mar '18

15 Mar '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23338 to look at the new patch set (#3). Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... digilent_spi: add a driver for the iCEblink40 development board This is driver that supports the Lattice iCE40 evaluation kits. On the board is a SPI flash memory chip labeled ST 25P10VP. Tested to work read/write/erase with "-p digilent_spi -c M25P10" or with a patch that resets the part beforehands (in which case it gets detected as a M25P10-A and is way faster due to paged writes). Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M Makefile A digilent_spi.c M flashrom.c M programmer.h 4 files changed, 420 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/23338/3 -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 3 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: linux_spi: Reduce maximum read chunksize
by Julian von Mendel (Code Review) 14 Mar '18

14 Mar '18

Julian von Mendel has posted comments on this change. ( https://review.coreboot.org/25149 ) Change subject: linux_spi: Reduce maximum read chunksize ...................................................................... Patch Set 1: Code-Review+1 Tested and fixed ioctl issues in my setup Linux raspberrypi 3.6.11+ #371 PREEMPT Thu Feb 7 16:31:35 GMT 2013 armv6l GNU/Linux -- To view, visit https://review.coreboot.org/25149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Gerrit-Change-Number: 25149 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 16:12:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: linux_spi: Reduce maximum read chunksize
by Nico Huber (Code Review) 14 Mar '18

14 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25149 ) Change subject: linux_spi: Reduce maximum read chunksize ...................................................................... Patch Set 1: Julian, this should fix your "ioctl: Message too long" problem. Please test. -- To view, visit https://review.coreboot.org/25149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Gerrit-Change-Number: 25149 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 11:08:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1211/ : SUCCESS -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 9 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Wed, 14 Mar 2018 11:04:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by Nico Huber (Code Review) 14 Mar '18

14 Mar '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Add support for Atmel / Adesto AT25SF041 SPI flash chip probe/erase/read/write/verify hardware-tests were done. Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Signed-off-by: Julian von Mendel <git(a)jinvent.de> Signed-off-by: jvm <git(a)jinvent.de> Reviewed-on: https://review.coreboot.org/25047 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 1ab4986..46e8807 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2177,6 +2177,44 @@ { .vendor = "Atmel", + .name = "AT25SF041", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25SF041, + .total_size = 512, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 16} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2500, 3600}, + }, + + { + .vendor = "Atmel", .name = "AT26DF041", .bustype = BUS_SPI, .manufacture_id = ATMEL_ID, diff --git a/flashchips.h b/flashchips.h index 452f776..98d6e03 100644 --- a/flashchips.h +++ b/flashchips.h @@ -150,6 +150,7 @@ #define ATMEL_AT25F4096 0x64 /* Needs AT25F_RDID */ #define ATMEL_AT25FS010 0x6601 #define ATMEL_AT25FS040 0x6604 +#define ATMEL_AT25SF041 0x8401 #define ATMEL_AT26DF041 0x4400 #define ATMEL_AT26DF081 0x4500 /* guessed, no datasheet available */ #define ATMEL_AT26DF081A 0x4501 -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 9 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[1.0.x]: linux_spi: Reduce maximum read chunksize
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25150 ) Change subject: linux_spi: Reduce maximum read chunksize ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1210/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1010/ : SUCCESS -- To view, visit https://review.coreboot.org/25150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Gerrit-Change-Number: 25150 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 11:01:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit